inference params support #8252
inference params support #8252
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| static TVector<TString> GetPartitionedByConfig(std::shared_ptr<TMetadata> meta) { | ||
| TVector<TString> columns; | ||
| if (auto partitioned = meta->Attributes.FindPtr("partitionedby"); partitioned) { | ||
| NJson::TJsonValue values; |
There was a problem hiding this comment.
А сюда не может partitionedby не валидный долететь? Валидации случайно не позже делаются?
There was a problem hiding this comment.
что ты имеешь в виду под невалидным partitionedby? повторяющиеся колонки?
| CurrentSource = nullptr; | ||
| }; | ||
|
|
||
| void VisitAttribute(TString key, TString value) override { |
There was a problem hiding this comment.
а почему эта ветка может отработать для partitionedby? Для случая с одной колонкой?
There was a problem hiding this comment.
да, для случая с одной колонкой
There was a problem hiding this comment.
ох, жуть какая получается. Получается другие параметры могу тоже на половину работать)
ydb/core/external_sources/object_storage/inference/infer_config.cpp
Outdated
Show resolved
Hide resolved
| ui64 Size = 0; | ||
| }; | ||
|
|
||
| struct TEvInferPartitions : public NActors::TEventLocal<TEvInferPartitions, EvInferPartitions> { |
There was a problem hiding this comment.
А обязательно отдельный message для этого? Сам вывод можно inplace делать? Или это задел на будущее?
There was a problem hiding this comment.
мы для колонок используем фиксированный формат и конфиг, нам либо нужно их вместе с message-ем пробрасывать, либо сделать отдельный message для инферринга колонок
There was a problem hiding this comment.
А общим message не удобнее будет это сделать? Лишних сообщений не будет. Тут уже на твое усмотрение, как тебе удобнее
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ui64 Size = 0; | ||
| }; | ||
|
|
||
| struct TEvInferPartitions : public NActors::TEventLocal<TEvInferPartitions, EvInferPartitions> { |
There was a problem hiding this comment.
А общим message не удобнее будет это сделать? Лишних сообщений не будет. Тут уже на твое усмотрение, как тебе удобнее
| CurrentSource = nullptr; | ||
| }; | ||
|
|
||
| void VisitAttribute(TString key, TString value) override { |
There was a problem hiding this comment.
ох, жуть какая получается. Получается другие параметры могу тоже на половину работать)
evanevanevanevannnn
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
3 participants
Changelog entry
support for
partitioned_by,file_patternandcsv_delimiterparameters with schema inferenceChangelog category