-
Notifications
You must be signed in to change notification settings - Fork 735
The code has been got rid of the TS3ReadActorFactoryConfig #8181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The code has been got rid of the TS3ReadActorFactoryConfig #8181
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| } | ||
|
|
||
| message TReadActorsFactoryConfig { | ||
| TS3ReadActorFactoryConfig S3ReadActorFactoryConfig = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Предлагаю сначала выпилить из всех конфигов, затем раскатать их на прод, потом уже удалять из прото
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, так и хочу сделать. Подготовил отделное ревью для удаления конфигов https://a.yandex-team.ru/review/6585395/details. А это будет висеть пока в проде не обновим.
b469990 to
01d6e9b
Compare
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
Проверил dqrun на локальных файлах, выглядит рабочим. мержу |
Changelog entry
...
Changelog category
Additional information
...