[YQL-17453] Fix expanding DqReplicate with different input/output stream/flow types #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nepal
commented
Dec 29, 2023
nepal
commented
- fix DqReplicate expansion
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-release-asan: some tests FAILED for commit 1db72be.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 1db72be.
|
vitstn
approved these changes
Dec 29, 2023
rvu1024
reviewed
Dec 30, 2023
| TVector<TExprBase> branches; | ||
| branches.reserve(dqReplicate.Args().Count() - 1); | ||
| const auto inputKind = dqReplicate.Arg(0).Ref().GetTypeAnn()->GetKind(); | ||
| YQL_ENSURE(inputKind == ETypeAnnotationKind::Stream || inputKind == ETypeAnnotationKind::Flow); |
Member
There was a problem hiding this comment.
Разве может быть что-то другое по типизации?
| branches.emplace_back(ctx.DeepCopyLambda(dqReplicate.Args().Get(i).Ref())); | ||
| const auto lambdaOutputKind = dqReplicate.Arg(i).Ref().GetTypeAnn()->GetKind(); | ||
| YQL_ENSURE(lambdaOutputKind == ETypeAnnotationKind::Stream || lambdaOutputKind == ETypeAnnotationKind::Flow); | ||
| if (lambdaOutputKind != inputKind) { |
Member
There was a problem hiding this comment.
Как вообще могли получаться в DqReplicate лямбды с разными типами? Типизация DqReplicate не проверяет что ли это? Если нет, то нужно там править и править оптимизаторы, которые это порождают
Collaborator
Author
There was a problem hiding this comment.
не проверяет и не было очевидно что должна проверять
This was referenced Jan 15, 2024
Merged
This was referenced Jan 17, 2024
Merged
This was referenced Jan 25, 2024
Merged
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.