Skip to content

ExecuteData set transaction mode always #7982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Aug 19, 2024

#8051
added default serializable-read-write TransactionMode to execute-data query

Changelog category

  • Bugfix

Additional information

...

@StekPerepolnen StekPerepolnen requested review from a team as code owners August 19, 2024 07:56
@StekPerepolnen StekPerepolnen changed the title Removed deprecated proto field (#7842) Default transation mode Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 07:58:46 UTC Pre-commit check for bf9cdb6 has started.
2024-08-19 08:00:09 UTC Check cancelled

Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 07:59:14 UTC Pre-commit check for bf9cdb6 has started.
2024-08-19 08:00:09 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the json_query_transaction_mode_default_2 branch from ed4c915 to 4c68404 Compare August 19, 2024 07:59
Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 08:00:44 UTC Pre-commit check for 6179646 has started.
2024-08-19 08:03:15 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-19 10:16:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9869 9787 0 17 31 34

🟢 2024-08-19 10:16:54 UTC Build successful.
🟢 2024-08-19 10:17:21 UTC ydbd size 5.5 GiB changed* by -68.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 274bfdd merge: 6179646 diff diff %
ydbd size 5 880 316 984 Bytes 5 880 246 968 Bytes -68.4 KiB -0.001%
ydbd stripped size 1 477 405 904 Bytes 1 477 395 536 Bytes -10.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 08:01:34 UTC Pre-commit check for 6179646 has started.
2024-08-19 08:04:19 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-19 09:21:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14087 12708 0 2 1338 39

2024-08-19 09:22:16 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-19 09:29:28 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 19 0 0 1 28

🟢 2024-08-19 09:29:36 UTC Build successful.
🟢 2024-08-19 09:30:17 UTC ydbd size 8.1 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5522a96 merge: 6179646 diff diff %
ydbd size 8 736 888 376 Bytes 8 736 888 392 Bytes +16 Bytes +0.000%
ydbd stripped size 475 560 200 Bytes 475 560 200 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 08:01:34 UTC Pre-commit check for 6179646 has started.
2024-08-19 08:05:03 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-19 08:11:17 UTC Build successful.

@StekPerepolnen StekPerepolnen requested a review from adameat August 19, 2024 08:09
@StekPerepolnen StekPerepolnen changed the title Default transation mode Default transaction mode Aug 19, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 19, 2024
adameat
adameat previously approved these changes Aug 19, 2024
@StekPerepolnen StekPerepolnen force-pushed the json_query_transaction_mode_default_2 branch 2 times, most recently from 98df417 to 0f0cc63 Compare August 20, 2024 09:17
Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 09:19:12 UTC Pre-commit check for 09af560 has started.
2024-08-20 09:22:04 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-20 09:49:10 UTC Build successful.

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 09:19:28 UTC Pre-commit check for 09af560 has started.
2024-08-20 09:22:30 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-20 10:46:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14136 12751 0 7 1343 35

2024-08-20 10:47:18 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-20 10:54:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
56 (only retried tests) 28 0 1 0 27

2024-08-20 10:54:52 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-20 11:01:27 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 (only retried tests) 16 0 0 0 27

🟢 2024-08-20 11:01:34 UTC Build successful.
🟡 2024-08-20 11:02:14 UTC ydbd size 8.1 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0f0f3bc merge: 09af560 diff diff %
ydbd size 8 747 173 344 Bytes 8 748 342 912 Bytes +1.1 MiB +0.013%
ydbd stripped size 475 746 024 Bytes 475 796 776 Bytes +49.6 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen requested a review from adameat August 20, 2024 09:19
Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 09:19:53 UTC Pre-commit check for 09af560 has started.
2024-08-20 09:23:47 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-20 11:06:58 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9725 9626 0 33 29 37

🟢 2024-08-20 11:07:48 UTC Build successful.
🟡 2024-08-20 11:08:19 UTC ydbd size 5.5 GiB changed* by +963.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0f0f3bc merge: 09af560 diff diff %
ydbd size 5 886 495 384 Bytes 5 887 482 128 Bytes +963.6 KiB +0.017%
ydbd stripped size 1 478 181 648 Bytes 1 478 367 984 Bytes +182.0 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen changed the title Default transaction mode ExecuteData set transaction mode always Aug 20, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 20, 2024
StekPerepolnen added a commit to StekPerepolnen/ydb that referenced this pull request Aug 21, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
StekPerepolnen added a commit to StekPerepolnen/ydb that referenced this pull request Aug 26, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
StekPerepolnen added a commit to StekPerepolnen/ydb that referenced this pull request Aug 26, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 26, 2024
StekPerepolnen added a commit to StekPerepolnen/ydb that referenced this pull request Aug 26, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
StekPerepolnen added a commit to StekPerepolnen/ydb that referenced this pull request Aug 27, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
StekPerepolnen added a commit to StekPerepolnen/ydb that referenced this pull request Aug 27, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 28, 2024
StekPerepolnen added a commit that referenced this pull request Aug 28, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
adameat pushed a commit to adameat/ydb that referenced this pull request Oct 1, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
adameat pushed a commit to adameat/ydb that referenced this pull request Oct 4, 2024
Co-authored-by: Ivan Sukhov <evanevannnn@ydb.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants