PgWire auth with ApiKey #7973
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,13 @@ | ||
| #pragma once | ||
|
|
||
| #include "local_pgwire_util.h" | ||
| #include <ydb/library/actors/core/actor.h> | ||
|
|
||
| namespace NLocalPgWire { | ||
|
|
||
| inline NActors::TActorId CreateLocalPgWireProxyId(uint32_t nodeId = 0) { return NActors::TActorId(nodeId, "localpgwire"); } | ||
| NActors::IActor* CreateLocalPgWireProxy(); | ||
|
|
||
| NActors::IActor* CreateLocalPgWireAuthActor(const TPgWireAuthData& pgWireAuthData, const NActors::TActorId& pgYdbProxy); | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,192 @@ | ||
| #include "log_impl.h" | ||
| #include "local_pgwire.h" | ||
| #include "local_pgwire_util.h" | ||
|
|
||
| #include <ydb/core/base/path.h> | ||
| #include <ydb/core/base/ticket_parser.h> | ||
| #include <ydb/core/grpc_services/local_rpc/local_rpc.h> | ||
| #include <ydb/core/tx/scheme_cache/scheme_cache.h> | ||
|
|
||
| #include <ydb/library/actors/core/actor.h> | ||
| #include <ydb/library/actors/core/actor_bootstrapped.h> | ||
|
|
||
| #include <ydb/public/api/grpc/ydb_auth_v1.grpc.pb.h> | ||
|
|
||
| #include <ydb/services/persqueue_v1/actors/persqueue_utils.h> | ||
|
|
||
| namespace NLocalPgWire { | ||
|
|
||
| using namespace NActors; | ||
| using namespace NKikimr; | ||
|
|
||
| class TPgYdbAuthActor : public NActors::TActorBootstrapped<TPgYdbAuthActor> { | ||
| using TBase = TActor<TPgYdbAuthActor>; | ||
|
|
||
| struct TEvPrivate { | ||
| enum EEv { | ||
| EvTokenReady = EventSpaceBegin(NActors::TEvents::ES_PRIVATE), | ||
| EvAuthFailed, | ||
| EvEnd | ||
| }; | ||
|
|
||
| static_assert(EvEnd < EventSpaceEnd(NActors::TEvents::ES_PRIVATE), "expect EvEnd < EventSpaceEnd(NActors::TEvents::ES_PRIVATE)"); | ||
|
|
||
| struct TEvTokenReady : TEventLocal<TEvTokenReady, EvTokenReady> { | ||
| Ydb::Auth::LoginResult LoginResult; | ||
|
|
||
| TEvTokenReady() = default; | ||
| }; | ||
|
|
||
| struct TEvAuthFailed : NActors::TEventLocal<TEvAuthFailed, EvAuthFailed> { | ||
| TString ErrorMessage; | ||
| }; | ||
| }; | ||
|
|
||
| TPgWireAuthData PgWireAuthData; | ||
| TActorId PgYdbProxy; | ||
|
|
||
| TString DatabaseId; | ||
| TString FolderId; | ||
| TString SerializedToken; | ||
| TString Ticket; | ||
|
|
||
| public: | ||
| TPgYdbAuthActor(const TPgWireAuthData& pgWireAuthData, const TActorId& pgYdbProxy) | ||
| : PgWireAuthData(pgWireAuthData) | ||
| , PgYdbProxy(pgYdbProxy) { | ||
| } | ||
|
|
||
| void Bootstrap() { | ||
| if (PgWireAuthData.UserName == "__ydb_apikey") { | ||
| if (PgWireAuthData.Password.empty()) { | ||
| SendResponseAndDie("Invalid password"); | ||
| } | ||
| SendDescribeRequest(); | ||
|
There was a problem hiding this comment. may be move functions |
||
| } else { | ||
| SendLoginRequest(); | ||
| } | ||
|
|
||
| Become(&TPgYdbAuthActor::StateWork); | ||
| } | ||
|
|
||
| void Handle(TEvTicketParser::TEvAuthorizeTicketResult::TPtr& ev) { | ||
| if (ev->Get()->Error) { | ||
| SendResponseAndDie(ev->Get()->Error.Message); | ||
| return; | ||
| } | ||
|
|
||
shnikd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| SerializedToken = ev->Get()->SerializedToken; | ||
| Ticket = ev->Get()->Ticket; | ||
|
|
||
| SendResponseAndDie(); | ||
| } | ||
|
|
||
| void Handle(TEvPrivate::TEvTokenReady::TPtr& ev) { | ||
| Send(MakeTicketParserID(), new TEvTicketParser::TEvAuthorizeTicket({ | ||
| .Database = PgWireAuthData.DatabasePath, | ||
| .Ticket = ev->Get()->LoginResult.token(), | ||
| .PeerName = PgWireAuthData.PeerName, | ||
| })); | ||
| } | ||
|
|
||
| void Handle(TEvPrivate::TEvAuthFailed::TPtr& ev) { | ||
| SendResponseAndDie(ev->Get()->ErrorMessage); | ||
| } | ||
|
|
||
| void Handle(NKikimr::TEvTxProxySchemeCache::TEvNavigateKeySetResult::TPtr& ev) { | ||
| const NKikimr::NSchemeCache::TSchemeCacheNavigate* navigate = ev->Get()->Request.Get(); | ||
| if (navigate->ErrorCount) { | ||
| SendResponseAndDie(TStringBuilder() << "Database with path '" << PgWireAuthData.DatabasePath << "' doesn't exists"); | ||
| return; | ||
| } | ||
| Y_ABORT_UNLESS(navigate->ResultSet.size() == 1); | ||
|
|
||
| const auto& entry = navigate->ResultSet.front(); | ||
|
|
||
| for (const auto& attr : entry.Attributes) { | ||
| if (attr.first == "folderId") FolderId = attr.second; | ||
| else if (attr.first == "database_id") DatabaseId = attr.second; | ||
| } | ||
|
|
||
| SendApiKeyRequest(); | ||
| } | ||
|
|
||
| STATEFN(StateWork) { | ||
| switch (ev->GetTypeRewrite()) { | ||
| hFunc(TEvPrivate::TEvTokenReady, Handle); | ||
| hFunc(TEvTicketParser::TEvAuthorizeTicketResult, Handle); | ||
| hFunc(TEvTxProxySchemeCache::TEvNavigateKeySetResult, Handle); | ||
| hFunc(TEvPrivate::TEvAuthFailed, Handle); | ||
| } | ||
| } | ||
| private: | ||
| void SendLoginRequest() { | ||
| Ydb::Auth::LoginRequest request; | ||
| request.set_user(PgWireAuthData.UserName); | ||
| if (!PgWireAuthData.Password.empty()) { | ||
| request.set_password(PgWireAuthData.Password); | ||
| } | ||
|
|
||
| auto* actorSystem = TActivationContext::ActorSystem();; | ||
|
|
||
| using TRpcEv = NGRpcService::TGRpcRequestWrapperNoAuth<NGRpcService::TRpcServices::EvLogin, Ydb::Auth::LoginRequest, Ydb::Auth::LoginResponse>; | ||
| auto rpcFuture = NRpcService::DoLocalRpc<TRpcEv>(std::move(request), PgWireAuthData.DatabasePath, {}, actorSystem); | ||
| rpcFuture.Subscribe([actorSystem, selfId = SelfId()](const NThreading::TFuture<Ydb::Auth::LoginResponse>& future) { | ||
| auto& response = future.GetValueSync(); | ||
| if (response.operation().status() == Ydb::StatusIds::SUCCESS) { | ||
| auto tokenReady = std::make_unique<TEvPrivate::TEvTokenReady>(); | ||
| response.operation().result().UnpackTo(&(tokenReady->LoginResult)); | ||
| actorSystem->Send(selfId, tokenReady.release()); | ||
| } else { | ||
| auto authFailedEvent = std::make_unique<TEvPrivate::TEvAuthFailed>(); | ||
| if (response.operation().issues_size() > 0) { | ||
| authFailedEvent->ErrorMessage = response.operation().issues(0).message(); | ||
| } else { | ||
| authFailedEvent->ErrorMessage = Ydb::StatusIds_StatusCode_Name(response.operation().status()); | ||
| } | ||
| actorSystem->Send(selfId, authFailedEvent.release()); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| void SendApiKeyRequest() { | ||
| auto entries = NKikimr::NGRpcProxy::V1::GetTicketParserEntries(DatabaseId, FolderId); | ||
|
|
||
| Send(NKikimr::MakeTicketParserID(), new NKikimr::TEvTicketParser::TEvAuthorizeTicket({ | ||
| .Database = PgWireAuthData.DatabasePath, | ||
| .Ticket = "ApiKey " + PgWireAuthData.Password, | ||
| .PeerName = PgWireAuthData.PeerName, | ||
| .Entries = entries | ||
| })); | ||
| } | ||
|
|
||
| void SendDescribeRequest() { | ||
| auto schemeCacheRequest = std::make_unique<NKikimr::NSchemeCache::TSchemeCacheNavigate>(); | ||
| NKikimr::NSchemeCache::TSchemeCacheNavigate::TEntry entry; | ||
| entry.Path = NKikimr::SplitPath(PgWireAuthData.DatabasePath); | ||
| entry.Operation = NKikimr::NSchemeCache::TSchemeCacheNavigate::OpPath; | ||
| entry.SyncVersion = false; | ||
| schemeCacheRequest->ResultSet.emplace_back(entry); | ||
| Send(NKikimr::MakeSchemeCacheID(), MakeHolder<NKikimr::TEvTxProxySchemeCache::TEvNavigateKeySet>(schemeCacheRequest.release())); | ||
| } | ||
|
|
||
| void SendResponseAndDie(const TString& errorMessage = "") { | ||
| std::unique_ptr<TEvEvents::TEvAuthResponse> authResponse; | ||
| if (!errorMessage.empty()) { | ||
| authResponse = std::make_unique<TEvEvents::TEvAuthResponse>(errorMessage, PgWireAuthData.Sender); | ||
| } else { | ||
| authResponse = std::make_unique<TEvEvents::TEvAuthResponse>(SerializedToken, Ticket, PgWireAuthData.Sender); | ||
| } | ||
|
|
||
| Send(PgYdbProxy, authResponse.release()); | ||
|
|
||
| PassAway(); | ||
| } | ||
| }; | ||
|
|
||
|
|
||
| NActors::IActor* CreateLocalPgWireAuthActor(const TPgWireAuthData& pgWireAuthData, const TActorId& pgYdbProxy) { | ||
| return new TPgYdbAuthActor(pgWireAuthData, pgYdbProxy); | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.