Skip to content

Conversation

@alexv-smirnov
Copy link
Member

No description provided.

robot-piglet and others added 9 commits August 14, 2024 22:05
6aa88a1c73ee8fb7fa669994cefd9bc31065446b
16d29b1b377145b9464d5280244b000f207c4563
Данный PR - это выжимка из [PR](#2977) внешнего [контрибьютора](https://github.com/OrlovPavel ). Ему для решения основной задачи (перевод грамматики YQL с ANTLRv3 на ANTLRv4) пришлось поправить файл build/scripts/configure_file.py в проекте github.com/ydb-platform/ydb.
Собственно, в проекте YDB запрещено вносить правки в build/..., т.к. эта папка синкается ТОЛЬКО из Аркадии в гитхаб, в обратную сторону синка нет. Из-за этого мы не можем принять PR от внешнего контрибьютора.
В качестве решения - я хочу занести данный фикс в Аркадию и дождаться синка из Аркадии в гитхаб, по-rebase-ить PR контрибьютора и тогда его уже можно будет мерджить.
Сама проблема, которую решает данный фикс, описана в тикете
158ceea6282b8df7c8b62a43ffece62a8d9f70ca
grpc/grpc@abbaa20 -- коммит который бэкпортится, доп инфа в тикете
66e2b3bb0cc6c90cb9387ff0e5766abd2780b5c7
ee58dd90305b5dd3c29edfc95a3ddb7c2395d2bf
@github-actions
Copy link

github-actions bot commented Aug 15, 2024

2024-08-15 10:30:21 UTC Pre-commit check for fa38954 has started.
2024-08-15 10:34:46 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 10:41:18 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 15, 2024

2024-08-15 10:31:30 UTC Pre-commit check for fa38954 has started.
2024-08-15 10:34:40 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 14:03:19 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15480 15394 0 20 32 34

🟢 2024-08-15 14:04:37 UTC Build successful.
🟢 2024-08-15 14:05:11 UTC ydbd size 5.5 GiB changed* by +368 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c26bd91 merge: fa38954 diff diff %
ydbd size 5 877 755 344 Bytes 5 877 755 712 Bytes +368 Bytes +0.000%
ydbd stripped size 1 476 699 760 Bytes 1 476 699 696 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 15, 2024

2024-08-15 10:42:37 UTC Pre-commit check for fa38954 has started.
2024-08-15 10:46:02 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-08-15 12:08:19 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77202 63566 0 0 13600 36

🟢 2024-08-15 12:15:31 UTC Build successful.
🟢 2024-08-15 12:16:06 UTC ydbd size 8.1 GiB changed* by +624 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c26bd91 merge: fa38954 diff diff %
ydbd size 8 731 669 432 Bytes 8 731 670 056 Bytes +624 Bytes +0.000%
ydbd stripped size 475 248 904 Bytes 475 248 904 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk merged commit 8dc96f7 into main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants