Fix OLAP stats #766
Merged
Fix OLAP stats #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 28, 2023 08:37
…lling stats for non-standalone table.
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 75965d4.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 75965d4.
|
|
Im going to add some utests (for many tables in table store). |
|
There is a problem related with a large count tables in tablesstore. Some tables doesn't init by stats. |
nsofya
reviewed
Dec 30, 2023
k-morozov
force-pushed
the
fix/olap-stats
branch
from
c3ed46c to
b0fd210
Compare
ivanmorozov333
approved these changes
Jan 3, 2024
| @@ -387,7 +393,7 @@ void TPathDescriber::DescribeOlapStore(TPathId pathId, TPathElement::TPtr pathEl | |||
| } | |||
|
|
|||
| void TPathDescriber::DescribeColumnTable(TPathId pathId, TPathElement::TPtr pathEl) { | |||
| const auto tableInfo = Self->ColumnTables.GetVerified(pathId); | |||
| const auto tableInfo = Self->ColumnTables.GetVerified(pathId); | |||
There was a problem hiding this comment.
аккуратнее. форматирование подключи...
|
I don't understand, why this pr, which touches core mechanics of stats collection in schemeshard for all table types and not only for olap tables: 1) named highly inaccurate "fix olap", and 2) had been merged without approve from me while I explicitly registered my interest in reviewing it. |
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.