Skip to content

dq: add cbo cost functions #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Aug 9, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

half-borrowed from ydb/core/kqp/opt/logical/kqp_opt_cbo.*;
with PRAGMA dq.HashJoinMode="map" or "off" chooses map join (except for FULL or INCLUSION), otherwise chooses grace join

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 12:05:12 UTC Pre-commit check for 218a1ab has started.
2024-08-09 12:08:35 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-09 14:05:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10025 9970 0 7 31 17

🟢 2024-08-09 14:06:20 UTC Build successful.
🟢 2024-08-09 14:06:48 UTC ydbd size 5.4 GiB changed* by +10.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 48718ab merge: 218a1ab diff diff %
ydbd size 5 843 569 184 Bytes 5 843 580 000 Bytes +10.6 KiB +0.000%
ydbd stripped size 1 468 062 000 Bytes 1 468 065 104 Bytes +3.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 12:06:26 UTC Pre-commit check for 218a1ab has started.
2024-08-09 12:09:08 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 14:55:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71601 57984 0 7 13598 12

2024-08-09 15:04:45 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 15:13:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 8 0 3 0 9

2024-08-09 15:13:41 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-09 15:21:39 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13 (only retried tests) 2 0 3 0 8

🟢 2024-08-09 15:21:46 UTC Build successful.
🟢 2024-08-09 15:22:21 UTC ydbd size 8.1 GiB changed* by +11.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 48718ab merge: 218a1ab diff diff %
ydbd size 8 688 414 328 Bytes 8 688 426 304 Bytes +11.7 KiB +0.000%
ydbd stripped size 472 744 808 Bytes 472 745 960 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 12:06:40 UTC Pre-commit check for 218a1ab has started.
2024-08-09 12:09:26 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 12:15:44 UTC Build successful.

resetius
resetius previously approved these changes Aug 9, 2024
@yumkam yumkam changed the title [WIP] dq: add cbo cost functions dq: add cbo cost functions Aug 9, 2024
@yumkam yumkam marked this pull request as ready for review August 9, 2024 14:13
@yumkam yumkam requested a review from a team as a code owner August 9, 2024 14:13
Copy link

github-actions bot commented Aug 11, 2024

2024-08-11 18:19:28 UTC Pre-commit check for 6b3af7e has started.
2024-08-11 18:22:16 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-11 18:37:03 UTC Build failed. see the logs.

Copy link

github-actions bot commented Aug 11, 2024

2024-08-11 18:19:32 UTC Pre-commit check for 6b3af7e has started.
2024-08-11 18:22:16 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-11 18:28:10 UTC Build successful.

Copy link

github-actions bot commented Aug 11, 2024

2024-08-11 18:19:37 UTC Pre-commit check for 6b3af7e has started.
2024-08-11 18:22:20 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-11 20:24:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10071 10018 0 6 33 14

🟢 2024-08-11 20:26:02 UTC Build successful.
🟢 2024-08-11 20:26:28 UTC ydbd size 5.4 GiB changed* by +10.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f93ea93 merge: 6b3af7e diff diff %
ydbd size 5 844 194 768 Bytes 5 844 205 504 Bytes +10.5 KiB +0.000%
ydbd stripped size 1 468 169 552 Bytes 1 468 172 592 Bytes +3.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam force-pushed the correctly-add-dq-cbo branch from ace9925 to c353d95 Compare August 12, 2024 08:49
Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 08:51:42 UTC Pre-commit check for 4db6f9b has started.
2024-08-12 08:54:29 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-12 11:08:39 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10068 9999 0 19 38 12

🟢 2024-08-12 11:09:52 UTC Build successful.
🟢 2024-08-12 11:10:21 UTC ydbd size 5.4 GiB changed* by +71.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: eda17f9 merge: 4db6f9b diff diff %
ydbd size 5 846 813 240 Bytes 5 846 886 064 Bytes +71.1 KiB +0.001%
ydbd stripped size 1 468 585 232 Bytes 1 468 608 240 Bytes +22.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 08:52:59 UTC Pre-commit check for 4db6f9b has started.
2024-08-12 08:55:42 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 09:01:56 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 08:53:22 UTC Pre-commit check for 4db6f9b has started.
2024-08-12 08:56:10 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-12 09:09:43 UTC Build failed. see the logs.

@yumkam yumkam force-pushed the correctly-add-dq-cbo branch from c353d95 to 561ce8d Compare August 12, 2024 11:55
Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 11:58:36 UTC Pre-commit check for a4008ec has started.
2024-08-12 12:02:02 UTC Check linux-x86_64-release-asan is running...
2024-08-12 14:09:51 UTC Check cancelled

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 11:58:37 UTC Pre-commit check for a4008ec has started.
2024-08-12 12:01:36 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 12:08:18 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 11:59:12 UTC Pre-commit check for a4008ec has started.
2024-08-12 12:02:00 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-12 12:16:09 UTC Build failed. see the logs.

@yumkam yumkam force-pushed the correctly-add-dq-cbo branch from 561ce8d to 48b8440 Compare August 12, 2024 14:09
Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 14:12:58 UTC Pre-commit check for a92db2a has started.
2024-08-12 14:15:53 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 14:22:51 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 14:14:19 UTC Pre-commit check for a92db2a has started.
2024-08-12 14:17:04 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-12 16:53:46 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10073 10015 0 9 33 16

🟢 2024-08-12 16:54:58 UTC Build successful.
🟢 2024-08-12 16:55:28 UTC ydbd size 5.4 GiB changed* by +22.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 976e2c7 merge: a92db2a diff diff %
ydbd size 5 847 171 512 Bytes 5 847 194 600 Bytes +22.5 KiB +0.000%
ydbd stripped size 1 468 657 904 Bytes 1 468 673 296 Bytes +15.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 14:15:44 UTC Pre-commit check for a92db2a has started.
2024-08-12 14:18:32 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-12 14:33:16 UTC Build failed. see the logs.

@yumkam yumkam force-pushed the correctly-add-dq-cbo branch from 48b8440 to bae317f Compare August 13, 2024 16:38
Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 17:17:57 UTC Pre-commit check for 8c9fdb3 has started.
2024-08-13 17:21:48 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-13 17:27:52 UTC Build successful.

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 17:19:12 UTC Pre-commit check for 8c9fdb3 has started.
2024-08-13 17:22:59 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-13 18:48:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71664 58043 0 6 13596 19

🟢 2024-08-13 18:58:19 UTC ydbd size 8.1 GiB changed* by +11.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 555ebf3 merge: 8c9fdb3 diff diff %
ydbd size 8 700 817 976 Bytes 8 700 829 952 Bytes +11.7 KiB +0.000%
ydbd stripped size 473 108 424 Bytes 473 109 576 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 17:43:49 UTC Pre-commit check for 8c9fdb3 has started.
2024-08-13 17:47:23 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-13 19:44:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10088 10033 0 3 34 18

🟢 2024-08-13 19:45:36 UTC Build successful.
🟢 2024-08-13 19:46:01 UTC ydbd size 5.4 GiB changed* by +10.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 555ebf3 merge: 8c9fdb3 diff diff %
ydbd size 5 851 697 544 Bytes 5 851 708 336 Bytes +10.5 KiB +0.000%
ydbd stripped size 1 469 408 176 Bytes 1 469 411 280 Bytes +3.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam force-pushed the correctly-add-dq-cbo branch from bae317f to 2b102f8 Compare August 14, 2024 10:53
Copy link

github-actions bot commented Aug 14, 2024

2024-08-14 10:58:13 UTC Pre-commit check for da1e38c has started.
2024-08-14 11:01:07 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-14 11:07:57 UTC Build successful.

Copy link

github-actions bot commented Aug 14, 2024

2024-08-14 10:58:22 UTC Pre-commit check for da1e38c has started.
2024-08-14 11:04:37 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-14 12:38:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71713 58083 0 1 13596 33

2024-08-14 12:47:56 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-14 12:55:26 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 18 0 0 1 29

🟢 2024-08-14 12:55:34 UTC Build successful.
🟢 2024-08-14 12:56:11 UTC ydbd size 8.1 GiB changed* by +11.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9ec6f05 merge: da1e38c diff diff %
ydbd size 8 725 240 488 Bytes 8 725 252 376 Bytes +11.6 KiB +0.000%
ydbd stripped size 474 249 384 Bytes 474 250 536 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 14, 2024

2024-08-14 10:58:25 UTC Pre-commit check for da1e38c has started.
2024-08-14 11:01:14 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 13:56:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10112 10023 0 16 39 34

🟢 2024-08-14 13:57:35 UTC Build successful.
🟢 2024-08-14 13:58:07 UTC ydbd size 5.5 GiB changed* by +14.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9ec6f05 merge: da1e38c diff diff %
ydbd size 5 869 832 728 Bytes 5 869 847 608 Bytes +14.5 KiB +0.000%
ydbd stripped size 1 473 498 096 Bytes 1 473 505 296 Bytes +7.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam requested a review from resetius August 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants