Skip to content

[Http] Reply with structured issues when client accepts json data #7576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

When client says that it expects data in json format, send issues in json format instead of html.
It improves issues display in YDB UI

Changelog category

  • Improvement

Additional information

...

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner August 8, 2024 14:21
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 14:23:39 UTC Pre-commit check for 0d0feee has started.
2024-08-08 14:26:35 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 14:56:22 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 14:25:21 UTC Pre-commit check for 0d0feee has started.
2024-08-08 14:29:17 UTC Check linux-x86_64-release-asan is running...
2024-08-08 15:30:51 UTC Check cancelled

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 14:26:08 UTC Pre-commit check for 0d0feee has started.
2024-08-08 14:29:09 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-08 15:31:09 UTC Check cancelled

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 15:33:25 UTC Pre-commit check for 0433aa0 has started.
2024-08-08 15:37:19 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 17:56:19 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10989 10921 0 21 30 17

🟢 2024-08-08 17:57:34 UTC Build successful.
🟢 2024-08-08 17:58:05 UTC ydbd size 5.4 GiB changed* by +61.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78d1439 merge: 0433aa0 diff diff %
ydbd size 5 839 792 744 Bytes 5 839 855 192 Bytes +61.0 KiB +0.001%
ydbd stripped size 1 467 330 960 Bytes 1 467 341 104 Bytes +9.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 15:39:27 UTC Pre-commit check for 0433aa0 has started.
2024-08-08 15:43:19 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 15:50:27 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 15:40:17 UTC Pre-commit check for 0433aa0 has started.
2024-08-08 15:43:10 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 17:36:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39743 34416 0 7 5308 12

2024-08-08 17:40:48 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 17:49:36 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 9 0 0 1 10

🟢 2024-08-08 17:49:43 UTC Build successful.
🟢 2024-08-08 17:50:17 UTC ydbd size 8.1 GiB changed* by +68.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78d1439 merge: 0433aa0 diff diff %
ydbd size 8 682 534 824 Bytes 8 682 604 680 Bytes +68.2 KiB +0.001%
ydbd stripped size 472 557 672 Bytes 472 561 000 Bytes +3.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit eda17f9 into ydb-platform:main Aug 12, 2024
10 of 12 checks passed
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Aug 13, 2024
@UgnineSirdis UgnineSirdis deleted the http-json-issues branch October 7, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants