Skip to content

Add ICB-configurable parameters for accelerates #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 13, 2024
Merged

Add ICB-configurable parameters for accelerates #7534

merged 8 commits into from
Aug 13, 2024

Conversation

@serbel324
Copy link
Collaborator

@serbel324 serbel324 commented Aug 7, 2024 •
edited
Loading

  • Add new ICB configurable control
  • Add UT for accelerate parameters, fix bugs

Changelog entry

...

Changelog category

  • New feature
  • Improvement

Additional information

...

@serbel324 serbel324 force-pushed the bs/vdisk/accelerate-threshold branch from 3cde06c to 46f98a8 Compare August 7, 2024 12:14
@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 12:16:15 UTC Pre-commit check for bd18f70 has started.
⚪ 2024-08-07 12:20:20 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-07 12:20:53 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 12:17:58 UTC Pre-commit check for bd18f70 has started.
⚫ 2024-08-07 12:20:55 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 12:18:19 UTC Pre-commit check for bd18f70 has started.
⚫ 2024-08-07 12:21:53 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 12:23:23 UTC Pre-commit check for 157fe88 has started.
⚪ 2024-08-07 12:26:38 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-07 12:48:25 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 12:23:28 UTC Pre-commit check for 157fe88 has started.
⚪ 2024-08-07 12:26:39 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-07 12:43:00 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 12:25:29 UTC Pre-commit check for 157fe88 has started.
⚪ 2024-08-07 12:28:44 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-07 12:46:35 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:09:13 UTC Pre-commit check for 60b8704 has started.
⚪ 2024-08-07 15:13:30 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-07 15:22:41 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:10:18 UTC Pre-commit check for 60b8704 has started.
⚪ 2024-08-07 15:13:26 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-07 15:27:36 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:10:38 UTC Pre-commit check for 60b8704 has started.
⚪ 2024-08-07 15:13:48 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-07 15:28:37 UTC Build failed. see the logs.

kruall
kruall reviewed Aug 8, 2024
View reviewed changes
ydb/core/blobstorage/ut_blobstorage/lib/env.h Outdated
@@ -1,5 +1,7 @@
#pragma once

#define USE_VIRTUAL_TIME_IN_BSQUEUE
Copy link
Collaborator

@kruall kruall Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется старое осталось которое не используется

ydb/core/blobstorage/dsproxy/dsproxy_blackboard.cpp Outdated
ui32 diskIdxInSubring, NKikimrBlobStorage::EVDiskQueueId queueId) const {
Y_UNUSED(info);
return groupQueues.GetPredictedDelayNsByOrderNumber(Disks[diskIdxInSubring].OrderNumber, queueId);
auto res = groupQueues.GetPredictedDelayNsByOrderNumber(Disks[diskIdxInSubring].OrderNumber, queueId);
Copy link
Collaborator

@kruall kruall Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Артефакт дебага, надо бы вернуть обратно

@github-actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 14:03:09 UTC Pre-commit check for 1f5a263 has started.
⚪ 2024-08-08 14:07:07 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 14:19:38 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 14:04:18 UTC Pre-commit check for 1f5a263 has started.
⚪ 2024-08-08 14:07:34 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-08 14:27:49 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 14:04:43 UTC Pre-commit check for 1f5a263 has started.
⚪ 2024-08-08 14:09:03 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-08 14:33:20 UTC Build failed. see the logs.

@serbel324 serbel324 force-pushed the bs/vdisk/accelerate-threshold branch from 5b6c535 to b57864c Compare August 12, 2024 10:37
@github-actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 10:38:37 UTC Pre-commit check for 0c7a12a has started.
⚪ 2024-08-12 10:42:30 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-12 11:05:26 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 10:39:00 UTC Pre-commit check for 0c7a12a has started.
⚪ 2024-08-12 10:42:03 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-12 11:01:37 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 10:39:54 UTC Pre-commit check for 0c7a12a has started.
⚪ 2024-08-12 10:43:04 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-12 10:55:12 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 13:04:02 UTC Pre-commit check for f0b7517 has started.
⚪ 2024-08-12 13:07:09 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 13:39:53 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 13:05:36 UTC Pre-commit check for f0b7517 has started.
⚪ 2024-08-12 13:08:29 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-12 15:24:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39926 34592 0 6 5311 17

⚪ 2024-08-12 15:29:49 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-12 15:40:17 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28 (only retried tests) 19 0 0 0 9

🟢 2024-08-12 15:40:24 UTC Build successful.
🟡 2024-08-12 15:41:06 UTC ydbd size 8.1 GiB changed* by +298.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 833d136 merge: f0b7517 diff diff %
ydbd size 8 694 263 112 Bytes 8 694 568 392 Bytes +298.1 KiB +0.004%
ydbd stripped size 472 902 856 Bytes 472 914 696 Bytes +11.6 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 13:05:37 UTC Pre-commit check for f0b7517 has started.
⚪ 2024-08-12 13:08:36 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-12 15:59:11 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11102 11063 0 3 22 14

🟢 2024-08-12 16:00:29 UTC Build successful.
🟡 2024-08-12 16:00:56 UTC ydbd size 5.4 GiB changed* by +224.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 833d136 merge: f0b7517 diff diff %
ydbd size 5 846 982 176 Bytes 5 847 212 344 Bytes +224.8 KiB +0.004%
ydbd stripped size 1 468 622 704 Bytes 1 468 681 808 Bytes +57.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

⚪ 2024-08-13 13:34:40 UTC Pre-commit check for eee3af7 has started.
⚪ 2024-08-13 13:37:48 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-13 17:14:29 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11120 11071 0 12 23 14

🟢 2024-08-13 17:15:57 UTC Build successful.
🟡 2024-08-13 17:16:30 UTC ydbd size 5.4 GiB changed* by +228.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e0e98b1 merge: eee3af7 diff diff %
ydbd size 5 851 479 824 Bytes 5 851 713 880 Bytes +228.6 KiB +0.004%
ydbd stripped size 1 469 374 288 Bytes 1 469 437 360 Bytes +61.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

⚪ 2024-08-13 13:34:41 UTC Pre-commit check for eee3af7 has started.
⚪ 2024-08-13 13:38:25 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-13 14:14:41 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

⚪ 2024-08-13 13:35:03 UTC Pre-commit check for eee3af7 has started.
⚪ 2024-08-13 13:38:24 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-13 15:42:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39951 34624 0 2 5308 17

⚪ 2024-08-13 15:47:44 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-13 15:56:51 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19 (only retried tests) 10 0 0 0 9

🟢 2024-08-13 15:56:57 UTC Build successful.
🟡 2024-08-13 15:57:30 UTC ydbd size 8.1 GiB changed* by +302.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e0e98b1 merge: eee3af7 diff diff %
ydbd size 8 700 604 288 Bytes 8 700 913 496 Bytes +302.0 KiB +0.004%
ydbd stripped size 473 093 896 Bytes 473 109 768 Bytes +15.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@serbel324 serbel324 merged commit 5bf9299 into ydb-platform:main Aug 13, 2024
This was referenced Aug 14, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@serbel324 serbel324 linked an issue Sep 25, 2024 that may be closed by this pull request
Fix Acceleration behaviour on disabled tests #7840
Closed
serbel324 added a commit to serbel324/ydb that referenced this pull request Nov 19, 2024
@serbel324
Add ICB-configurable parameters for accelerates (ydb-platform#7534)
f57bdce
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kruall kruall kruall approved these changes

Assignees

No one assigned

Labels

new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Acceleration behaviour on disabled tests

2 participants

@serbel324 @kruall