Skip to content

YQ Connector: YQ-2715: add ydb data source #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2024
Merged

YQ Connector: YQ-2715: add ydb data source #753

merged 1 commit into from
Jan 25, 2024

Conversation

@Woodey777
Copy link
Contributor

@Woodey777 Woodey777 commented Dec 27, 2023 •
edited
Loading

Changelog entry

Added YDB as new data source in generic provider
Added unit tests for this feature

Changelog category

  • New feature

Woodey777
Woodey777 commented Dec 27, 2023
View reviewed changes
@Woodey777 Woodey777 changed the title YQ-2715: add ydb data source YQ Connector: YQ-2715: add ydb data source Dec 27, 2023
vitalyisaev2
vitalyisaev2 suggested changes Dec 27, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 27, 2023 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2c06274.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59896 50666 0 7 9206 17

🔴 linux-x86_64-release-asan: some tests FAILED for commit 2c06274.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15876 15745 0 25 96 10

@dorooleg
Copy link
Collaborator

dorooleg commented Dec 27, 2023 •
edited
Loading

Еще не понятно почему при не валидных настройках зависает connector. Он должен отрепортить ошибку хотя бы. Про это нужно не забыть и в отдельном ревью поправить

@Woodey777
Copy link
Contributor Author

Woodey777 commented Dec 27, 2023

Еще не понятно почему при не валидных настройках зависает connector. Он должен отрепортить ошибку хотя бы. Про это нужно не забыть и в отдельном ревью поправить

да, это похоже из-за того что на соединении не стоит таймаут никакой
надо исправить

@dorooleg
Copy link
Collaborator

dorooleg commented Dec 28, 2023 •
edited
Loading

Еще нужно добавить хотя бы два теста по аналогии с:

  1. https://a.yandex-team.ru/arcadia/ydb/core/kqp/ut/federated_query/generic/kqp_generic_plan_ut.cpp?rev=13169068#L22
  2. https://a.yandex-team.ru/arcadia/ydb/core/kqp/ut/federated_query/generic_ut/kqp_generic_provider_ut.cpp?rev=r13161422#L45

@Woodey777 Woodey777 force-pushed the YQ-2715_read_with_dq_kqp branch from 1fd5e76 to 3b69eb3 Compare December 28, 2023 09:50
@Woodey777 Woodey777 force-pushed the YQ-2715_read_with_dq_kqp branch 2 times, most recently from 0b09b32 to 0cf8385 Compare January 10, 2024 12:38
vitalyisaev2
vitalyisaev2 suggested changes Jan 10, 2024
View reviewed changes
@Woodey777 Woodey777 force-pushed the YQ-2715_read_with_dq_kqp branch 2 times, most recently from 82c11c8 to c695630 Compare January 11, 2024 09:10
@Woodey777 Woodey777 force-pushed the YQ-2715_read_with_dq_kqp branch 2 times, most recently from 75fd775 to 2c06274 Compare January 12, 2024 13:00
@Woodey777 Woodey777 force-pushed the YQ-2715_read_with_dq_kqp branch from 2c06274 to dd0089d Compare January 24, 2024 11:33
@Woodey777 Woodey777 requested a review from a team as a code owner January 24, 2024 11:33
@github-actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

⚪ 2024-01-24 15:33:08 UTC Pre-commit check for 3adeddc has started.
⚪ 2024-01-24 15:33:09 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-24 15:35:01 UTC Build successful.
⚪ 2024-01-24 15:35:10 UTC Tests are running...
🔴 2024-01-24 16:56:07 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59996 50731 0 3 9235 27

@github-actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

⚪ 2024-01-24 15:34:35 UTC Pre-commit check for 3adeddc has started.
⚪ 2024-01-24 15:34:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-24 15:36:32 UTC Build successful.
⚪ 2024-01-24 15:36:41 UTC Tests are running...
🔴 2024-01-24 17:11:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15937 15822 0 24 69 22

@Woodey777 Woodey777 force-pushed the YQ-2715_read_with_dq_kqp branch from b109149 to a03b818 Compare January 24, 2024 15:23
@vitalyisaev2 vitalyisaev2 merged commit 7eb75fa into ydb-platform:main Jan 25, 2024
@Woodey777 Woodey777 deleted the YQ-2715_read_with_dq_kqp branch January 25, 2024 11:15
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
vitalyisaev2 pushed a commit to vitalyisaev2/ydb that referenced this pull request Mar 18, 2024
@Woodey777 @vitalyisaev2
YQ-2715 add ydb data source (ydb-platform#753)
5280a23
@vitalyisaev2 vitalyisaev2 mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitstn vitstn vitstn approved these changes

@dorooleg dorooleg dorooleg approved these changes

+1 more reviewer

@vitalyisaev2 vitalyisaev2 vitalyisaev2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Woodey777 @dorooleg @vitalyisaev2 @vitstn