support memory pools configurations & tune spilling settings #7510
Conversation
gridnevvvit
force-pushed
the
memory-pools
branch
from
21318b9 to
f7bb36a
Compare
gridnevvvit
force-pushed
the
memory-pools
branch
from
f7bb36a to
3e8f730
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
gridnevvvit
force-pushed
the
memory-pools
branch
from
3e8f730 to
d1ba9a4
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| } | ||
|
|
||
| request.SetSchedulerGroup(UserRequestContext->PoolId); | ||
| request.SetMemoryPoolPercent(UserRequestContext->PoolConfig->QueryMemoryLimitPercentPerNode); |
There was a problem hiding this comment.
В этом месте может быть UserRequestContext->PoolConfig = std::nullopt, лучше добавить на это проверку
| TxInfo = MakeIntrusive<NRm::TTxState>( | ||
| TxId, TInstant::Now(), ResourceManager_->GetCounters()); | ||
| TxId, TInstant::Now(), ResourceManager_->GetCounters(), | ||
| UserRequestContext->PoolId, UserRequestContext->PoolConfig->QueryMemoryLimitPercentPerNode); |
There was a problem hiding this comment.
Тут тоже стоит проверить UserRequestContext->PoolConfig = std::nullopt
| } | ||
|
|
||
| void SetNewLimit(ui64 baseLimit, double memoryPoolPercent, double overPercent) { | ||
| if (abs(memoryPoolPercent - MemoryPoolPercent) < MYEPS && baseLimit != BaseLimit) |
There was a problem hiding this comment.
Тут точно должно быть baseLimit != BaseLimit? Судя по коду конфиг может поменяться и тогда делается SetNewLimit для TotalMemoryResource (тут), в этом случае лимит не поменяется
3 participants
Changelog entry
support memory pools configurations & improve spilling settings
Changelog category
Additional information
...