Skip to content

Allow use GraceJoinCore for map (Broadcast-et) joins #7447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2024
Merged

Allow use GraceJoinCore for map (Broadcast-et) joins #7447

merged 4 commits into from
Aug 7, 2024

Conversation

@Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Aug 5, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

@Hor911 Hor911 requested review from a team as code owners August 5, 2024 06:50
@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 06:51:27 UTC Pre-commit check for a990d04 has started.
⚪ 2024-08-05 06:54:28 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-05 07:11:29 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 06:53:13 UTC Pre-commit check for a990d04 has started.
⚪ 2024-08-05 06:56:09 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-05 08:56:02 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11556 11505 0 6 31 14

🟢 2024-08-05 08:57:19 UTC Build successful.
🟡 2024-08-05 08:57:47 UTC ydbd size 5.4 GiB changed* by +1017.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f64d670 merge: a990d04 diff diff %
ydbd size 5 825 703 504 Bytes 5 826 745 816 Bytes +1017.9 KiB +0.018%
ydbd stripped size 1 463 157 232 Bytes 1 463 435 344 Bytes +271.6 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 06:54:02 UTC Pre-commit check for a990d04 has started.
⚪ 2024-08-05 06:57:02 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-05 09:17:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73034 59426 0 5 13590 13

⚪ 2024-08-05 09:26:17 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-05 09:33:25 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21 (only retried tests) 13 0 0 0 8

🟢 2024-08-05 09:40:04 UTC Build successful.
🟡 2024-08-05 09:40:44 UTC ydbd size 8.1 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f64d670 merge: a990d04 diff diff %
ydbd size 8 665 991 720 Bytes 8 667 223 264 Bytes +1.2 MiB +0.014%
ydbd stripped size 471 452 840 Bytes 471 512 680 Bytes +58.4 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 17:13:37 UTC Pre-commit check for b1d8679 has started.
⚪ 2024-08-05 17:16:44 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-05 17:29:44 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 17:13:44 UTC Pre-commit check for b1d8679 has started.
⚪ 2024-08-05 17:16:45 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-05 18:31:32 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 17:13:45 UTC Pre-commit check for b1d8679 has started.
⚪ 2024-08-05 17:16:43 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-05 18:31:29 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 18:33:28 UTC Pre-commit check for 89e409c has started.
⚪ 2024-08-05 18:36:27 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-05 20:50:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11555 11493 0 11 34 17

🟢 2024-08-05 20:51:39 UTC Build successful.
🟡 2024-08-05 20:52:10 UTC ydbd size 5.4 GiB changed* by +1021.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ac33022 merge: 89e409c diff diff %
ydbd size 5 830 490 160 Bytes 5 831 536 392 Bytes +1021.7 KiB +0.018%
ydbd stripped size 1 464 451 760 Bytes 1 464 729 808 Bytes +271.5 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 18:34:19 UTC Pre-commit check for 89e409c has started.
⚪ 2024-08-05 18:37:34 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-05 18:48:14 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 18:35:09 UTC Pre-commit check for 89e409c has started.
⚪ 2024-08-05 18:38:08 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-05 20:52:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73037 59433 0 2 13590 12

⚪ 2024-08-05 21:02:15 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-05 21:13:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19 (only retried tests) 4 0 2 4 9

⚪ 2024-08-05 21:20:30 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-05 21:28:20 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 7 0 0 0 8

🟢 2024-08-05 21:34:55 UTC Build successful.
🟡 2024-08-05 21:35:26 UTC ydbd size 8.1 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ac33022 merge: 89e409c diff diff %
ydbd size 8 671 678 040 Bytes 8 672 905 400 Bytes +1.2 MiB +0.014%
ydbd stripped size 471 804 168 Bytes 471 863 816 Bytes +58.2 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 requested review from pavelvelikhov and vitstn August 6, 2024 12:23
@Hor911 Hor911 merged commit 1593a2d into ydb-platform:main Aug 7, 2024
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 8, 2024
Merged
This was referenced Aug 8, 2024
Merged
Merged
Hor911 added a commit to Hor911/ydb that referenced this pull request Nov 12, 2024
@Hor911
Allow use GraceJoinCore for map (Broadcast-et) joins (ydb-platform#7447)
f2ec3f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spuchin spuchin spuchin approved these changes

@pavelvelikhov pavelvelikhov Awaiting requested review from pavelvelikhov

@vitstn vitstn Awaiting requested review from vitstn

+1 more reviewer

@resetius resetius resetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hor911 @resetius @spuchin