Skip to content

Conversation

lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented Aug 2, 2024

Changelog entry

Removed abort. Added error event instead.
...

Changelog category

  • Improvement

Additional information

...

@lll-phill-lll lll-phill-lll marked this pull request as ready for review August 5, 2024 19:24
@lll-phill-lll lll-phill-lll requested review from a team as code owners August 5, 2024 19:24
@lll-phill-lll lll-phill-lll changed the title added error event for acync compute actor Handle spilling errors correctly Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Aug 6, 2024
@lll-phill-lll lll-phill-lll force-pushed the exception-instead-of-abort-on-spilling-errors branch from 6c2c8da to a3fe499 Compare August 6, 2024 15:21

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 12:47:52 UTC Pre-commit check for 31a0c90 has started.
2024-08-09 12:53:04 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-09 13:50:13 UTC Check cancelled

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 12:48:59 UTC Pre-commit check for 31a0c90 has started.
2024-08-09 12:52:29 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 13:36:12 UTC Build successful.

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 12:49:19 UTC Pre-commit check for 31a0c90 has started.
2024-08-09 12:52:23 UTC Check linux-x86_64-release-asan is running...
2024-08-09 13:50:06 UTC Check cancelled

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 13:51:38 UTC Pre-commit check for 2fae06b has started.
2024-08-09 13:54:59 UTC Check linux-x86_64-release-clang14 is running...
2024-08-09 13:55:41 UTC Check cancelled

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 13:52:23 UTC Pre-commit check for 2fae06b has started.
2024-08-09 13:55:40 UTC Check cancelled

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 13:53:48 UTC Pre-commit check for 2fae06b has started.
2024-08-09 13:56:34 UTC Check cancelled

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 13:59:16 UTC Pre-commit check for 966d66f has started.
2024-08-09 14:02:02 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 16:31:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73140 59519 0 3 13599 19

2024-08-09 16:41:56 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 16:53:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 7 0 2 4 9

2024-08-09 16:53:29 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-09 17:02:01 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 7 0 0 0 9

🟢 2024-08-09 17:02:08 UTC Build successful.
🟡 2024-08-09 17:02:43 UTC ydbd size 8.1 GiB changed* by +339.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 633ff57 merge: 966d66f diff diff %
ydbd size 8 688 682 368 Bytes 8 689 029 736 Bytes +339.2 KiB +0.004%
ydbd stripped size 472 752 392 Bytes 472 762 824 Bytes +10.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 13:59:52 UTC Pre-commit check for 966d66f has started.
2024-08-09 14:02:49 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 14:21:24 UTC Build successful.

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 13:59:53 UTC Pre-commit check for 966d66f has started.
2024-08-09 14:02:51 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-09 17:04:10 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11585 11537 0 3 31 14

🟢 2024-08-09 17:06:00 UTC Build successful.
🟡 2024-08-09 17:06:29 UTC ydbd size 5.4 GiB changed* by +130.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 633ff57 merge: 966d66f diff diff %
ydbd size 5 843 780 776 Bytes 5 843 914 776 Bytes +130.9 KiB +0.002%
ydbd stripped size 1 468 104 912 Bytes 1 468 133 552 Bytes +28.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll merged commit 49e62b4 into ydb-platform:main Aug 9, 2024
5 of 6 checks passed
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 9, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 10, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 11, 2024
lll-phill-lll added a commit that referenced this pull request Sep 12, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants