Skip to content

Conversation

@dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Aug 2, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@dorooleg dorooleg requested a review from a team as a code owner August 2, 2024 10:59
@github-actions github-actions bot added the bugfix label Aug 2, 2024
@github-actions
Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 11:01:32 UTC Pre-commit check for b0b6acb has started.
2024-08-02 11:04:22 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-02 11:09:25 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 11:03:17 UTC Pre-commit check for b0b6acb has started.
2024-08-02 11:06:06 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-02 13:11:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9498 9447 0 11 26 14

🟢 2024-08-02 13:12:30 UTC Build successful.
🟢 2024-08-02 13:13:00 UTC ydbd size 5.4 GiB changed* by +36.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0f64840 merge: b0b6acb diff diff %
ydbd size 5 824 757 456 Bytes 5 824 794 912 Bytes +36.6 KiB +0.001%
ydbd stripped size 1 463 013 456 Bytes 1 463 018 448 Bytes +4.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 11:03:50 UTC Pre-commit check for b0b6acb has started.
2024-08-02 11:06:39 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 12:40:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13659 12304 0 8 1335 12

2024-08-02 12:42:01 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 12:54:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 9 0 5 0 8

2024-08-02 12:55:17 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-02 13:07:38 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 1 0 5 0 8

🟢 2024-08-02 13:08:46 UTC Build successful.
🟢 2024-08-02 13:09:19 UTC ydbd size 8.1 GiB changed* by +20.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0f64840 merge: b0b6acb diff diff %
ydbd size 8 664 672 680 Bytes 8 664 693 616 Bytes +20.4 KiB +0.000%
ydbd stripped size 471 414 984 Bytes 471 416 392 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 7, 2024

2024-08-07 11:46:54 UTC Pre-commit check for 29b9e38 has started.
2024-08-07 11:50:56 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-07 11:56:20 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024

2024-08-07 11:46:59 UTC Pre-commit check for 29b9e38 has started.
2024-08-07 11:49:45 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-07 13:51:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13667 12314 0 3 1339 11

2024-08-07 13:53:15 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-07 14:04:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 6 0 2 4 8

2024-08-07 14:05:30 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-07 14:12:51 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 6 0 0 0 8

🟢 2024-08-07 14:13:59 UTC Build successful.
🟢 2024-08-07 14:14:43 UTC ydbd size 8.1 GiB changed* by +25.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2b5467c merge: 29b9e38 diff diff %
ydbd size 8 672 546 288 Bytes 8 672 572 216 Bytes +25.3 KiB +0.000%
ydbd stripped size 471 982 856 Bytes 471 984 584 Bytes +1.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 7, 2024

2024-08-07 11:47:21 UTC Pre-commit check for 29b9e38 has started.
2024-08-07 11:50:18 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-07 13:56:45 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9506 9447 0 8 32 19

🟢 2024-08-07 13:57:52 UTC Build successful.
🟢 2024-08-07 13:58:25 UTC ydbd size 5.4 GiB changed* by +46.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2b5467c merge: 29b9e38 diff diff %
ydbd size 5 831 510 096 Bytes 5 831 557 800 Bytes +46.6 KiB +0.001%
ydbd stripped size 1 464 849 872 Bytes 1 464 860 816 Bytes +10.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 05:53:36 UTC Pre-commit check for 52d94ae has started.

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 05:53:54 UTC Pre-commit check for 52d94ae has started.

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 05:54:08 UTC Pre-commit check for 52d94ae has started.

"sa_secret_name"_a = EncloseAndEscapeString(signer ? TStringBuilder{} << "f1_" << folderId << name : TString{}, '"'),
"login"_a = EncloseAndEscapeString(GetLogin(setting).GetOrElse({}), '"'),
"password_secret_name"_a = EncloseAndEscapeString("k2" + name, '"'));
"password_secret_name"_a = EncloseAndEscapeString(TStringBuilder{} << "f2_" << folderId << name, '"'));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю после folderId еще вставить подчеркивание

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 07:54:51 UTC Pre-commit check for b301461 has started.
2024-08-08 07:58:12 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 08:03:03 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 07:54:55 UTC Pre-commit check for b301461 has started.
2024-08-08 07:57:57 UTC Check linux-x86_64-release-asan is running...
2024-08-08 08:17:22 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 07:55:20 UTC Pre-commit check for b301461 has started.
2024-08-08 07:58:42 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-08 08:17:24 UTC Check cancelled

namespace {

TString MakeSecretKeyName(const TString& prefix, const TString& folderId, const TString& name) {
return TStringBuilder{} << prefix << "_" << folderId << "_" << name << Endl;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endl тут не нужен

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 08:19:23 UTC Pre-commit check for 6ab04a0 has started.
2024-08-08 08:22:16 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 10:22:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9526 9483 0 2 24 17

🟢 2024-08-08 10:23:13 UTC Build successful.
🟢 2024-08-08 10:23:41 UTC ydbd size 5.4 GiB changed* by +72.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ff0fd33 merge: 6ab04a0 diff diff %
ydbd size 5 834 418 672 Bytes 5 834 493 200 Bytes +72.8 KiB +0.001%
ydbd stripped size 1 465 530 608 Bytes 1 465 541 936 Bytes +11.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 08:20:40 UTC Pre-commit check for 6ab04a0 has started.
2024-08-08 08:23:34 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 10:02:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13693 12341 0 5 1336 11

2024-08-08 10:04:01 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 10:12:41 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 10 0 0 1 9

🟢 2024-08-08 10:13:47 UTC Build successful.
🟢 2024-08-08 10:14:21 UTC ydbd size 8.1 GiB changed* by +31.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ff0fd33 merge: 6ab04a0 diff diff %
ydbd size 8 675 902 120 Bytes 8 675 933 952 Bytes +31.1 KiB +0.000%
ydbd stripped size 472 174 152 Bytes 472 176 456 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 08:20:41 UTC Pre-commit check for 6ab04a0 has started.
2024-08-08 08:23:35 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 08:28:44 UTC Build successful.

@dorooleg dorooleg merged commit f010ee3 into ydb-platform:main Aug 8, 2024
dorooleg added a commit to dorooleg/ydb that referenced this pull request Aug 8, 2024
dorooleg added a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants