Skip to content

Transitional flag FIX_UNUSED_PARAMETR_PLS=1 (devtools request) #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build/internal/ya.conf
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,5 @@ USE_ICONV = "static"
USE_IDN = "static"
APPLE_SDK_LOCAL = "yes"
CFLAGS = "-fno-omit-frame-pointer"
# TODO: uncomment after warnings fix
# FIX_UNUSED_PARAMETR_PLS = "1" # 31 jul 2024. Transitional flag for protobuf fix, DTCC-2275
2 changes: 1 addition & 1 deletion ydb/core/blobstorage/nodewarden/node_warden_pdisk.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ namespace NKikimr::NStorage {
Become(&TThis::StateFunc, TDuration::Seconds(10), new TEvents::TEvWakeup);
}

void Handle(TEvents::TEvUndelivered::TPtr ev) {
void Handle(TEvents::TEvUndelivered::TPtr /*ev*/) {
// send this event again, this may be a race with PDisk destruction
TActivationContext::Send(OriginalEv.release());
PassAway();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ namespace NKikimr::NPDisk {
Release(actorSystem);
}

void Release(TActorSystem *actorSystem) override {
void Release(TActorSystem * /*actorSystem*/) override {
delete this;
}
};
Expand Down Expand Up @@ -231,7 +231,7 @@ namespace NKikimr::NPDisk {

bool CanHandleResult() const override { return true; }

void Exec(TActorSystem *actorSystem) override {
void Exec(TActorSystem * /*actorSystem*/) override {
LOG_DEBUG_S(*PDisk->ActorSystem, NKikimrServices::BS_PDISK, "PDiskId# " << PDisk->PDiskId
<< " TCompletionWriteUnformattedMetadata::Exec"
<< " Result# " << Result
Expand Down
3 changes: 1 addition & 2 deletions ydb/core/config/tools/protobuf_plugin/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ class TMessageGenerator
return name;
}

TString ConstructFullFieldPath(const TDeque<const FieldDescriptor*>& fieldPath, const FieldDescriptor* field) const {

TString ConstructFullFieldPath(const TDeque<const FieldDescriptor*>& fieldPath, const FieldDescriptor* /*field*/) const {
TVector<TString> path;
path.push_back("");
for (size_t i = 1; i < fieldPath.size(); ++i) {
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/formats/arrow/accessor/composite/accessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class TCompositeChunkedArray: public NArrow::NAccessor::IChunkedArray {
return {};
}

virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 index) const override {
virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 /*index*/) const override {
AFL_VERIFY(false)("problem", "cannot use method");
return nullptr;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class TDeserializeChunkedArray: public NArrow::NAccessor::IChunkedArray {
return {};
}

virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 index) const override {
virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 /*index*/) const override {
AFL_VERIFY(false)("problem", "cannot use method");
return nullptr;
}
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/formats/arrow/accessor/plain/accessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class TTrivialArray: public IChunkedArray {
protected:
virtual std::optional<ui64> DoGetRawSize() const override;

virtual TLocalDataAddress DoGetLocalData(const std::optional<TCommonChunkAddress>& /*chunkCurrent*/, const ui64 position) const override {
virtual TLocalDataAddress DoGetLocalData(const std::optional<TCommonChunkAddress>& /*chunkCurrent*/, const ui64 /*position*/) const override {
return TLocalDataAddress(Array, 0, 0);
}
virtual std::shared_ptr<arrow::ChunkedArray> DoGetChunkedArray() const override {
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/formats/arrow/accessor/sparsed/accessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class TSparsedArray: public IChunkedArray {
return bytes;
}

TSparsedArray(std::vector<TSparsedArrayChunk>&& data, const std::shared_ptr<arrow::Scalar>& defaultValue,
TSparsedArray(std::vector<TSparsedArrayChunk>&& data, const std::shared_ptr<arrow::Scalar>& /*defaultValue*/,
const std::shared_ptr<arrow::DataType>& type, const ui32 recordsCount)
: TBase(recordsCount, EType::SparsedArray, type)
, Records(std::move(data)) {
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/formats/arrow/accessor/sparsed/constructor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ NKikimrArrowAccessorProto::TConstructor TConstructor::DoSerializeToProto() const
return result;
}

bool TConstructor::DoDeserializeFromProto(const NKikimrArrowAccessorProto::TConstructor& proto) {
bool TConstructor::DoDeserializeFromProto(const NKikimrArrowAccessorProto::TConstructor& /*proto*/) {
return true;
}

Expand Down
2 changes: 1 addition & 1 deletion ydb/core/formats/arrow/reader/position.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class TSortableScanData {
return PositionAddress[colIdx].GetAddress().GetLocalIndex(pos);
}

std::shared_ptr<TSortableScanData> BuildCopy(const ui64 position) const {
std::shared_ptr<TSortableScanData> BuildCopy(const ui64 /*position*/) const {
return std::make_shared<TSortableScanData>(*this);
}

Expand Down
2 changes: 1 addition & 1 deletion ydb/core/grpc_services/rpc_alter_table.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ class TAlterTableRPC : public TRpcSchemeRequestActor<TAlterTableRPC, TEvAlterTab
Send(schemeCache, ev);
}

void Navigate(const TTableId& pathId, const TActorContext& ctx) {
void Navigate(const TTableId& pathId, const TActorContext& /*ctx*/) {
DatabaseName = Request_->GetDatabaseName()
.GetOrElse(DatabaseFromDomain(AppData()));

Expand Down
2 changes: 1 addition & 1 deletion ydb/core/persqueue/read_balancer__balancing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1827,7 +1827,7 @@ void TBalancer::Handle(TEvPQ::TEvBalanceConsumer::TPtr& ev, const TActorContext&
}
}

void TBalancer::Handle(TEvPersQueue::TEvStatusResponse::TPtr& ev, const TActorContext& ctx) {
void TBalancer::Handle(TEvPersQueue::TEvStatusResponse::TPtr& ev, const TActorContext& /*ctx*/) {
const auto& record = ev->Get()->Record;
for (const auto& partResult : record.GetPartResult()) {
for (const auto& consumerResult : partResult.GetConsumerResult()) {
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/statistics/aggregator/tx_ack_timeout.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ struct TStatisticsAggregator::TTxAckTimeout : public TTxBase {

TTxType GetTxType() const override { return TXTYPE_ACK_TIMEOUT; }

bool Execute(TTransactionContext& txc, const TActorContext&) override {
bool Execute(TTransactionContext& /*txc*/, const TActorContext&) override {
SA_LOG_D("[" << Self->TabletID() << "] TTxAckTimeout::Execute");
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/statistics/aggregator/tx_analyze_table.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ struct TStatisticsAggregator::TTxAnalyzeTable : public TTxBase {
return true;
}

void Complete(const TActorContext& ctx) override {
void Complete(const TActorContext& /*ctx*/) override {
SA_LOG_D("[" << Self->TabletID() << "] TTxAnalyzeTable::Complete");
}
};
Expand Down
10 changes: 5 additions & 5 deletions ydb/core/statistics/aggregator/ut/ut_traverse_columnshard.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) {
auto sender = runtime.AllocateEdgeActor();
int observerCount = 0;
auto observer = runtime.AddObserver<TEvTxProxySchemeCache::TEvResolveKeySetResult>(
[&](TEvTxProxySchemeCache::TEvResolveKeySetResult::TPtr& ev)
[&](TEvTxProxySchemeCache::TEvResolveKeySetResult::TPtr& /*ev*/)
{
if (observerCount++ == 2) {
RebootTablet(runtime, saTabletId, sender);
Expand Down Expand Up @@ -89,7 +89,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) {
auto sender = runtime.AllocateEdgeActor();
bool observerFirstExec = true;
auto observer = runtime.AddObserver<TEvHive::TEvRequestTabletDistribution>(
[&](TEvHive::TEvRequestTabletDistribution::TPtr& ev)
[&](TEvHive::TEvRequestTabletDistribution::TPtr& /*ev*/)
{
if (observerFirstExec) {
observerFirstExec = false;
Expand Down Expand Up @@ -124,7 +124,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) {
auto sender = runtime.AllocateEdgeActor();
bool observerFirstExec = true;
auto observer = runtime.AddObserver<TEvStatistics::TEvAggregateStatistics>(
[&](TEvStatistics::TEvAggregateStatistics::TPtr& ev)
[&](TEvStatistics::TEvAggregateStatistics::TPtr& /*ev*/)
{
if (observerFirstExec) {
observerFirstExec = false;
Expand Down Expand Up @@ -159,7 +159,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) {
auto sender = runtime.AllocateEdgeActor();
bool observerFirstExec = true;
auto observer = runtime.AddObserver<TEvStatistics::TEvAggregateStatisticsResponse>(
[&](TEvStatistics::TEvAggregateStatisticsResponse::TPtr& ev)
[&](TEvStatistics::TEvAggregateStatisticsResponse::TPtr& /*ev*/)
{
if (observerFirstExec) {
observerFirstExec = false;
Expand Down Expand Up @@ -194,7 +194,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) {
auto sender = runtime.AllocateEdgeActor();
int observerCount = 0;
auto observer = runtime.AddObserver<TEvStatistics::TEvStatisticsRequest>(
[&](TEvStatistics::TEvStatisticsRequest::TPtr& ev)
[&](TEvStatistics::TEvStatisticsRequest::TPtr& /*ev*/)
{
if (observerCount++ == 5) {
RebootTablet(runtime, saTabletId, sender);
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/tx/columnshard/engines/changes/indexation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class TBatchInfo {
YDB_READONLY_DEF(std::shared_ptr<NArrow::TGeneralContainer>, Batch);

public:
TBatchInfo(const std::shared_ptr<NArrow::TGeneralContainer>& batch, const NEvWrite::EModificationType modificationType)
TBatchInfo(const std::shared_ptr<NArrow::TGeneralContainer>& batch, const NEvWrite::EModificationType /*modificationType*/)
: Batch(batch) {
}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ class IIndexInfo {
fieldId == (ui32)ESpecialColumn::DELETE_FLAG;
}

static bool IsNullableVerified(const ui32 fieldId) {
static bool IsNullableVerified(const ui32 /*fieldId*/) {
return false;
}

Expand Down
4 changes: 2 additions & 2 deletions ydb/core/tx/datashard/build_index.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ class TBuildScanUpload: public TActor<TBuildScanUpload<Activity>>, public NTable
}

template <typename TAddRow>
EScan FeedImpl(TArrayRef<const TCell> key, const TRow& row, TAddRow&& addRow) noexcept {
EScan FeedImpl(TArrayRef<const TCell> key, const TRow& /*row*/, TAddRow&& addRow) noexcept {
LOG_T("Feed key " << DebugPrintPoint(KeyTypes, key, *AppData()->TypeRegistry) << " " << Debug());

addRow();
Expand Down Expand Up @@ -440,7 +440,7 @@ class TBuildScanUpload: public TActor<TBuildScanUpload<Activity>>, public NTable
}
}

void HandleWakeup(const NActors::TActorContext& ctx) {
void HandleWakeup(const NActors::TActorContext& /*ctx*/) {
LOG_D("Retry upload " << Debug());

if (!WriteBuf.IsEmpty()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ ISubOperation::TPtr FinalizeIndexImplTable(TOperationContext& context, const TPa
return CreateFinalizeBuildIndexImplTable(partId, transaction);
}

ISubOperation::TPtr DropIndexImplTable(TOperationContext& context, const TPath& index, const TOperationId& nextId, const TOperationId& partId, const TString& name, const TPathId& pathId) {
ISubOperation::TPtr DropIndexImplTable(TOperationContext& /*context*/, const TPath& index, const TOperationId& nextId, const TOperationId& partId, const TString& name, const TPathId& pathId) {
TPath implTable = index.Child(name);
Y_ABORT_UNLESS(implTable->PathId == pathId);
Y_ABORT_UNLESS(implTable.LeafName() == name);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const char* IB_RESTORE_CDC_STREAM_NAME = "__ib_restore_stream";

namespace NKikimr::NSchemeShard {

void DoCreateLock(const TOperationId opId, const TPath& workingDirPath, const TPath& tablePath, bool allowIndexImplLock,
void DoCreateLock(const TOperationId opId, const TPath& workingDirPath, const TPath& tablePath, bool /*allowIndexImplLock*/,
TVector<ISubOperation::TPtr>& result)
{
auto outTx = TransactionTemplate(workingDirPath.PathString(),
Expand Down
2 changes: 1 addition & 1 deletion ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ struct TCombinerNodes {
}
}

void ConsumeRawData(TComputationContext& ctx, NUdf::TUnboxedValue* keys, NUdf::TUnboxedValue** from, NUdf::TUnboxedValue* to) const {
void ConsumeRawData(TComputationContext& /*ctx*/, NUdf::TUnboxedValue* keys, NUdf::TUnboxedValue** from, NUdf::TUnboxedValue* to) const {
std::fill_n(keys, KeyResultNodes.size(), NUdf::TUnboxedValuePod());
for (ui32 i = 0U; i < ItemNodes.size(); ++i) {
if (from[i] && IsInputItemNodeUsed(i)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ void TSkiffExecuteResOrPull::WriteValue(const NUdf::TUnboxedValue& value, TType*
}
}

bool TSkiffExecuteResOrPull::WriteNext(TMkqlIOCache& specsCache, const NYT::TNode& rec, ui32 tableIndex) {
bool TSkiffExecuteResOrPull::WriteNext(TMkqlIOCache& specsCache, const NYT::TNode& rec, ui32 /*tableIndex*/) {
if (!HasCapacity()) {
Truncated = true;
return false;
Expand Down
2 changes: 1 addition & 1 deletion ydb/library/yql/sql/v1/select.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ class TNodeSource: public ISource {
return ISource::DoInit(ctx, src);
}

TNodePtr Build(TContext& ctx) final {
TNodePtr Build(TContext& /*ctx*/) final {
auto nodeAst = AstNode(Node);
if (WrapToList) {
nodeAst = Y("ToList", nodeAst);
Expand Down
Loading