Skip to content

switch on aggregations pushdown into CS #7305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 11:25:55 UTC Pre-commit check for f014d97 has started.
2024-07-31 11:28:52 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-31 13:29:46 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9624 9566 0 19 25 14

🟢 2024-07-31 13:30:42 UTC Build successful.
🔴 2024-07-31 13:31:14 UTC ydbd size 5.5 GiB changed* by +275.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: e464b73 merge: f014d97 diff diff %
ydbd size 5 571 429 760 Bytes 5 860 526 216 Bytes +275.7 MiB +5.189%
ydbd stripped size 1 199 304 144 Bytes 1 467 603 184 Bytes +255.9 MiB +22.371%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 11:26:00 UTC Pre-commit check for f014d97 has started.
2024-07-31 11:31:12 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-31 11:37:01 UTC Build successful.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 11:26:15 UTC Pre-commit check for f014d97 has started.
2024-07-31 11:31:18 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-31 13:06:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13780 12436 0 5 1328 11

2024-07-31 13:07:32 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-31 13:15:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 (only retried tests) 3 0 5 1 8

2024-07-31 13:17:13 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-31 13:25:26 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 1 0 5 0 8

🟢 2024-07-31 13:26:34 UTC Build successful.
🟢 2024-07-31 13:27:09 UTC ydbd size 8.1 GiB changed* by +21.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e464b73 merge: f014d97 diff diff %
ydbd size 8 678 737 472 Bytes 8 678 759 104 Bytes +21.1 KiB +0.000%
ydbd stripped size 471 916 032 Bytes 471 922 048 Bytes +5.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 15:21:14 UTC Pre-commit check for 683cba2 has started.
2024-07-31 15:24:34 UTC Check linux-x86_64-release-clang14 is running...
2024-07-31 15:29:35 UTC Check cancelled

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 15:21:27 UTC Pre-commit check for 683cba2 has started.
2024-07-31 15:24:47 UTC Check linux-x86_64-release-asan is running...
2024-07-31 15:29:54 UTC Check cancelled

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 15:21:58 UTC Pre-commit check for 683cba2 has started.
2024-07-31 15:24:52 UTC Check linux-x86_64-relwithdebinfo is running...
2024-07-31 15:29:37 UTC Check cancelled

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 15:32:10 UTC Pre-commit check for 80f1384 has started.
2024-07-31 15:35:34 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-31 17:38:34 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9629 9566 0 17 27 19

🟢 2024-07-31 17:39:36 UTC Build successful.
🟢 2024-07-31 17:40:06 UTC ydbd size 5.5 GiB changed* by +34.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1dbe46b merge: 80f1384 diff diff %
ydbd size 5 861 242 928 Bytes 5 861 278 208 Bytes +34.5 KiB +0.001%
ydbd stripped size 1 467 761 232 Bytes 1 467 769 552 Bytes +8.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 15:33:36 UTC Pre-commit check for 80f1384 has started.
2024-07-31 15:36:28 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-31 15:41:08 UTC Build successful.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 15:36:09 UTC Pre-commit check for 80f1384 has started.
2024-07-31 15:39:01 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-31 17:12:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13783 12441 0 2 1329 11

2024-07-31 17:13:41 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-31 17:22:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 3 0 1 0 8

2024-07-31 17:23:14 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-31 17:30:50 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 (only retried tests) 1 0 1 0 8

🟢 2024-07-31 17:32:00 UTC Build successful.
🟢 2024-07-31 17:32:33 UTC ydbd size 8.1 GiB changed* by +17.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1dbe46b merge: 80f1384 diff diff %
ydbd size 8 679 965 544 Bytes 8 679 983 128 Bytes +17.2 KiB +0.000%
ydbd stripped size 471 972 000 Bytes 471 973 984 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review July 31, 2024 18:28
@ivanmorozov333 ivanmorozov333 merged commit ff5d894 into ydb-platform:main Jul 31, 2024
8 of 12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the switch_on_agg_pushdown branch July 31, 2024 18:28
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 9, 2024
Co-authored-by: Ivan Morozov <ivanmorozov@localhost.localdomain>
 Conflicts:
	ydb/core/kqp/ut/olap/clickbench_ut.cpp
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-12
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-14
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-21
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-30
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-31
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-36
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-37
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-38
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-40
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-41
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-7
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
Co-authored-by: Ivan Morozov <ivanmorozov@localhost.localdomain>
 Conflicts:
	ydb/core/kqp/ut/olap/clickbench_ut.cpp
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-12
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-14
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-21
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-30
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-31
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-36
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-37
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-38
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-40
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-41
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-7
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
Co-authored-by: Ivan Morozov <ivanmorozov@localhost.localdomain>
 Conflicts:
	ydb/core/kqp/ut/olap/clickbench_ut.cpp
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-12
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-14
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-21
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-30
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-31
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-36
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-37
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-38
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-40
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-41
	ydb/tests/functional/clickbench/canondata/test.test_plans_column_/queries-original-plan-column-7
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 12, 2024
Co-authored-by: Ivan Morozov <ivanmorozov@localhost.localdomain>
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 14, 2024
Co-authored-by: Ivan Morozov <ivanmorozov@localhost.localdomain>
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
Co-authored-by: Ivan Morozov <ivanmorozov@localhost.localdomain>

Conflicts in canondata
re-canonized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants