Skip to content

improve node deletion in hive #7218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

improve node deletion in hive

Changelog category

  • Improvement

Additional information

  • Delete nodes even when hive restarts between their disconnect and the time they are allowed to be deleted. Relevant for instance group update.
  • Set default node delete period = 1 hour - same as default node broker epoch

Copy link

github-actions bot commented Jul 29, 2024

2024-07-29 16:55:44 UTC Pre-commit check for 22a30cc has started.
2024-07-29 16:58:53 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-29 17:32:13 UTC Build successful.

Copy link

github-actions bot commented Jul 29, 2024

2024-07-29 16:56:51 UTC Pre-commit check for 22a30cc has started.
2024-07-29 16:59:57 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-29 19:16:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39743 34454 0 2 5275 12

2024-07-29 19:19:58 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-29 19:27:32 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13 (only retried tests) 5 0 0 0 8

🟢 2024-07-29 19:30:46 UTC Build successful.
🟢 2024-07-29 19:31:25 UTC ydbd size 8.1 GiB changed* by -3.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4381e8c merge: 22a30cc diff diff %
ydbd size 8 676 593 704 Bytes 8 676 590 016 Bytes -3.6 KiB -0.000%
ydbd stripped size 471 822 688 Bytes 471 822 688 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 29, 2024

2024-07-29 17:01:48 UTC Pre-commit check for 22a30cc has started.
2024-07-29 17:05:03 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-29 19:45:11 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11050 10469 0 82 324 175

🟢 2024-07-29 19:46:14 UTC Build successful.
🟢 2024-07-29 19:47:09 UTC ydbd size 5.2 GiB changed* by -3.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4381e8c merge: 22a30cc diff diff %
ydbd size 5 570 104 480 Bytes 5 570 101 152 Bytes -3.2 KiB -0.000%
ydbd stripped size 1 199 058 480 Bytes 1 199 057 456 Bytes -1.0 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke self-assigned this Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 16:07:46 UTC Pre-commit check for 0ce5e68 has started.
2024-07-31 16:18:20 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-31 18:30:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11041 10986 0 17 22 16

🟢 2024-07-31 18:32:08 UTC Build successful.
🟢 2024-07-31 18:32:35 UTC ydbd size 5.5 GiB changed* by +16.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 59d5dd6 merge: 0ce5e68 diff diff %
ydbd size 5 861 243 440 Bytes 5 861 260 736 Bytes +16.9 KiB +0.000%
ydbd stripped size 1 467 761 424 Bytes 1 467 763 664 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 16:08:00 UTC Pre-commit check for 0ce5e68 has started.
2024-07-31 16:16:34 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-31 16:53:59 UTC Build successful.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 16:13:56 UTC Pre-commit check for 0ce5e68 has started.
2024-07-31 16:17:02 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-31 18:27:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39789 34468 0 3 5303 15

2024-07-31 18:32:33 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-31 18:41:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 8 0 1 0 9

2024-07-31 18:45:19 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-31 18:54:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 2 0 1 0 9

🟢 2024-07-31 18:57:41 UTC Build successful.
🟢 2024-07-31 18:58:18 UTC ydbd size 8.1 GiB changed* by +13.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 59d5dd6 merge: 0ce5e68 diff diff %
ydbd size 8 679 966 216 Bytes 8 679 979 536 Bytes +13.0 KiB +0.000%
ydbd stripped size 471 972 064 Bytes 471 973 664 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke requested a review from ijon August 5, 2024 08:30
@vporyadke vporyadke merged commit c65f27b into ydb-platform:main Aug 9, 2024
8 of 12 checks passed
vporyadke added a commit to vporyadke/ydb that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants