Skip to content

Disable modification operations in CS by default #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Jul 26, 2024

Changelog category

  • Experimental feature

Выключаю флажок по-умолчанию, т.к., на мой взгляд, он был включен преждевременно.
Эта фича никогда не работала. Чтобы заработала требуется реализация локов в CS. Когда появится реализация локов, флажок можно будет включить обратно

Copy link

github-actions bot commented Jul 26, 2024

2024-07-26 08:45:22 UTC Pre-commit check for f4e9ceb has started.
2024-07-26 08:48:31 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 11:21:40 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11083 10491 0 90 332 170

🟢 2024-07-26 11:22:44 UTC Build successful.
🟢 2024-07-26 11:23:39 UTC ydbd size 5.2 GiB changed* by +64 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: eb725d9 merge: f4e9ceb diff diff %
ydbd size 5 564 723 464 Bytes 5 564 723 528 Bytes +64 Bytes +0.000%
ydbd stripped size 1 198 281 520 Bytes 1 198 281 456 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 26, 2024

2024-07-26 08:48:20 UTC Pre-commit check for f4e9ceb has started.
2024-07-26 08:51:31 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 09:28:36 UTC Build successful.

@zverevgeny zverevgeny requested a review from gridnevvvit July 26, 2024 08:50
Copy link

github-actions bot commented Jul 26, 2024

2024-07-26 08:51:27 UTC Pre-commit check for f4e9ceb has started.
2024-07-26 08:54:29 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 11:05:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39771 34480 0 3 5275 13

2024-07-26 11:09:38 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-26 11:16:57 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 8 0 0 0 8

🟢 2024-07-26 11:20:12 UTC Build successful.
🟢 2024-07-26 11:20:50 UTC ydbd size 8.1 GiB changed* by -1.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: eb725d9 merge: f4e9ceb diff diff %
ydbd size 8 667 494 928 Bytes 8 667 493 760 Bytes -1.1 KiB -0.000%
ydbd stripped size 471 530 176 Bytes 471 530 176 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny changed the title Disable modification operation in CS by default Disable modification operations in CS by default Jul 26, 2024
@zverevgeny zverevgeny merged commit 0671f74 into ydb-platform:main Jul 27, 2024
14 of 16 checks passed
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jul 27, 2024
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporarily disable INSERT operations to column shards CS fails when downgrade from 24.3 to 24.2
2 participants