improve failsafe on cuttting history #6918
Conversation
|
⚪
🟡
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟡
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ijon
changed the title
ydb/core/mind/hive/hive_impl.h
Outdated
| if (!denyList.empty()) { | ||
| auto found = std::find(denyList.begin(), denyList.end(), type); | ||
| allowed &= (found != denyList.end()); | ||
| } | ||
| const auto& allowList = CutHistoryAllowList; | ||
| if (!allowList.empty()) { | ||
| auto found = std::find(allowList.begin(), allowList.end(), type); | ||
| allowed &= (found == allowList.end()); | ||
| } |
There was a problem hiding this comment.
Здесь в (found != denyList.end()) и (found == allowList.end()) сравнения не надо ли поменять на противоположные?
Сейчас получается:
- разрешить, если есть в deny-list
- запретить, если нет в allow-list
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
тоже чуть-чуть обновил |
Changelog entry
...
Changelog category
Additional information
...