YDB FQ: avoid outdated syntax "SELECT * FROM cluster.`db.table`" #6901

vitalyisaev2 · 2024-07-20T16:26:17Z

Changelog entry

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.db.table" (now database name is always within cluster).

Changelog category

Bugfix

Additional information

...

github-actions · 2024-07-20T16:29:48Z

⚪ 2024-07-20 16:29:48 UTC Pre-commit check for 1430351 has started.
⚪ 2024-07-20 16:32:41 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-20 16:38:23 UTC Build successful.

github-actions · 2024-07-20T16:30:05Z

⚪ 2024-07-20 16:30:04 UTC Pre-commit check for 1430351 has started.
⚪ 2024-07-20 16:32:50 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-20 18:23:13 UTC Build successful.
🔴 2024-07-20 18:27:10 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38278	33030	0	9	5226	13

🟡 2024-07-20 18:27:48 UTC ydbd size 8.1 GiB changed* by +1014.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `1c15550`	merge: `1430351`	diff	diff %
ydbd size	8 656 109 112 Bytes	8 657 147 400 Bytes	+1014.0 KiB	+0.012%
ydbd stripped size	471 115 872 Bytes	471 139 360 Bytes	+22.9 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-20T16:30:05Z

⚪ 2024-07-20 16:30:04 UTC Pre-commit check for 1430351 has started.
⚪ 2024-07-20 16:32:53 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-20 18:46:30 UTC Build successful.
🔴 2024-07-20 18:49:39 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9764	9151	0	102	332	179

🟢 2024-07-20 18:50:39 UTC ydbd size 5.2 GiB changed* by -28.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `5e95651`	merge: `1430351`	diff	diff %
ydbd size	5 556 133 632 Bytes	5 556 104 048 Bytes	-28.9 KiB	-0.001%
ydbd stripped size	1 197 007 984 Bytes	1 197 005 040 Bytes	-2.9 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-20T21:31:31Z

⚪ 2024-07-20 21:31:31 UTC Pre-commit check for 4974645 has started.
⚪ 2024-07-20 21:34:15 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-20 21:39:10 UTC Build successful.

github-actions · 2024-07-20T21:33:24Z

⚪ 2024-07-20 21:33:23 UTC Pre-commit check for 4974645 has started.
⚪ 2024-07-20 21:36:06 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-20 23:24:47 UTC Build successful.
🔴 2024-07-20 23:29:00 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38283	33043	0	4	5225	11

🟡 2024-07-20 23:29:41 UTC ydbd size 8.1 GiB changed* by +1014.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `1c15550`	merge: `4974645`	diff	diff %
ydbd size	8 656 109 112 Bytes	8 657 147 400 Bytes	+1014.0 KiB	+0.012%
ydbd stripped size	471 115 872 Bytes	471 139 360 Bytes	+22.9 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-20T21:33:55Z

⚪ 2024-07-20 21:33:55 UTC Pre-commit check for 4974645 has started.
⚪ 2024-07-20 21:36:38 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-20 23:39:31 UTC Build successful.
🔴 2024-07-20 23:42:55 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9764	9168	0	89	332	175

🟢 2024-07-20 23:43:47 UTC ydbd size 5.2 GiB changed* by -28.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `5e95651`	merge: `4974645`	diff	diff %
ydbd size	5 556 133 632 Bytes	5 556 104 048 Bytes	-28.9 KiB	-0.001%
ydbd stripped size	1 197 007 984 Bytes	1 197 005 040 Bytes	-2.9 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-21T20:10:26Z

⚪ 2024-07-21 20:10:26 UTC Pre-commit check for e21da2e has started.
⚪ 2024-07-21 20:13:17 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-21 20:18:39 UTC Build successful.

github-actions · 2024-07-21T20:10:36Z

⚪ 2024-07-21 20:10:36 UTC Pre-commit check for e21da2e has started.
⚪ 2024-07-21 20:13:17 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-21 22:01:14 UTC Build successful.
🔴 2024-07-21 22:05:26 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38280	33034	0	4	5226	16

🟡 2024-07-21 22:06:08 UTC ydbd size 8.1 GiB changed* by +1016.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `1c15550`	merge: `e21da2e`	diff	diff %
ydbd size	8 656 109 112 Bytes	8 657 150 136 Bytes	+1016.6 KiB	+0.012%
ydbd stripped size	471 115 872 Bytes	471 138 848 Bytes	+22.4 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-21T20:11:05Z

⚪ 2024-07-21 20:11:05 UTC Pre-commit check for e21da2e has started.
⚪ 2024-07-21 20:13:49 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-21 22:24:25 UTC Build successful.
🔴 2024-07-21 22:27:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9762	9157	0	98	330	177

🟢 2024-07-21 22:28:21 UTC ydbd size 5.2 GiB changed* by -26.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `5e95651`	merge: `e21da2e`	diff	diff %
ydbd size	5 556 133 632 Bytes	5 556 106 712 Bytes	-26.3 KiB	-0.000%
ydbd stripped size	1 197 007 984 Bytes	1 197 003 312 Bytes	-4.6 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

dorooleg · 2024-07-22T08:13:28Z

ydb/library/yql/providers/generic/connector/libcpp/error.cpp

+                return NDqProto::StatusIds::StatusCode::StatusIds_StatusCode_BAD_REQUEST;
            default:
+                // FIXME: remove me after debug
+                Cout << "CRAB: " << ::Ydb::StatusIds::StatusCode_Name(error.status()) << Endl;


Это нужно убрать

dorooleg · 2024-07-22T08:15:15Z

ydb/library/yql/providers/generic/connector/libcpp/error.cpp

            case ::Ydb::StatusIds::StatusCode::StatusIds_StatusCode_NOT_FOUND:
                return NDqProto::StatusIds::StatusCode::StatusIds_StatusCode_BAD_REQUEST;
+            case ::Ydb::StatusIds::StatusCode::StatusIds_StatusCode_SCHEME_ERROR:
+                return NDqProto::StatusIds::StatusCode::StatusIds_StatusCode_BAD_REQUEST;


Нужно в NDqProto::StatusIds::StatusCode::StatusIds_StatusCode_SCHEME_ERROR мапить

dorooleg · 2024-07-22T08:17:17Z

ydb/library/yql/providers/generic/connector/tests/datasource/mysql/select_positive.py

                Column(
                    name='col_22_binary',
-                    ydb_type=makeOptionalYdbTypeFromTypeID(Type.UTF8),
+                    ydb_type=makeOptionalYdbTypeFromTypeID(Type.STRING),


Интересно как это связано с текущим ревью. Или это просто рефакторинг?

Тип MySQL Binary мапится в тип YDB String

https://github.com/ydb-platform/fq-connector-go/blob/17998b3542c7719295af44268b0e0dcdb0c2774a/docs/type_mapping_table.md?plain=1#L53C1-L53C265

dorooleg · 2024-07-22T14:08:07Z

Исправлено в рамках: #6945 (review)

…of PR #6901) (#6945) Co-authored-by: Vitaly Isaev <vitalyisaev@ydb.tech>

…of PR ydb-platform#6901) (ydb-platform#6945) Co-authored-by: Vitaly Isaev <vitalyisaev@ydb.tech>

vitalyisaev2 added 4 commits July 20, 2024 12:42

Reproduced on preprod

f94e9e8

Handle Scheme error

64672e3

Make database_name mandatory

508fc80

Drop commented out lines

06ce877

vitalyisaev2 requested a review from a team as a code owner July 20, 2024 16:26

github-actions bot added the bugfix label Jul 20, 2024

vitalyisaev2 added 2 commits July 20, 2024 21:26

Fix style

82f6ce3

MySQL binary type mapping

17caeb7

Fix ydb/tests/fq/generic

4b27fa8

dorooleg requested changes Jul 22, 2024

View reviewed changes

dorooleg pushed a commit that referenced this pull request Jul 23, 2024

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.db.table" (copy …

8a7db77

…of PR #6901) (#6945) Co-authored-by: Vitaly Isaev <vitalyisaev@ydb.tech>

dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Jul 23, 2024

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.db.table" (copy …

aa344c4

…of PR ydb-platform#6901) (ydb-platform#6945) Co-authored-by: Vitaly Isaev <vitalyisaev@ydb.tech>

dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Jul 23, 2024

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.db.table" (copy …

e9399ac

…of PR ydb-platform#6901) (ydb-platform#6945) Co-authored-by: Vitaly Isaev <vitalyisaev@ydb.tech>

This was referenced Jul 23, 2024

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.db.table" (copy … #6970

Merged

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.db.table" (copy … #6971

Merged

This was referenced Jul 23, 2024

YQ-3459 fix resource pools permissions #6989

Merged

YQ WM fix for sls feature flag #7057

Merged

vitalyisaev2 closed this Sep 10, 2024

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.db.table" #6901

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.db.table" #6901

Uh oh!

Conversation

vitalyisaev2 commented Jul 20, 2024

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dorooleg Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

dorooleg Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

dorooleg Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

lifthelm Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

dorooleg commented Jul 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.`db.table`" #6901

YDB FQ: avoid outdated syntax "SELECT * FROM cluster.`db.table`" #6901

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 21, 2024 •

edited

Loading

github-actions bot commented Jul 21, 2024 •

edited

Loading

github-actions bot commented Jul 21, 2024 •

edited

Loading