BTreeIndex Precharge Simplification #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kungasc
force-pushed
the
KIKIMR-19522-btree-precharge-first
branch
from
dac766b to
d42c83c
Compare
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit deb925a.
🔴 linux-x86_64-release-asan: some tests FAILED for commit deb925a.
|
kungasc
changed the title
kungasc
changed the title
azevaykin
approved these changes
Dec 25, 2023
This was referenced Dec 28, 2023
This was referenced Dec 29, 2023
Closed
adameat
pushed a commit
to adameat/ydb
that referenced
this pull request
Dec 29, 2023
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
Merged
63 tasks
kungasc
changed the title
This was referenced Feb 2, 2024
Merged
This was referenced Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's turned out that
Charge(row1, row2)methods are the same thatCharge(key1={}, key2={}, row1, row2), so I just removed them.PR also contains some renames and tests for
ChargeReverse(row1, row2)method.