Skip to content

Add inflight for garbage collection requests for Storage Load Actor, KIKIMR-20593 #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2024
Merged

Add inflight for garbage collection requests for Storage Load Actor, KIKIMR-20593 #666

merged 4 commits into from
Jan 25, 2024

Conversation

@serbel324
Copy link
Collaborator

@serbel324 serbel324 commented Dec 22, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 22, 2023 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-release-asan: some tests FAILED for commit c527934.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
7591 7261 0 250 76 4

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit c527934.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51151 41780 0 250 9115 6

@serbel324 serbel324 force-pushed the bs/load-test/insta-delete-mode branch from 7360899 to d5cf3db Compare December 25, 2023 10:25
@serbel324 serbel324 force-pushed the bs/load-test/insta-delete-mode branch from c527934 to 632840d Compare January 24, 2024 10:39
@serbel324 serbel324 force-pushed the bs/load-test/insta-delete-mode branch from 632840d to 6a3c092 Compare January 24, 2024 10:41
@github-actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

⚪ 2024-01-24 12:18:29 UTC Pre-commit check for 3ea6981 has started.
⚪ 2024-01-24 12:18:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-24 12:20:01 UTC Build successful.
⚪ 2024-01-24 12:20:10 UTC Tests are running...
🔴 2024-01-24 13:31:34 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59935 50656 0 22 9228 29

@github-actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

⚪ 2024-01-24 12:23:57 UTC Pre-commit check for 3ea6981 has started.
⚪ 2024-01-24 12:23:59 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-24 12:25:29 UTC Build successful.
⚪ 2024-01-24 12:25:38 UTC Tests are running...
🔴 2024-01-24 13:55:18 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15924 15828 0 16 53 27

va-kuznecov
va-kuznecov approved these changes Jan 24, 2024
View reviewed changes
ydb/core/load_test/group_write.cpp Outdated
auto ev = std::make_unique<TEvBlobStorage::TEvCollectGarbage>(TabletId, Generation, GarbageCollectStep, Channel,
true, Generation, GarbageCollectStep, nullptr, nullptr, TInstant::Max(), false);
auto callback = [](IEventBase *event, const TActorContext& /*ctx*/) {
auto ev = TEvBlobStorage::TEvCollectGarbage::CreateHardBarrier(TabletId, Generation, GarbageCollectStep,
Copy link
Member

@va-kuznecov va-kuznecov Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а зачем именно Hard барьер?

ты разве где-то ставишь Keep флаги?

@serbel324 serbel324 merged commit dbf1e80 into ydb-platform:main Jan 25, 2024
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@va-kuznecov va-kuznecov va-kuznecov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serbel324 @va-kuznecov