Skip to content

Create separate trace id for BlobStorage requests and link them to original traces #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

Create separate trace id for BlobStorage requests and link them to original traces #6444

merged 1 commit into from
Jul 9, 2024

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Jul 9, 2024

Changelog entry

Create separate trace id for BlobStorage requests and link them to original traces

Changelog category

  • Improvement

Additional information

Now separate traces are created for the BlobStorage requests to keep details out of the main request tracing tree.

@alexvru alexvru requested a review from a team as a code owner July 9, 2024 06:33
adameat
adameat previously approved these changes Jul 9, 2024
View reviewed changes
@alexvru alexvru self-assigned this Jul 9, 2024
@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 06:41:52 UTC Pre-commit check for 5067b0b has started.
⚪ 2024-07-09 06:44:46 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 07:27:07 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 06:42:01 UTC Pre-commit check for 5067b0b has started.
⚪ 2024-07-09 06:44:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 07:36:18 UTC Build successful.
⚪ 2024-07-09 07:36:31 UTC Tests are running...
🔴 2024-07-09 09:39:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13793 13177 0 99 339 178

🟡 2024-07-09 09:40:39 UTC ydbd size 5.2 GiB changed* by +389.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5b12fa6 merge: 5067b0b diff diff %
ydbd size 5 610 940 168 Bytes 5 611 338 576 Bytes +389.1 KiB +0.007%
ydbd stripped size 1 206 606 616 Bytes 1 206 687 064 Bytes +78.6 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 06:42:01 UTC Pre-commit check for 5067b0b has started.
⚪ 2024-07-09 06:44:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 07:50:24 UTC Build successful.
⚪ 2024-07-09 07:50:39 UTC Tests are running...
🔴 2024-07-09 09:55:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74920 61465 0 4 13428 23

🟡 2024-07-09 09:56:03 UTC ydbd size 8.1 GiB changed* by +736.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5b12fa6 merge: 5067b0b diff diff %
ydbd size 8 720 569 560 Bytes 8 721 323 672 Bytes +736.4 KiB +0.009%
ydbd stripped size 474 992 800 Bytes 475 015 840 Bytes +22.5 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the dsproxy/separate-trace-branch-for-bs branch from 1b3a63f to 119c2aa Compare July 9, 2024 10:00
@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 10:02:38 UTC Pre-commit check for 7e0a15a has started.
⚪ 2024-07-09 10:05:39 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-07-09 10:39:23 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 10:04:51 UTC Pre-commit check for 7e0a15a has started.
⚪ 2024-07-09 10:08:12 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-07-09 10:39:04 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 10:38:17 UTC Pre-commit check for 7e0a15a has started.
⚫ 2024-07-09 10:38:58 UTC Check cancelled

@alexvru alexvru force-pushed the dsproxy/separate-trace-branch-for-bs branch from 119c2aa to b3930e2 Compare July 9, 2024 10:38
@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 11:14:07 UTC Pre-commit check for 0493abc has started.
⚪ 2024-07-09 11:17:28 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 11:38:13 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 11:18:25 UTC Pre-commit check for 0493abc has started.
⚪ 2024-07-09 11:21:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 11:52:35 UTC Build successful.
⚪ 2024-07-09 11:52:46 UTC Tests are running...
🔴 2024-07-09 13:54:17 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13789 13180 0 95 336 178

🟡 2024-07-09 13:54:57 UTC ydbd size 5.2 GiB changed* by +253.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0fa3052 merge: 0493abc diff diff %
ydbd size 5 610 940 168 Bytes 5 611 199 192 Bytes +253.0 KiB +0.005%
ydbd stripped size 1 206 606 616 Bytes 1 206 673 176 Bytes +65.0 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 12:34:47 UTC Pre-commit check for 0493abc has started.
⚪ 2024-07-09 12:37:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 13:45:41 UTC Build successful.
⚪ 2024-07-09 13:45:52 UTC Tests are running...
🔴 2024-07-09 14:38:37 UTC Test run completed, no test results found for commit b3930e2. Please check test log.
🟡 2024-07-09 14:39:14 UTC ydbd size 8.1 GiB changed* by +374.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0fa3052 merge: 0493abc diff diff %
ydbd size 8 720 569 560 Bytes 8 720 952 768 Bytes +374.2 KiB +0.004%
ydbd stripped size 474 992 800 Bytes 475 013 792 Bytes +20.5 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-07-09 14:39:15 UTC Check cancelled

@adameat adameat self-requested a review July 9, 2024 14:31
adameat
adameat previously approved these changes Jul 9, 2024
View reviewed changes
@alexvru alexvru force-pushed the dsproxy/separate-trace-branch-for-bs branch from b3930e2 to 426d604 Compare July 9, 2024 14:38
@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 14:45:23 UTC Pre-commit check for def82ae has started.
⚪ 2024-07-09 14:48:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 15:29:28 UTC Build successful.
⚪ 2024-07-09 15:29:43 UTC Tests are running...
🔴 2024-07-09 17:40:32 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13792 13172 0 96 348 176

🟡 2024-07-09 17:41:20 UTC ydbd size 5.2 GiB changed* by +543.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 601cb7a merge: def82ae diff diff %
ydbd size 5 610 839 456 Bytes 5 611 395 568 Bytes +543.1 KiB +0.010%
ydbd stripped size 1 206 598 584 Bytes 1 206 691 992 Bytes +91.2 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 14:55:04 UTC Pre-commit check for def82ae has started.
⚪ 2024-07-09 14:58:04 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 15:31:53 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 15:16:12 UTC Pre-commit check for def82ae has started.
⚪ 2024-07-09 15:19:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 16:20:15 UTC Build successful.
⚪ 2024-07-09 16:20:24 UTC Tests are running...
🔴 2024-07-09 18:27:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74914 61466 0 2 13429 17

🟡 2024-07-09 18:28:36 UTC ydbd size 8.1 GiB changed* by +1018.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 30a2dc3 merge: def82ae diff diff %
ydbd size 8 720 348 080 Bytes 8 721 391 088 Bytes +1018.6 KiB +0.012%
ydbd stripped size 474 986 208 Bytes 475 014 112 Bytes +27.2 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) July 9, 2024 16:03
@alexvru alexvru merged commit 25286d4 into ydb-platform:main Jul 9, 2024
@alexvru alexvru deleted the dsproxy/separate-trace-branch-for-bs branch July 9, 2024 18:36
This was referenced Jul 12, 2024
Merged
Merged
This was referenced Jul 16, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 24, 2024
Merged
serbel324 pushed a commit to serbel324/ydb that referenced this pull request Nov 19, 2024
@alexvru @serbel324
Create separate trace id for BlobStorage requests and link them to or…
c2e94d8 
…iginal traces (ydb-platform#6444)
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
serbel324 added a commit to serbel324/ydb that referenced this pull request Nov 19, 2024
@serbel324
Revert "Create separate trace id for BlobStorage requests and link th…
c50eac9 
…em to original traces (ydb-platform#6444)"

This reverts commit c2e94d8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adameat adameat adameat approved these changes

Assignees

@alexvru alexvru

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexvru @adameat