Skip to content

Handle empty GC commands correctly #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jul 8, 2024

Changelog entry

Handle empty GC commands correctly

Changelog category

  • Bugfix

Additional information

VDisk now can handle correctly empty GC command (returning ERROR status instead of an assertion failure).

@github-actions github-actions bot added the bugfix label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 10:02:29 UTC Pre-commit check for c6c0670 has started.
2024-07-08 10:04:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 10:27:05 UTC Build successful.
2024-07-08 10:27:23 UTC Tests are running...
🔴 2024-07-08 10:53:21 UTC Test run completed, no test results found for commit 54d4fd6. Please check test log.
🟡 2024-07-08 10:54:06 UTC ydbd size 5.2 GiB changed* by +203.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1f88b11 merge: c6c0670 diff diff %
ydbd size 5 614 135 680 Bytes 5 614 343 824 Bytes +203.3 KiB +0.004%
ydbd stripped size 1 209 991 064 Bytes 1 210 027 064 Bytes +35.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-08 10:54:07 UTC Check cancelled

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 10:12:55 UTC Pre-commit check for c6c0670 has started.
2024-07-08 10:15:50 UTC Build linux-x86_64-relwithdebinfo is running...
2024-07-08 10:53:33 UTC Check cancelled

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 10:14:59 UTC Pre-commit check for c6c0670 has started.
2024-07-08 10:17:26 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 10:23:12 UTC Build successful.

@alexvru alexvru self-assigned this Jul 8, 2024
@alexvru alexvru force-pushed the vdisk/handle-empty-gc-commands branch from 54d4fd6 to 2706042 Compare July 8, 2024 10:53
Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 11:06:25 UTC Pre-commit check for 08db078 has started.
2024-07-08 11:09:26 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 11:31:44 UTC Build successful.
2024-07-08 11:31:55 UTC Tests are running...
🔴 2024-07-08 13:31:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10015 9424 0 82 336 173

🟢 2024-07-08 13:31:50 UTC ydbd size 5.2 GiB changed* by +8.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ab119a2 merge: 08db078 diff diff %
ydbd size 5 614 359 056 Bytes 5 614 367 712 Bytes +8.5 KiB +0.000%
ydbd stripped size 1 210 032 824 Bytes 1 210 034 296 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 11:18:58 UTC Pre-commit check for 08db078 has started.
2024-07-08 11:21:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 11:26:39 UTC Build successful.

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 11:20:55 UTC Pre-commit check for 08db078 has started.
2024-07-08 11:24:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 12:03:22 UTC Build successful.
2024-07-08 12:03:36 UTC Tests are running...
🔴 2024-07-08 13:25:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14287 12967 0 1 1307 12

🟢 2024-07-08 13:25:43 UTC ydbd size 8.1 GiB changed* by +7.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ab119a2 merge: 08db078 diff diff %
ydbd size 8 721 967 904 Bytes 8 721 975 208 Bytes +7.1 KiB +0.000%
ydbd stripped size 476 639 288 Bytes 476 639 928 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit 4cc05ae into ydb-platform:main Jul 8, 2024
8 of 12 checks passed
@alexvru alexvru deleted the vdisk/handle-empty-gc-commands branch July 8, 2024 15:06
alexvru added a commit to alexvru/ydb that referenced this pull request Jul 9, 2024
alexvru added a commit to alexvru/ydb that referenced this pull request Jul 9, 2024
alexvru added a commit that referenced this pull request Jul 9, 2024
alexvru added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove VERIFY on TEvVCollectGarbage message without Collect flag and with empty Keep and DoNotKeep arrays
2 participants