Skip to content

Increase TBasicExecutorPoolSanitizer timeout. 1000ns causes noticiable cpu usage #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2024
Merged

Increase TBasicExecutorPoolSanitizer timeout. 1000ns causes noticiable cpu usage #6265

merged 1 commit into from
Jul 4, 2024

Conversation

dcherednik
Copy link
Member

No description provided.

@dcherednik
Increase nanosleep timeout. 1000ns causes noticiable cpu usage
99f4cd5 
CPU usage for one test pack

before:
real 1m54.312s
user 7m1.247s
sys 3m21.446s

after:
real 1m52.389s
user 4m49.227s
sys 1m53.762s
@dcherednik dcherednik changed the title Increase nanosleep timeout. 1000ns causes noticiable cpu usage Increase TBasicExecutorPoolSanitizer timeout. 1000ns causes noticiable cpu usage Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 16:54:32 UTC Pre-commit check for 1b2fafd has started.
⚪ 2024-07-03 16:57:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-03 17:28:31 UTC Build successful.
⚪ 2024-07-03 17:28:43 UTC Tests are running...
🔴 2024-07-03 19:28:26 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13583 12981 0 94 336 172

🟢 2024-07-03 19:29:02 UTC ydbd size 5.3 GiB changed* by -98.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd87563 merge: 1b2fafd diff diff %
ydbd size 5 814 908 560 Bytes 5 712 085 520 Bytes -98.1 MiB -1.768%
ydbd stripped size 1 247 931 016 Bytes 1 235 278 696 Bytes -12.1 MiB -1.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 16:58:20 UTC Pre-commit check for 1b2fafd has started.
⚪ 2024-07-03 17:01:25 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-03 17:17:22 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 17:02:55 UTC Pre-commit check for 1b2fafd has started.
⚪ 2024-07-03 17:05:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-03 17:51:15 UTC Build successful.
⚪ 2024-07-03 17:51:31 UTC Tests are running...
🔴 2024-07-03 19:52:26 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74610 61215 0 1 13384 10

🟢 2024-07-03 19:53:05 UTC ydbd size 8.2 GiB changed* by -144.9 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd87563 merge: 1b2fafd diff diff %
ydbd size 8 926 807 928 Bytes 8 774 851 248 Bytes -144.9 MiB -1.702%
ydbd stripped size 486 814 568 Bytes 482 674 600 Bytes -3.9 MiB -0.850%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik self-assigned this Jul 3, 2024
@dcherednik dcherednik merged commit bcc7d5e into ydb-platform:main Jul 4, 2024
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 5, 2024
Merged
This was referenced Jul 8, 2024
Merged
Merged
Merged
Merged
This was referenced Jul 16, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 24, 2024
Merged
kruall added a commit to kruall/ydb that referenced this pull request Aug 26, 2024
@kruall
Revert "Increase TBasicExecutorPoolSanitizer timeout. 1000ns causes n…
7bcf3e6 
…oticiable cpu usage (ydb-platform#6265)"

This reverts commit bcc7d5e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruall kruall kruall approved these changes

Assignees

@dcherednik dcherednik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherednik @kruall