Skip to content

Out<NYql::TIssues> #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Out<NYql::TIssues> #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ydb/core/tx/datashard/ut_common/datashard_ut_common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,11 +1098,7 @@ static ui64 RunSchemeTx(
runtime.Send(new IEventHandle(MakeTxProxyID(), sender, request.Release()), 0, viaActorSystem);
auto ev = runtime.GrabEdgeEventRethrow<TEvTxUserProxy::TEvProposeTransactionStatus>(sender);

for (auto i : ev->Get()->Record.GetIssues()) {
Cerr << "Issue: " << i.AsJSON() << Endl;
}

UNIT_ASSERT_VALUES_EQUAL(ev->Get()->Record.GetStatus(), expectedStatus);
UNIT_ASSERT_VALUES_EQUAL_C(ev->Get()->Record.GetStatus(), expectedStatus, "Status: " << ev->Get()->Record.GetStatus() << " Issues: " << ev->Get()->Record.GetIssues());

return ev->Get()->Record.GetTxId();
}
Expand Down Expand Up @@ -1895,7 +1891,7 @@ void UploadRows(TTestActorRuntime& runtime, const TString& tablePath, const TVec
runtime.Register(actor);

auto ev = runtime.GrabEdgeEventRethrow<TEvTxUserProxy::TEvUploadRowsResponse>(uploadSender);
UNIT_ASSERT_VALUES_EQUAL_C(ev->Get()->Status, Ydb::StatusIds::SUCCESS, "Status: " << ev->Get()->Status << " Issues: " << ev->Get()->Issues.ToOneLineString());
UNIT_ASSERT_VALUES_EQUAL_C(ev->Get()->Status, Ydb::StatusIds::SUCCESS, "Status: " << ev->Get()->Status << " Issues: " << ev->Get()->Issues);
}

void WaitTabletBecomesOffline(TServer::TPtr server, ui64 tabletId)
Expand Down
5 changes: 5 additions & 0 deletions ydb/library/yql/public/issue/yql_issue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,3 +298,8 @@ template <>
void Out<NYql::TIssue>(IOutputStream& out, const NYql::TIssue& error) {
error.PrintTo(out);
}

template <>
void Out<NYql::TIssues>(IOutputStream& out, const NYql::TIssues& error) {
error.PrintTo(out);
}