Skip to content

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

Support authorization (not only authentication) in http ydb requests. It is needed for correct work in http requests in case of IAM AccessService.

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Jun 26, 2024

2024-06-26 13:59:44 UTC Pre-commit check for f6065cb has started.
2024-06-26 14:02:34 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 14:25:07 UTC Build successful.
2024-06-26 14:25:16 UTC Tests are running...
🔴 2024-06-26 16:35:37 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11283 10647 0 107 352 177

🟡 2024-06-26 16:36:30 UTC ydbd size 5.5 GiB changed* by +835.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ed1e090 merge: f6065cb diff diff %
ydbd size 5 914 295 664 Bytes 5 915 151 456 Bytes +835.7 KiB +0.014%
ydbd stripped size 1 270 541 736 Bytes 1 270 712 968 Bytes +167.2 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 26, 2024

2024-06-26 14:01:01 UTC Pre-commit check for f6065cb has started.
2024-06-26 14:03:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-26 14:30:45 UTC Build successful.

Copy link

github-actions bot commented Jun 26, 2024

2024-06-26 14:15:37 UTC Pre-commit check for f6065cb has started.
2024-06-26 14:18:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 14:40:35 UTC Build successful.
2024-06-26 14:40:45 UTC Tests are running...
🔴 2024-06-26 17:01:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71375 58010 0 10 13338 17

🟡 2024-06-26 17:02:22 UTC ydbd size 8.4 GiB changed* by +964.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ed1e090 merge: f6065cb diff diff %
ydbd size 9 019 580 888 Bytes 9 020 568 128 Bytes +964.1 KiB +0.011%
ydbd stripped size 492 614 504 Bytes 492 675 112 Bytes +59.2 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

dcherednik
dcherednik previously approved these changes Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

2024-06-27 14:58:57 UTC Pre-commit check for 33396eb has started.
2024-06-27 15:01:34 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-27 15:53:45 UTC Build failed. see the build logs.
🟡 2024-06-27 15:54:03 UTC ydbd size 8.4 GiB changed* by +998.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 648068e merge: 33396eb diff diff %
ydbd size 9 021 322 000 Bytes 9 022 344 192 Bytes +998.2 KiB +0.011%
ydbd stripped size 492 780 648 Bytes 492 843 016 Bytes +60.9 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 27, 2024

2024-06-27 15:02:38 UTC Pre-commit check for 33396eb has started.
2024-06-27 15:05:24 UTC Build linux-x86_64-release-clang14 is running...

Copy link

github-actions bot commented Jun 27, 2024

2024-06-27 15:06:34 UTC Pre-commit check for 33396eb has started.
2024-06-27 15:09:15 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-27 15:51:43 UTC Build failed. see the build logs.
🟡 2024-06-27 15:52:04 UTC ydbd size 5.5 GiB changed* by +725.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bb4992d merge: 33396eb diff diff %
ydbd size 5 916 265 904 Bytes 5 917 008 592 Bytes +725.3 KiB +0.013%
ydbd stripped size 1 271 071 528 Bytes 1 271 214 696 Bytes +139.8 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

adameat
adameat previously approved these changes Jul 1, 2024
@UgnineSirdis UgnineSirdis enabled auto-merge (squash) July 1, 2024 13:00
@UgnineSirdis UgnineSirdis added the rebase-and-check Rebase PR with the current base branch and check label Jul 1, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 14:15:21 UTC Pre-commit check for 4bfb70c has started.
2024-07-01 14:18:50 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-01 14:39:58 UTC Build failed. see the build logs.
🔴 2024-07-01 14:40:00 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 14:18:49 UTC Pre-commit check for 4bfb70c has started.
2024-07-01 14:21:30 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-01 14:47:37 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 14:41:56 UTC Pre-commit check for 4bfb70c has started.
2024-07-01 14:44:43 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-01 15:08:25 UTC Build failed. see the build logs.
🔴 2024-07-01 15:08:27 UTC Tests run skipped.

@UgnineSirdis UgnineSirdis dismissed stale reviews from adameat and dcherednik via 64ed8eb July 1, 2024 15:22
Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 15:33:10 UTC Pre-commit check for 10a1afc has started.
2024-07-01 15:36:37 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-01 16:11:45 UTC Build successful.

Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 16:02:04 UTC Pre-commit check for 10a1afc has started.
2024-07-01 16:05:17 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-01 17:03:30 UTC Build successful.
2024-07-01 17:03:43 UTC Tests are running...
🔴 2024-07-01 19:08:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39713 34511 0 2 5185 15

🔴 2024-07-01 19:08:47 UTC ydbd size 8.3 GiB changed* by +3.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 90c247b merge: 10a1afc diff diff %
ydbd size 8 954 166 152 Bytes 8 957 781 328 Bytes +3.4 MiB +0.040%
ydbd stripped size 488 284 744 Bytes 488 447 016 Bytes +158.5 KiB +0.033%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 16:30:06 UTC Pre-commit check for 10a1afc has started.
2024-07-01 16:33:29 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-01 17:17:14 UTC Build successful.
2024-07-01 17:17:28 UTC Tests are running...
🔴 2024-07-01 19:24:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11203 10588 0 104 339 172

🔴 2024-07-01 19:25:05 UTC ydbd size 5.4 GiB changed* by +3.8 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: dad8344 merge: 10a1afc diff diff %
ydbd size 5 831 125 664 Bytes 5 835 079 136 Bytes +3.8 MiB +0.068%
ydbd stripped size 1 251 057 864 Bytes 1 251 708 104 Bytes +635.0 KiB +0.052%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit 6576464 into ydb-platform:main Jul 1, 2024
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 2, 2024
UgnineSirdis added a commit that referenced this pull request Jul 2, 2024
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 2, 2024
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 2, 2024
@UgnineSirdis UgnineSirdis deleted the http-authorization branch July 8, 2024 10:12
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 8, 2024
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 8, 2024
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 8, 2024
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[[new IAM integration]] viewer/json/query http request doesn't check rights properly and restricts access when it mustn't
3 participants