Skip to content

Conversation

@dcherednik
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 11:46:05 UTC Pre-commit check for 54b1989 has started.
2024-06-20 11:48:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-20 11:50:11 UTC Build successful.
2024-06-20 11:50:21 UTC Tests are running...
🔴 2024-06-20 13:39:49 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9631 9575 0 17 24 15

🟢 2024-06-20 13:40:23 UTC ydbd size 5.7 GiB changed by +5.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f95d5a6 merge: 54b1989 diff diff %
ydbd size 6 149 690 728 Bytes 6 149 696 776 Bytes +5.9 KiB +0.000%
ydbd stripped size 1 527 556 160 Bytes 1 527 557 056 Bytes 896 Bytes 0.000%

@github-actions
Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 12:11:07 UTC Pre-commit check for 54b1989 has started.
2024-06-20 12:13:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-20 12:15:20 UTC Build successful.
2024-06-20 12:15:32 UTC Tests are running...
🔴 2024-06-20 13:47:12 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13912 12570 0 4 1328 10

🟡 2024-06-20 13:47:52 UTC ydbd size 8.6 GiB changed by +891.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 43d5e45 merge: 54b1989 diff diff %
ydbd size 9 214 548 552 Bytes 9 215 461 904 Bytes +891.9 KiB +0.010%
ydbd stripped size 711 277 424 Bytes 711 326 256 Bytes +47.7 KiB +0.007%

@github-actions
Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 12:12:21 UTC Pre-commit check for 54b1989 has started.
2024-06-20 12:14:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-20 12:17:27 UTC Build successful.

TString Name;
TVector<TString> KeyColumns;
TVector<TColumn> Columns;
TVector<std::pair<TString, TVector<TString>>> SyncSecondaryIndexes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не нашел где это используется.

Comment on lines 88 to 109
{
auto desc = env.GetDescription(replicatedPath);
const auto& replicatedDesc = desc.GetPathDescription().GetTable();

UNIT_ASSERT_VALUES_EQUAL(replicatedDesc.KeyColumnNamesSize(), tableDesc.KeyColumns.size());
for (ui32 i = 0; i < replicatedDesc.KeyColumnNamesSize(); ++i) {
UNIT_ASSERT_VALUES_EQUAL(replicatedDesc.GetKeyColumnNames(i), tableDesc.KeyColumns[i]);
}

UNIT_ASSERT_VALUES_EQUAL(replicatedDesc.ColumnsSize(), tableDesc.Columns.size());
for (ui32 i = 0; i < replicatedDesc.ColumnsSize(); ++i) {
auto pred = [name = replicatedDesc.GetColumns(i).GetName()](const auto& column) {
return name == column.Name;
};

UNIT_ASSERT(FindIfPtr(tableDesc.Columns, pred));
}

const auto& replCfg = replicatedDesc.GetReplicationConfig();
UNIT_ASSERT_VALUES_EQUAL(replCfg.GetMode(), NKikimrSchemeOp::TTableReplicationConfig::REPLICATION_MODE_READ_ONLY);
UNIT_ASSERT_VALUES_EQUAL(replCfg.GetConsistency(), NKikimrSchemeOp::TTableReplicationConfig::CONSISTENCY_WEAK);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это в другом тесте уже проверяется, можно не дублировать.

@dcherednik dcherednik force-pushed the dst_creator_index_support branch from f4b175f to e3baa8b Compare June 21, 2024 15:30
@CyberROFL CyberROFL changed the title Allow dst cretor to create table with index Allow dst creator to create table with index Jun 21, 2024
@github-actions
Copy link

github-actions bot commented Jun 21, 2024

2024-06-21 15:35:55 UTC Pre-commit check for b2182e1 has started.
2024-06-21 15:38:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-21 15:40:17 UTC Build successful.
2024-06-21 15:40:30 UTC Tests are running...
🔴 2024-06-21 17:45:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9660 9075 0 93 325 167

🟡 2024-06-21 17:45:56 UTC ydbd size 5.5 GiB changed* by +307.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 95d290a merge: b2182e1 diff diff %
ydbd size 5 855 385 744 Bytes 5 855 700 696 Bytes +307.6 KiB +0.005%
ydbd stripped size 1 255 660 360 Bytes 1 255 709 192 Bytes +47.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jun 21, 2024

2024-06-21 15:44:50 UTC Pre-commit check for b2182e1 has started.
2024-06-21 15:47:10 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-21 15:50:07 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jun 21, 2024

2024-06-21 15:55:30 UTC Pre-commit check for b2182e1 has started.
2024-06-21 15:57:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-21 15:59:38 UTC Build successful.
2024-06-21 15:59:50 UTC Tests are running...
🔴 2024-06-21 17:27:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13919 12543 0 7 1358 11

🟡 2024-06-21 17:27:46 UTC ydbd size 8.3 GiB changed* by +522.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 59298b8 merge: b2182e1 diff diff %
ydbd size 8 961 691 128 Bytes 8 962 226 176 Bytes +522.5 KiB +0.006%
ydbd stripped size 488 403 752 Bytes 488 415 016 Bytes +11.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants