LOGBROKER-8783 propose api #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ildar-khisambeev merged 6 commits into ydb-platform:main from ildar-khisambeev:LOGBROKER-8783

Jan 31, 2024

Contributor

ildar-khisambeev commented Dec 18, 2023 •

edited

Loading

Propose read policy settings for fed sdk api

github-actions bot commented Dec 18, 2023 •

edited

Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-release-asan: some tests FAILED for commit d9a994f.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15876	15761	0	12	94	9

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit d9a994f.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
59898	50675	0	1	9207	15

ildar-khisambeev commented

View reviewed changes

ydb/public/sdk/cpp/client/ydb_federated_topic/federated_topic.h Show resolved Hide resolved

ildar-khisambeev commented

View reviewed changes

ydb/public/sdk/cpp/client/ydb_federated_topic/federated_topic.h Outdated Show resolved Hide resolved

ildar-khisambeev commented

View reviewed changes

ydb/public/sdk/cpp/client/ydb_federated_topic/impl/federated_read_session.cpp Outdated Show resolved Hide resolved

ildar-khisambeev commented

View reviewed changes

ydb/public/sdk/cpp/client/ydb_federated_topic/impl/federated_read_session.cpp Outdated Show resolved Hide resolved

ildar-khisambeev commented

View reviewed changes

ydb/public/sdk/cpp/client/ydb_federated_topic/impl/federated_read_session.cpp Outdated

-                  // 2) OpenSubSessionsImpl, CloseSubSessionsImpl
-                  OpenSubSessionsImpl();
-                  // 3) TODO LATER reschedule OnFederatedStateUpdate
+                  if (Settings.ReadMirroredEnabled) {

Contributor Author

ildar-khisambeev Dec 20, 2023

Рекомендация: выделить всю ветку ReadMirroredEnabled от и до, для более понятной логики

ildar-khisambeev commented

View reviewed changes

ydb/public/sdk/cpp/client/ydb_federated_topic/impl/federated_read_session.cpp

+                      }
+                  }
+                  if (databases.empty()) {

Contributor Author

ildar-khisambeev Dec 20, 2023

Обязательно выдать ошибку!

Contributor Author

ildar-khisambeev Jan 17, 2024

EXception в пользователя (если пустой список, то это значит пользователь дал плохой запрос)

Contributor Author

ildar-khisambeev Jan 17, 2024

TODO - возвращать unavailable, чтобы поретраиться
Разделить причину на bad_request и unavailable

ildar-khisambeev commented

View reviewed changes

ydb/public/sdk/cpp/client/ydb_federated_topic/impl/federated_topic.cpp Outdated Show resolved Hide resolved

ildar-khisambeev added 4 commits

January 16, 2024 06:37


          Propose read policy settings for fed sdk api

0f2515d


          better api

3351f28


          implementation

c068d17


          issues (except logging)

d9a994f

ildar-khisambeev force-pushed the LOGBROKER-8783 branch from fbdd3f2 to d9a994f Compare

January 16, 2024 06:38

Alek5andr-Kotov previously approved these changes

View reviewed changes


          provide topic origin info

9e62913

ildar-khisambeev dismissed Alek5andr-Kotov’s stale review via

9e62913

January 23, 2024 23:15

alexnick88 reviewed

View reviewed changes

ydb/public/sdk/cpp/client/ydb_federated_topic/impl/federated_topic.cpp Show resolved Hide resolved

ydb/public/sdk/cpp/client/ydb_federated_topic/federated_topic.h Outdated Show resolved Hide resolved

ydb/public/sdk/cpp/client/ydb_federated_topic/impl/federated_read_session.h Show resolved Hide resolved


          more issues, add basic test

dca01ce

github-actions bot commented Jan 25, 2024 •

edited

Loading

⚪ 2024-01-25 13:25:19 UTC Pre-commit check for a9ee573 has started.
⚪ 2024-01-25 13:25:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-25 13:27:29 UTC Build successful.
⚪ 2024-01-25 13:27:42 UTC Tests are running...
🔴 2024-01-25 13:38:44 UTC Some tests failed, follow the links below.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60105	50834	0	12	9236	23

github-actions bot commented Jan 25, 2024 •

edited

Loading

⚪ 2024-01-25 13:25:45 UTC Pre-commit check for a9ee573 has started.
⚪ 2024-01-25 13:25:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-25 13:27:56 UTC Build successful.
⚪ 2024-01-25 13:28:07 UTC Tests are running...
🔴 2024-01-25 13:35:59 UTC Some tests failed, follow the links below.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15940	15845	0	18	42	35

alexnick88 approved these changes

View reviewed changes

ildar-khisambeev merged commit 94651fc into ydb-platform:main

Jornydb mentioned this pull request

[docs] Add subcommands in workload-transfer #1462

Merged

pavelvelikhov mentioned this pull request

Fixed clang14 issue with lambda capture #1475

Merged

vitstn mentioned this pull request

Clarify evaluation documentation #1478

Merged

This was referenced Jan 31, 2024

Revert background cleaning #1485

Closed

Fix scheme_tests canondata #1493

Merged

This was referenced Feb 1, 2024

KIKIMR 20897/move mvp to github #1504

Closed

KIKIMR 20897/move mvp to github #1507

Draft

vitstn mentioned this pull request

Drop LLVM12 #1511

Merged

GrigoriyPA mentioned this pull request

KqpRun add results into clear execution #1661

Merged

This was referenced Feb 7, 2024

YQL-17725 tune doc #1667

Merged

Switch pg_parser BC tests on again #1709

Merged

unmute test #1711

Merged

ildar-khisambeev deleted the LOGBROKER-8783 branch

February 8, 2024 12:09

ildar-khisambeev mentioned this pull request

LOGBROKER-8783 bugfix #1713

Merged

vitstn mentioned this pull request

Mark mutable_id for YT writes #1744

Merged

niksaveliev mentioned this pull request

Fix pq writer and few renames #1757

Merged

GrigoriyPA mentioned this pull request

Moved optimizers from yql/providers/dq to yql/dq #1758

Merged

pavelvelikhov mentioned this pull request

Cannonized two plans #1773

Merged

niksaveliev mentioned this pull request

Workload read without consumer and metrics fixes #1792

Merged

starlinskiy mentioned this pull request

runtime dispatching #1800

Closed

vitstn mentioned this pull request

quick fix for column name of select version() #1801

Merged

GrigoriyPA mentioned this pull request

YQ 2786 fix test fq restarts #1810

Merged

vitstn mentioned this pull request

Support of database sys cache #1817

Merged

starlinskiy mentioned this pull request

runtime dispatching (fixed) #1847

Merged

pavelvelikhov mentioned this pull request

Fixed a problem with simplified plan JSONs #1878

Merged

This was referenced Feb 13, 2024

Case insensivity for pg_catalog tables/cluster, columns. Support of pg_class:relam, and some columns in pg_database & pg_namespace #1893

Merged

fixed pg_get_userbyid function #1936

Merged

support of AnyNonArray type, fixes for array_agg #1958

Merged

pavelvelikhov mentioned this pull request

Fixed a problem with plans in PG ut #1974

Merged

niksaveliev mentioned this pull request

Fix kafka with enabled proxy #2017

Merged

vitstn mentioned this pull request

mock of savepoints #2026

Merged

This was referenced Feb 17, 2024

YQ 2786 unmute s3 test bindings #2042

Merged

YQ-2884 fixed fq cancel operation race #2055

Merged

YQ-2883 fix retries for recover point COMPLETING #2107

Merged

YQ-2873 fix hanging in kqp compute actor #2131

Merged

YQ-2786 partly unmute tests fq s3 #2143

Merged

aakulaga-ydb mentioned this pull request

Fix TzTimestamp wrong encoding (YQL-17920) #2222

Merged

GrigoriyPA mentioned this pull request

YQ-2898 fix query failed with unknown uncommitted upload issue #2240

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet