KIKIMR-20321 viewer tests asan fix #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-release-asan: some tests FAILED for commit 824f76d.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 824f76d.
|
StekPerepolnen
changed the title
adameat
approved these changes
Dec 20, 2023
CyberROFL
approved these changes
Dec 20, 2023
Collaborator
Author
|
switching method calls from . to ->, which led to some test failures |
Collaborator
Author
|
rebase |
StekPerepolnen
force-pushed
the
KIKIMR-20231/asan-fix
branch
from
e6d6f3a to
824f76d
Compare
StekPerepolnen
changed the title
This was referenced Dec 21, 2023
marsaly79
pushed a commit
to marsaly79/ydb
that referenced
this pull request
Dec 22, 2023
KIKIMR-20231/asan-fix
This was referenced Dec 29, 2023
This was referenced Dec 29, 2023
Closed
Closed
Merged
This was referenced Jan 15, 2024
Merged
This was referenced Jan 17, 2024
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://st.yandex-team.ru/KIKIMR-20321
Modifications have been made to the TServerSetting class: AppConfig has been updated to a shared_ptr type. Since AppConfig is incorporated into KikimrRunConfig, this change resolves the issue previously encountered during the copying of TServerSetting instances