KIKIMR-20521: Add UseVDisksBalancing feature flag #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-release-asan: some tests FAILED for commit a59c777.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit a59c777.
|
kruall
reviewed
Dec 22, 2023
| return; | ||
| } | ||
| if (BalancingId) { | ||
| ActiveActors.Erase(BalancingId); |
Collaborator
There was a problem hiding this comment.
А тут не надо отправить PoisonPill балансеру?
Collaborator
Author
There was a problem hiding this comment.
Кажется действительно нужно, я до этого видимо не внимательно прочитал код и думал что он сам пошлет PoisonPill при Erase, а он шлет только в деструкторе тем что остались внем.
Замержу сейчас так, а в следующем пр поправлю
kruall
approved these changes
Dec 22, 2023
marsaly79
pushed a commit
to marsaly79/ydb
that referenced
this pull request
Dec 22, 2023
Co-authored-by: robdrynkin <robdrynkin@nebius.com>
This was referenced Dec 28, 2023
This was referenced Dec 29, 2023
This was referenced Dec 29, 2023
Closed
Closed
Merged
This was referenced Jan 15, 2024
Merged
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.