Skip to content

add test for ddl with explicit transaction #5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2024
Merged

add test for ddl with explicit transaction #5124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
155e8de
add test for ddl with explicit transaction
VPolka Jun 3, 2024
d127968
add case
VPolka Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 56 additions & 8 deletions ydb/core/kqp/ut/service/kqp_qs_queries_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2146,7 +2146,7 @@ Y_UNIT_TEST_SUITE(KqpQueryService) {
}
}

Y_UNIT_TEST(Ddl_Dml) {
Y_UNIT_TEST(DdlWithExplicitTransaction) {
NKikimrConfig::TAppConfig appConfig;
appConfig.MutableTableServiceConfig()->SetEnablePreparedDdl(true);
appConfig.MutableTableServiceConfig()->SetEnableAstCache(true);
Expand All @@ -2160,23 +2160,71 @@ Y_UNIT_TEST_SUITE(KqpQueryService) {
auto db = kikimr.GetQueryClient();

{
// DDl + DML with explicit transaction
// DDl with explicit transaction
auto result = db.ExecuteQuery(R"(
CREATE TABLE TestDdlDml1 (
Key Uint64,
Value1 String,
Value2 String,
PRIMARY KEY (Key)
);
UPSERT INTO TestDdlDml1 (Key, Value1, Value2) VALUES (1, "1", "2");
SELECT * FROM TestDdlDml1;
ALTER TABLE TestDdlDml1 DROP COLUMN Value2;
UPSERT INTO TestDdlDml1 (Key, Value1) VALUES (2, "2");
)", TTxControl::BeginTx().CommitTx()).ExtractValueSync();
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::PRECONDITION_FAILED, result.GetIssues().ToString());
UNIT_ASSERT(result.GetIssues().ToOneLineString().Contains("Scheme operations cannot be executed inside transaction"));
}

{
// DDl with explicit transaction
auto result = db.ExecuteQuery(R"(
CREATE TABLE TestDdlDml1 (
Key Uint64,
PRIMARY KEY (Key)
);
CREATE TABLE TestDdlDml2 (
Key Uint64,
PRIMARY KEY (Key)
);
)", TTxControl::BeginTx().CommitTx()).ExtractValueSync();
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::PRECONDITION_FAILED, result.GetIssues().ToString());
UNIT_ASSERT(result.GetIssues().ToOneLineString().Contains("Scheme operations cannot be executed inside transaction"));
}

{
// DDl with implicit transaction
auto result = db.ExecuteQuery(R"(
CREATE TABLE TestDdlDml1 (
Key Uint64,
PRIMARY KEY (Key)
);
)", TTxControl::NoTx()).ExtractValueSync();
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS, result.GetIssues().ToString());
}

{
// DDl + DML with explicit transaction
auto result = db.ExecuteQuery(R"(
SELECT * FROM TestDdlDml1;
CREATE TABLE TestDdlDml2 (
Key Uint64,
PRIMARY KEY (Key)
);
SELECT * FROM TestDdlDml2;
)", TTxControl::BeginTx().CommitTx()).ExtractValueSync();
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::GENERIC_ERROR, result.GetIssues().ToString());
UNIT_ASSERT(result.GetIssues().ToOneLineString().Contains("Queries with mixed data and scheme operations are not supported."));
}
}

Y_UNIT_TEST(Ddl_Dml) {
NKikimrConfig::TAppConfig appConfig;
appConfig.MutableTableServiceConfig()->SetEnablePreparedDdl(true);
appConfig.MutableTableServiceConfig()->SetEnableAstCache(true);
appConfig.MutableTableServiceConfig()->SetEnablePerStatementQueryExecution(true);
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
.SetAppConfig(appConfig)
.SetKqpSettings({setting});

TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetQueryClient();

{
// DDl + DML with implicit transaction
Expand Down