Skip to content

Preserve statistics for S3Settings node #5012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

Preserve statistics for S3Settings node #5012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions ydb/library/yql/providers/dq/provider/yql_dq_statistics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,16 @@ class TDqsStatisticsTransformer : public NDq::TDqStatisticsTransformerBase {

bool BeforeLambdasSpecific(const TExprNode::TPtr& input, TExprContext& ctx) override {
bool matched = true;
bool hasDqSource = false;

if (TDqReadWrapBase::Match(input.Get()) || (hasDqSource = TDqSourceWrapBase::Match(input.Get()))) {
auto node = hasDqSource
? input
: input->Child(TDqReadWrapBase::idx_Input);
auto dataSourceChildIndex = 1;
YQL_ENSURE(node->ChildrenSize() > 1);
YQL_ENSURE(node->Child(dataSourceChildIndex)->IsCallable("DataSource"));
auto dataSourceName = node->Child(dataSourceChildIndex)->Child(0)->Content();
auto datasource = State->TypeCtx->DataSourceMap.FindPtr(dataSourceName);
YQL_ENSURE(datasource);
if (auto dqIntegration = (*datasource)->GetDqIntegration()) {
auto stat = dqIntegration->ReadStatistics(node, ctx);
if (stat) {
State->TypeCtx->SetStats(input.Get(), std::make_shared<TOptimizerStatistics>(std::move(*stat)));
}

if (TDqReadWrapBase::Match(input.Get())) {
if (auto stat = GetStats(input->Child(TDqReadWrapBase::idx_Input), ctx)) {
State->TypeCtx->SetStats(input.Get(), stat);
}
} else if (TDqSourceWrapBase::Match(input.Get())) {
if (auto stat = GetStats(input, ctx)) {
State->TypeCtx->SetStats(input.Get(), stat);
// This node can be split, so to preserve the statistics, we also expose it to settings
State->TypeCtx->SetStats(input->Child(TDqSourceWrapBase::idx_Settings), stat);
}
} else {
matched = false;
Expand All @@ -52,6 +45,21 @@ class TDqsStatisticsTransformer : public NDq::TDqStatisticsTransformerBase {
}

private:
std::shared_ptr<TOptimizerStatistics> GetStats(const TExprNode::TPtr& node, TExprContext& ctx) {
auto dataSourceChildIndex = 1;
YQL_ENSURE(node->ChildrenSize() > 1);
YQL_ENSURE(node->Child(dataSourceChildIndex)->IsCallable("DataSource"));
auto dataSourceName = node->Child(dataSourceChildIndex)->Child(0)->Content();
auto datasource = State->TypeCtx->DataSourceMap.FindPtr(dataSourceName);
if (auto dqIntegration = (*datasource)->GetDqIntegration()) {
auto stat = dqIntegration->ReadStatistics(node, ctx);
if (stat) {
return std::make_shared<TOptimizerStatistics>(std::move(*stat));
}
}
return {};
}

TDqStatePtr State;
};

Expand Down