-
Notifications
You must be signed in to change notification settings - Fork 638
YDBD binary args: added database quotas limits #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! Thank you for contributing! |
@Gazizonoki Hi! The failed tests do not look like they are related to my request, but because of them i can't merge request. Can you take a look? |
@Iliamish We still need to discuss whether we need this feature or not. I am not entitled to make this decision alone. We will come back with an answer a bit later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get rid of the copy paste in:
- parser configuration;
- parsing.
Good afternoon! I don't quite understand where you can get rid of the copy paste in this code. |
@CyberROFL Hi! Can you please come back to PR |
@Gazizonoki, Hi! Are there any updates about this PR? |
Move these sections to common place (base class, helpers, etc) and reuse them: config.Opts->AddLongOption("data-size-hard-quota", "A maximum data size in bytes, new data will be rejected when exceeded").RequiredArgument("NUM").StoreResult(&DataSizeHardQuota);
config.Opts->AddLongOption("data-size-soft-quota", "Data size in bytes (lower than data_size_hard_quota), at this value new data ingestion is re-enabled again").RequiredArgument("NUM").StoreResult(&DataSizeSoftQuota); if (config.ParseResult->Has("data-size-hard-quota"))
GRpcRequest.mutable_database_quotas()->set_data_size_hard_quota(DataSizeHardQuota);
if (config.ParseResult->Has("data-size-soft-quota"))
GRpcRequest.mutable_database_quotas()->set_data_size_soft_quota(DataSizeSoftQuota); |
@CyberROFL Hi! Can you please review updates |
No description provided.