Skip to content

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2024
Merged

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4688

merged 5 commits into from
May 21, 2024

Conversation

@vitalyisaev2
Copy link
Contributor

@vitalyisaev2 vitalyisaev2 commented May 20, 2024

Changelog entry

  • Always add 'u-' prefix to the dedicated YDB database endpoint during resolving

Changelog category

  • Bugfix (YQ-3163)

Additional information

...

@vitalyisaev2 vitalyisaev2 requested a review from a team as a code owner May 20, 2024 15:00
@github-actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

⚪ 2024-05-20 15:04:11 UTC Pre-commit check for 34bc5de has started.
⚪ 2024-05-20 15:04:14 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 15:06:01 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

⚪ 2024-05-20 15:04:25 UTC Pre-commit check for 34bc5de has started.
⚪ 2024-05-20 15:04:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 15:06:21 UTC Build successful.
⚪ 2024-05-20 15:08:10 UTC Tests are running...
🔴 2024-05-20 16:59:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9242 9186 0 17 27 12

@github-actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

⚪ 2024-05-20 15:06:51 UTC Pre-commit check for 34bc5de has started.
⚪ 2024-05-20 15:06:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 15:08:43 UTC Build successful.
⚪ 2024-05-20 15:10:26 UTC Tests are running...
🔴 2024-05-20 16:42:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36521 31732 0 4 4776 9

uzhastik
uzhastik reviewed May 20, 2024
View reviewed changes
ydb/core/fq/libs/actors/ut/database_resolver_ut.cpp Outdated
{
"endpoint":"grpcs://lb.etn021us5r9rhld1vgbh.ydb.mdb.yandexcloud.net:2135/?database=/ru-central1/b1g7jdjqd07qg43c4fmp/etn021us5r9rhld1vgbh",
"storageConfig":{"storageSizeLimit":107374182400}
"dedicatedDatabase":{"resuorcePresetId": "medium"}
Copy link
Collaborator

@uzhastik uzhastik May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

думаю, тут норм был пример
и у тебя опечатка

Copy link
Contributor Author

@vitalyisaev2 vitalyisaev2 May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Опечатку поправил. А по поводу того, что storageConfig заменился на dedicatedDatabase, я сознательно это сделал в парсере ответов, т. к. это выглядит более явно. Если в ответе API есть секция dedicatedDatabase, значит это со 100% вероятностью dedicated database. Со storageConfig это было не так очевидно.

kardymonds
kardymonds previously approved these changes May 21, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 07:59:41 UTC Pre-commit check for 7d05409 has started.
⚪ 2024-05-21 07:59:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-21 08:01:27 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 08:02:08 UTC Pre-commit check for 7d05409 has started.
⚪ 2024-05-21 08:02:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-21 08:04:03 UTC Build successful.
⚪ 2024-05-21 08:05:47 UTC Tests are running...
🟢 2024-05-21 09:35:14 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36531 31739 0 0 4785 7

@github-actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 08:02:16 UTC Pre-commit check for 7d05409 has started.
⚪ 2024-05-21 08:02:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-21 08:04:18 UTC Build successful.
⚪ 2024-05-21 08:06:07 UTC Tests are running...
🔴 2024-05-21 10:01:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9234 9174 0 24 27 9

@vitalyisaev2 vitalyisaev2 merged commit 90ae575 into ydb-platform:main May 21, 2024
vitalyisaev2 added a commit to vitalyisaev2/ydb that referenced this pull request May 21, 2024
@vitalyisaev2
Always add 'u-' prefix to the dedicated YDB database endpoint during …
739f3fc 
…resolving (ydb-platform#4688)
vitalyisaev2 added a commit to vitalyisaev2/ydb that referenced this pull request May 21, 2024
@vitalyisaev2
Always add 'u-' prefix to the dedicated YDB database endpoint during …
c71c4fe 
…resolving (ydb-platform#4688)
This was referenced May 21, 2024
Merged
Merged
vitalyisaev2 added a commit that referenced this pull request May 21, 2024
@vitalyisaev2
Merge from main acfab9b 90ae575 (#4717)
e7ee081 
* Fix connection error handling in database resolver (#2990)
* Always add 'u-' prefix to the dedicated YDB database endpoint during resolving (#4688)
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@vitalyisaev2 @MrLolthe1st
Always add 'u-' prefix to the dedicated YDB database endpoint during …
94a2556 
…resolving (ydb-platform#4688)
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 29, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 30, 2024
Merged
This was referenced May 30, 2024
Merged
Closed
Closed
Merged
This was referenced Jun 7, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzhastik uzhastik uzhastik left review comments

@kardymonds kardymonds kardymonds approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vitalyisaev2 @uzhastik @kardymonds