Skip to content

Bring back an old TPersQueueV1TestServer ctor #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2024
Merged

Bring back an old TPersQueueV1TestServer ctor #4577

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cfcbd7
Bring back an old TPersQueueV1TestServer ctor
qyryq May 15, 2024
f9a2c9d
Drop default from ctor
qyryq May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ydb/services/persqueue_v1/ut/persqueue_test_fixture.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,17 @@ static void ModifyTopicACL(NYdb::TDriver* driver, const TString& topic, const TV

class TPersQueueV1TestServer : public TPersQueueV1TestServerBase {
public:
explicit TPersQueueV1TestServer(const TPersQueueV1TestServerSettings& settings = {})
explicit TPersQueueV1TestServer(const TPersQueueV1TestServerSettings& settings)
: TPersQueueV1TestServerBase(settings.TenantModeEnabled)
, Settings(settings)
{
InitAll();
}

TPersQueueV1TestServer(bool checkAcl = false, bool tenantModeEnabled = false)
: TPersQueueV1TestServer({ .CheckACL = checkAcl, .TenantModeEnabled = tenantModeEnabled })
{}

void InitAll() {
InitializePQ();
}
Expand Down Expand Up @@ -331,4 +335,3 @@ static void ModifyTopicACL(NYdb::TDriver* driver, const TString& topic, const TV
*/
};
}