Skip to content

Make cooldown timeout on VDisk flexible #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

Make cooldown timeout on VDisk flexible #4551

merged 1 commit into from
May 16, 2024

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented May 15, 2024

Changelog entry

Make cooldown timeout on VDisk flexible

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Make VDisk start instantly when first run, otherwise wait for 15 seconds (upon receiving RecoverLostData state).

@alexvru alexvru force-pushed the vdisk/flexible-cooldown branch from 47956f5 to 89ba287 Compare May 15, 2024 12:36
@github-actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

⚪ 2024-05-15 12:38:49 UTC Pre-commit check for e13af46 has started.
⚪ 2024-05-15 12:38:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-15 12:40:33 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

⚪ 2024-05-15 12:38:52 UTC Pre-commit check for e13af46 has started.
⚪ 2024-05-15 12:38:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-15 12:40:38 UTC Build successful.
⚪ 2024-05-15 12:42:27 UTC Tests are running...
🔴 2024-05-15 12:42:56 UTC Test run completed, no test results found for commit 89ba287. Please check build logs.
⚫ 2024-05-15 12:42:58 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

⚪ 2024-05-15 12:38:56 UTC Pre-commit check for e13af46 has started.
⚪ 2024-05-15 12:38:59 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-15 12:40:42 UTC Build successful.
⚪ 2024-05-15 12:42:27 UTC Tests are running...
🔴 2024-05-15 12:42:56 UTC Test run completed, no test results found for commit 89ba287. Please check build logs.
⚫ 2024-05-15 12:42:58 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/flexible-cooldown branch 2 times, most recently from 9891fcd to 737db6b Compare May 15, 2024 12:45
@github-actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

⚪ 2024-05-15 12:46:37 UTC Pre-commit check for 31124a8 has started.
⚪ 2024-05-15 12:46:39 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-15 12:48:14 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

⚪ 2024-05-15 12:46:37 UTC Pre-commit check for 31124a8 has started.
⚪ 2024-05-15 12:46:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-15 12:48:17 UTC Build successful.
⚪ 2024-05-15 12:50:06 UTC Tests are running...
🔴 2024-05-15 14:27:31 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9277 9229 0 20 20 8

@github-actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

⚪ 2024-05-15 12:47:33 UTC Pre-commit check for 31124a8 has started.
⚪ 2024-05-15 12:47:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-15 12:49:04 UTC Build successful.
⚪ 2024-05-15 12:50:38 UTC Tests are running...
🔴 2024-05-15 14:03:07 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13380 12059 0 7 1297 17

@alexvru alexvru force-pushed the vdisk/flexible-cooldown branch from 737db6b to 9eecc95 Compare May 16, 2024 09:35
@github-actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

⚪ 2024-05-16 10:08:55 UTC Pre-commit check for 7cf0c07 has started.
⚪ 2024-05-16 10:08:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-16 10:10:32 UTC Build successful.
⚪ 2024-05-16 10:12:12 UTC Tests are running...
🔴 2024-05-16 11:48:10 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9584 9535 0 16 20 13

@alexvru alexvru marked this pull request as ready for review May 16, 2024 10:22
@alexvru alexvru merged commit 3516c45 into ydb-platform:main May 16, 2024
@github-actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

⚪ 2024-05-16 11:06:19 UTC Pre-commit check for 7cf0c07 has started.
⚪ 2024-05-16 11:06:21 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-16 11:15:12 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

⚪ 2024-05-16 11:16:11 UTC Pre-commit check for 7cf0c07 has started.
⚪ 2024-05-16 11:16:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-16 11:17:51 UTC Build successful.
⚪ 2024-05-16 11:19:32 UTC Tests are running...
🔴 2024-05-16 12:30:58 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13696 12369 0 12 1307 8

@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@alexvru @MrLolthe1st
Make cooldown timeout on VDisk flexible (ydb-platform#4551)
bfee146
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
This was referenced May 30, 2024
Merged
Closed
Closed
Merged
This was referenced Jun 7, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@alexvru alexvru deleted the vdisk/flexible-cooldown branch July 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kruall kruall kruall approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexvru @kruall