Skip to content

Fix a bug in additional YPath attrs deserialization #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 15, 2024
Merged

Fix a bug in additional YPath attrs deserialization #4505

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
62b68c0
Add support for <timestamp=...> in YT paths
Apr 12, 2024
788f20c
Fix build errors
Apr 12, 2024
3088a63
Use TCoVoid to represent absence of timestamp
Apr 15, 2024
2db42e3
Add support for general ypath attrs
Apr 16, 2024
bcacead
Fix CE
Apr 16, 2024
a12d5b0
Fix CE
Apr 16, 2024
01760c4
Fix a bug
Apr 17, 2024
2fe3e97
Add a check to filter out unsupported attrs
Apr 18, 2024
7fcfa07
Fixes
Apr 18, 2024
a63cc00
Fix a bug in additional YPath attrs deserialization
May 14, 2024
6771f68
Merge branch 'main' into dyntables-timestamp-fix
May 14, 2024
c3a6f65
Refactoring
May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ydb/library/yql/providers/yt/gateway/lib/yt_helpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,11 @@ TMaybe<TString> SerializeRichYPathAttrs(const NYT::TRichYPath& richPath) {
}

void DeserializeRichYPathAttrs(const TString& serializedAttrs, NYT::TRichYPath& richPath) {
NYT::TNode attrsNode = NYT::NodeFromYsonString(serializedAttrs);
auto originalYPath = richPath.Path_;
NYT::TNode pathNode = "";
pathNode.Attributes() = attrsNode;
NYT::TNode pathNode;
NYT::TNodeBuilder pathNodeBuilder(&pathNode);
NYT::Serialize(richPath, &pathNodeBuilder);
NYT::MergeNodes(pathNode.Attributes(), NYT::NodeFromYsonString(serializedAttrs));
NYT::Deserialize(richPath, pathNode);
richPath.Path_ = originalYPath;
}

IYtGateway::TCanonizedPath CanonizedPath(const TString& path) {
Expand Down