Skip to content

Fix 24 1 #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Fix 24 1 #4112

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd989fa
do not check explicit sources every cleanup
alexnick88 Apr 10, 2024
8be657b
Merge branch 'stable-24-1' of github.com:ydb-platform/ydb into stable…
alexnick88 Apr 19, 2024
7977a7b
Merge branch 'stable-24-1' of github.com:ydb-platform/ydb into stable…
alexnick88 Apr 25, 2024
969460d
fix for persqueue tests
alexnick88 Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions ydb/core/persqueue/ut/sourceid_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,27 +459,6 @@ Y_UNIT_TEST_SUITE(TSourceIdTests) {
UNIT_ASSERT(!emitter.CanEmit().Defined());
}
}

Y_UNIT_TEST(ExpensiveCleanup) {
TSourceIdStorage storage;
ui64 offset = 0;

// initial info w/o heartbeats
for (ui32 i = 1; i <= 100000; ++i) {
storage.RegisterSourceId(TestSourceId(i), MakeExplicitSourceIdInfo(++offset));
}

NKikimrPQ::TPartitionConfig config;
config.SetSourceIdLifetimeSeconds(TDuration::Hours(1).Seconds());

auto request = MakeHolder<TEvKeyValue::TEvRequest>();
for (ui32 i = 0; i < 1000; ++i) {
Cerr << "Iteration " << i << "\n";
const auto dropped = storage.DropOldSourceIds(request.Get(), TInstant::Hours(2), 1'000'000, TPartitionId(TestPartition), config);
UNIT_ASSERT_EQUAL(dropped, false);
}

}
} // TSourceIdTests

} // namespace NKikimr::NPQ