Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
41c781c
Only fomichev3000 can approve changes in this branch
alexv-smirnov Feb 1, 2024
2eba93f
Update CODEOWNERS
alexv-smirnov Feb 1, 2024
6149d92
Only members of ReleaseApprovers team can approve changes in this branch
alexv-smirnov Feb 1, 2024
8773c1c
merge performance improvement changes to stable-24-1 (#1576)
gridnevvvit Feb 5, 2024
4f74dd7
Add compatibility info (#1583)
serbel324 Feb 5, 2024
a2eb383
fix empty config requirement (#1622)
Enjection Feb 6, 2024
afd43bd
Set mkql runtime version. (#1609)
spuchin Feb 7, 2024
0d8c09c
Fix scheme_tests canondata (#1493) (#1643)
gridnevvvit Feb 7, 2024
9b503c2
remove debugging cerr (24-1) (#1642)
gridnevvvit Feb 7, 2024
2751a13
Merge some fixes from main (#1672)
alexvru Feb 7, 2024
9608841
Fix autoconfig's compute cpu table (#1701)
kruall Feb 8, 2024
ae6ef0c
YQL-17542 finalize split sync async CAs (#1689)
zverevgeny Feb 9, 2024
679ef9f
KIKIMR-21016: Проставить версию SSA Runtime в 24-1 (#1785)
iddqdex Feb 12, 2024
9e90229
Do not call TypeName if trace is not used. (#1506)
dcherednik Feb 12, 2024
2e2efae
improve base stats propagation logic (#1741) (#1857)
alexd65536 Feb 13, 2024
3db86df
Fix the processing of incorrect SourceId (#1555) (#1581)
nshestakov Feb 13, 2024
e95a49c
Make coordination session ping period dependent on session timeout KI…
snaury Feb 13, 2024
781d28d
Make stopping result/notification sending dependent on operation type…
snaury Feb 13, 2024
494165b
Disable volatile transactions KIKIMR-21060 (#1888)
snaury Feb 13, 2024
8e8a246
Disable KQP feature flags for stable branch. (#1885)
spuchin Feb 14, 2024
e479c3c
Remove MvccTestOutOfOrderRestartLocksSingleWithoutBarrier (#1905) (#1…
snaury Feb 14, 2024
81296f9
Mute CostMetrics tests in 24-1 (#1948)
serbel324 Feb 14, 2024
c076edf
Merge to 24.1 (#1772)
ssmike Feb 15, 2024
0c2f282
Fix readset acks sent too early in volatile transactions (#1961)
snaury Feb 16, 2024
1677666
Use uid as idempotency key KIKIMR-21059 (#2059)
CyberROFL Feb 19, 2024
cfdbc77
Enable DDL in ExecuteScript. Allow not to specify TxControl in QueryS…
UgnineSirdis Feb 19, 2024
782ac23
Fix lost coordinator steps during mediator reconnect race (#2037) (#2…
snaury Feb 19, 2024
c1a933b
Cannonized two plans (#1773) (#2081)
pavelvelikhov Feb 19, 2024
321f683
fix iam monitoring (#2061) (#2113)
adameat Feb 21, 2024
09dbd42
correctly fix memlimit exception problem (#2135)
gridnevvvit Feb 21, 2024
5e91e28
Disable distconf in 24-1 (#2147)
alexvru Feb 21, 2024
0872878
KIKIMR-20082: TableStore/ColumnTable with QueryService (#1377) (#1647)
shnikd Feb 21, 2024
08d5b07
Support temp tables in yql (#2141)
shnikd Feb 21, 2024
7d89162
Stable-24-1 cs patch 2 (#2145)
ivanmorozov333 Feb 22, 2024
fd4ca58
Merge default values for columns fixes and changes to stable 24 1 (#2…
gridnevvvit Feb 22, 2024
288a80b
Stable-24-1 patch for cs (#2142)
ivanmorozov333 Feb 22, 2024
fd0b1ac
Generate CMakeLists (#2184)
mvgorbunov Feb 22, 2024
14c6dfb
Fix partial distributed commit of uncommitted changes during shard re…
snaury Feb 22, 2024
5cd47d3
lower time difference issues from red to orange (#2197) (#2232)
adameat Feb 26, 2024
6a51e53
Fix ToFlow for dict join (#2267)
nikvas0 Feb 27, 2024
18848f2
Dont return shared nodes for serverless KIKIMR-21128 (#2264) (#2305)
pixcc Feb 29, 2024
385b62e
Stable-24-1 CS patch (#2363)
ivanmorozov333 Mar 1, 2024
b7a3970
YDB-1453 updated CORS response headers to healthcheck handler (#2174)…
StekPerepolnen Mar 1, 2024
d2983fe
Remove compatibility with 23-3 (#2377)
serbel324 Mar 1, 2024
5f8846d
Merge to 24-1 (#2367)
ssmike Mar 1, 2024
fba36c0
Regenerate CMakeLists (#2401)
mvgorbunov Mar 3, 2024
960afca
Fix stale read anomalies detected with Jepsen (#2374)
snaury Mar 4, 2024
f2b72c6
Improove tablet generation value in Topic protocol (#2375) (#2382)
nshestakov Mar 4, 2024
5b10401
Fix 24-1 read quoter crash (#2436)
FloatingCrowbar Mar 5, 2024
c9a38da
Kafka, read without consumer fixes and metrics fixes to 24-1 (#2412)
niksaveliev Mar 5, 2024
07bfc08
Mute OperationLog.ConcurrentWrites (#2450)
serbel324 Mar 5, 2024
c591cd0
Add deduplication options checks (#2254) (#2416)
FloatingCrowbar Mar 5, 2024
fad6d73
NBS-4415: changed log level for ReasonPill (#2271)
EvgeniyKozev Mar 5, 2024
c735d22
Cherry pick commit offsets fix (#2451)
ildar-khisambeev Mar 5, 2024
a607285
schemeboard: pass describe-result as an opaque payload (#2391)
ijon Mar 5, 2024
5635e2b
[cms] add start_time in public cms maintenance api (#2452) (#2472)
shmel1k Mar 5, 2024
0378eff
Invalidate query compilation cache entries with outdated VIEWs (#1960…
jepett0 Mar 6, 2024
4192b14
[ratelimiter] fix not_allowed message if no admins on cluster in conf…
shmel1k Mar 7, 2024
c206738
Fix Verify in pqv0 (#2552)
nshestakov Mar 7, 2024
52d299a
Enable feature flags for QueryService. (#2560)
spuchin Mar 7, 2024
7444062
Merge fix delete on queries with default values (#2569)
gridnevvvit Mar 8, 2024
179a3cb
cherry pick library fix (#2481)
ildar-khisambeev Mar 8, 2024
f24b02a
schemeboard: fix path updates from both root and tenant schemeshards …
ijon Mar 10, 2024
6a84178
Allow important consumer for all installations (#2518)
nshestakov Mar 12, 2024
623524f
[KIKIMR-21174] Remove wrong RuntimeVersion check (#2605) (#2629)
spuchin Mar 12, 2024
ed139af
Fix volatile result sent before it is fully committed (24-1) (#2624)
snaury Mar 12, 2024
3f93680
Generate CMakeLists (#2648)
mvgorbunov Mar 12, 2024
8688b17
Move construction of current compatibility information out of driver_…
serbel324 Mar 12, 2024
d9f2880
Fix script feature flag test in 24-1 (#2655)
UgnineSirdis Mar 12, 2024
b3004c6
simplify query service enable (#2676)
gridnevvvit Mar 12, 2024
c205eed
Use empty parsing context to build view's select in CREATE VIEW state…
jepett0 Mar 13, 2024
a510fe8
Fix Verify in WriteSessionActor (#2651) (#2700)
nshestakov Mar 14, 2024
9986dce
Fixing PartitionChooserActors leaks (#2742) (#2750)
nshestakov Mar 14, 2024
c1ad21b
Fix PEERDIRs (#2754)
serbel324 Mar 14, 2024
6d4a423
24-1: backport ydb#2397 add allow/deny lists to configs dispatcher (#…
Enjection Mar 15, 2024
cceacdc
24-1: Fix use-after-free when debug logging read errors (#2816)
snaury Mar 15, 2024
53c016c
[cms] add version to Node in Maintenance API (#2788) (#2796)
shmel1k Mar 15, 2024
9edd757
24-1: Fix missing locks on read iterator empty result elision. Fixes …
snaury Mar 16, 2024
bba277c
Fix put impl class (#2829) (#2853)
alexvru Mar 18, 2024
5ac0c0b
skip metrics without name label instead of crashing KIKIMR-21198 (#2883)
alexd65536 Mar 18, 2024
0aaa317
Call ProposeQueue.Ack for canceled txs (#2826)
azevaykin Mar 18, 2024
ccfeb7a
Update CMakeLists
mvgorbunov Mar 18, 2024
45a24af
[grpc_server] improve logs on server shutdown (#2910) (#2911)
shmel1k Mar 18, 2024
7e50ccf
Merge query service fixes to stable 24 1 (#2930)
gridnevvvit Mar 19, 2024
8d1f4fa
Fix BlobDepot interaction with group mapper in mirror-3-dc mode (#3006)
alexvru Mar 20, 2024
fe6d594
Fix NodeWarden caching error (#3014)
alexvru Mar 21, 2024
112be1a
24-1: Fix read iterator local snapshot consistency. Fixes #2885. (#3074)
snaury Mar 22, 2024
9a7d761
Update CMakeLists
mvgorbunov Mar 25, 2024
7023b13
[kqp] improve logging on KQP shutdown (#2927) (#2929)
shmel1k Mar 25, 2024
6fbfd4a
24-1: Fix race between table merge and borrowed gc compaction. Fixes …
snaury Mar 26, 2024
d563efb
Cherry pick fix leak (#3167)
ildar-khisambeev Mar 26, 2024
a762c76
Update datastreams_proxy supported codec (#2687)
Jornydb Mar 27, 2024
93f4928
fix query service enable order (#3312)
gridnevvvit Mar 29, 2024
bb2692a
disable oob transport (#3314)
gridnevvvit Mar 29, 2024
20a513d
Change codeowners for FQ 24-1 release branch (#3561)
EgorkaZ Apr 8, 2024
f756c0f
Fq gather stable 24-1 (#3517)
EgorkaZ Apr 9, 2024
dade7e2
YQ-3011 fix parquet type validation (#3595)
GrigoriyPA Apr 9, 2024
eba9328
Add pr tests run to q-stable (#3608)
EgorkaZ Apr 10, 2024
ce30b98
Downgrade RuntimeVersion Requirement for ReplicateScalar (#3667)
Hor911 Apr 11, 2024
db5a3b9
YQ-3035: FQ gather stable 24-1 lost ones (#3651)
EgorkaZ Apr 12, 2024
f4e9fa1
YQ-3050 fix forget operation paging (#3805)
GrigoriyPA Apr 17, 2024
5422281
brotli + new formats (#3855)
dorooleg Apr 18, 2024
f39e0b5
YQ-3006 added secrets validation (#3872)
GrigoriyPA Apr 18, 2024
c8094d4
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (#3565) (#3914)
EgorkaZ Apr 19, 2024
450d374
YQ-3045 fix for not found in s3 applicator (#3923)
GrigoriyPA Apr 19, 2024
773422c
Fix memory leak in external data source manager (#3961)
GrigoriyPA Apr 22, 2024
049f8e0
A pair of fixes (#3981)
Hor911 Apr 22, 2024
8ea00f0
YQ-3006 fix drop table for external entities
GrigoriyPA Apr 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
14 changes: 1 addition & 13 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,13 +1 @@
/ydb/core/fq/ @ydb-platform/fq
/ydb/core/public_http/ @ydb-platform/fq

/ydb/docs/ @ydb-platform/docs

/ydb/library/yql/ @ydb-platform/yql
/ydb/library/yql/providers/generic @ydb-platform/fq
/ydb/library/yql/providers/pq @ydb-platform/fq
/ydb/library/yql/providers/s3 @ydb-platform/fq
/ydb/library/yql/providers/solomon @ydb-platform/fq

/ydb/services/fq/ @ydb-platform/fq

* @ydb-platform/fq
5 changes: 4 additions & 1 deletion .github/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ inputs:
required: false
default: ""
description: "extra compile flags will be added to the end of C_FLAGS and CXX_FLAGS"
ninja_target:
required: false
type: string

runs:
using: "composite"
Expand Down Expand Up @@ -59,7 +62,7 @@ runs:
export CCACHE_SLOPPINESS=locale
export CCACHE_MAXSIZE=50G
cd ../build
ninja
ninja ${{ inputs.ninja_target }}
ccache -s
df -h
- name: report Build failed
Expand Down
138 changes: 138 additions & 0 deletions .github/actions/build_and_test_ya/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,138 @@
name: Ya-Build-and-Test
inputs:
build_target:
type: string
default: "ydb/"
description: "limit build and test to specific target"
build_preset:
type: string
run_build:
type: boolean
default: true
description: "run build"
run_tests:
type: boolean
default: true
description: "run tests"
run_tests_if_build_fails:
default: "true"
description: "run tests if build fails"
test_threads:
type: string
default: 28
description: "Test threads count"
link_threads:
type: string
default: 8
description: "link threads count"
test_size:
type: string
default: "small,medium,large"
test_type:
type: string
default: "unittest,py3test,py2test,pytest"
increment:
type: boolean
required: true
description: If true, compares build graphs between the current and previous commits to find a list of test suites to run. Otherwise, runs all tests.
folder_prefix:
type: string
default: "ya-"
put_build_results_to_cache:
type: boolean
default: true
secs:
type: string
default: ""
vars:
type: string
default: ""
defaults:
run:
shell: bash
runs:
using: "composite"
steps:
- name: comment-build-start
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
shell: bash
env:
BUILD_PRESET: ${{ inputs.build_preset }}
GITHUB_TOKEN: ${{ github.token }}
run: |
jobs_url="https://api.github.com/repos/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}/jobs"
# tricky: we are searching job with name that contains build_preset
check_url=$(curl -s $jobs_url | jq --arg n "$BUILD_PRESET" -r '.jobs[] | select(.name | contains($n)) | .html_url')

echo "Pre-commit [check]($check_url) for $(git rev-parse HEAD) has started." | .github/scripts/tests/comment-pr.py --rewrite

- name: Prepare s3cmd
uses: ./.github/actions/s3cmd
with:
s3_bucket: ${{ fromJSON( inputs.vars ).AWS_BUCKET }}
s3_endpoint: ${{ fromJSON( inputs.vars ).AWS_ENDPOINT }}
s3_key_id: ${{ fromJSON( inputs.secs ).AWS_KEY_ID }}
s3_key_secret: ${{ fromJSON( inputs.secs ).AWS_KEY_VALUE }}
folder_prefix: ya-
build_preset: ${{ inputs.build_preset }}

- name: Build
uses: ./.github/actions/build_ya
id: build
if: ${{ inputs.run_build == 'true' }}
with:
build_target: ${{ inputs.build_target }}
build_preset: ${{ inputs.build_preset }}
bazel_remote_uri: ${{ fromJSON( inputs.vars ).REMOTE_CACHE_URL || '' }}
bazel_remote_username: ${{ inputs.put_build_results_to_cache && fromJSON( inputs.secs ).REMOTE_CACHE_USERNAME || '' }}
bazel_remote_password: ${{ inputs.put_build_results_to_cache && fromJSON( inputs.secs ).REMOTE_CACHE_PASSWORD || '' }}
link_threads: ${{ inputs.link_threads }}

- name: Generate ya.make with affected test suites list
if: inputs.run_tests == 'true' && inputs.increment == 'true'
uses: ./.github/actions/graph_compare

- name: Check if there's a list of tests to run
id: test_run_choice
shell: bash
run: |
if [ -f ya.make ];then
echo "target='.'" >> $GITHUB_OUTPUT
echo "Listed test targets: "
cat ya.make
else
echo "target=${{ inputs.build_target }}" >> $GITHUB_OUTPUT
fi

- name: Run tests
uses: ./.github/actions/test_ya
if: ${{ inputs.run_tests == 'true' && (steps.build.outputs.success == 'true' || inputs.run_tests_if_build_fails == 'true') }}
with:
build_target: ${{ steps.test_run_choice.outputs.target }}
build_preset: ${{ inputs.build_preset }}
test_size: ${{ inputs.test_size }}
testman_token: ${{ fromJSON( inputs.secs ).TESTMO_TOKEN }}
testman_url: ${{ fromJSON( inputs.vars ).TESTMO_URL }}
testman_project_id: ${{ fromJSON( inputs.vars ).TESTMO_PROJECT_ID }}
link_threads: ${{ inputs.link_threads }}
test_threads: ${{ inputs.test_threads }}

- name: Notify about failed build
if: ${{ steps.build.outputs.success != 'true' && inputs.run_tests == 'true' && inputs.run_tests_if_build_fails == 'false' }}
shell: bash
run: |
echo 'Build failed. See the [build log](${{ steps.build.outputs.log_url }}).' >> $GITHUB_STEP_SUMMARY

if [[ "$GITHUB_EVENT_NAME" =~ ^pull_request ]]; then
echo "Tests run skipped." | .github/scripts/tests/comment-pr.py --fail
fi

exit 1

- name: comment-if-cancel
shell: bash
if: cancelled() && (github.event_name == 'pull_request' || github.event_name == 'pull_request_target')
env:
BUILD_PRESET: ${{ inputs.build_preset }}
GITHUB_TOKEN: ${{ github.token }}
run: echo "Check cancelled" | .github/scripts/tests/comment-pr.py --color black
29 changes: 23 additions & 6 deletions .github/actions/build_ya/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ inputs:
build_preset:
required: true
default: "relwithdebinfo"
description: "relwithdebinfo, release-asan, release-tsan"
description: "debug, relwithdebinfo, release-asan, release-tsan, release, release-cmake14"
bazel_remote_uri:
required: false
description: "bazel-remote endpoint"
Expand All @@ -21,7 +21,13 @@ inputs:
required: false
default: "8"
description: "link threads count"

outputs:
success:
value: ${{ steps.build.outputs.status }}
description: "build success"
log_url:
value: ${{ steps.init.outputs.log_url }}
description: "build log url"
runs:
using: "composite"
steps:
Expand All @@ -34,10 +40,15 @@ runs:
echo "SHELLOPTS=xtrace" >> $GITHUB_ENV
export TMP_DIR=$(pwd)/tmp_build
echo "TMP_DIR=$TMP_DIR" >> $GITHUB_ENV

export log_url="$S3_URL_PREFIX/build_logs/ya_make.log"

rm -rf $TMP_DIR && mkdir $TMP_DIR

echo "BUILD_PRESET=$build_preset" >> $GITHUB_ENV
echo "GITHUB_TOKEN=${{ github.token }}" >> $GITHUB_ENV
echo "LOG_URL=$log_url" >> $GITHUB_ENV
echo "log_url=$log_url" >> $GITHUB_OUTPUT

- name: build
id: build
Expand Down Expand Up @@ -67,6 +78,14 @@ runs:
relwithdebinfo)
build_type=relwithdebinfo
;;
release)
build_type=release
;;
release-clang14)
build_type=release
extra_params+=(--target-platform="CLANG14-LINUX-X86_64")
extra_params+=(-DLLD_VERSION=16)
;;
release-asan)
build_type=release
extra_params+=(--sanitize="address")
Expand Down Expand Up @@ -99,7 +118,7 @@ runs:
./ya make -k --build "${build_type}" --force-build-depends -D'BUILD_LANGUAGES=CPP PY3 PY2 GO' -T --stat -DCONSISTENT_DEBUG \
--log-file "$TMP_DIR/ya_log.txt" --evlog-file "$TMP_DIR/ya_evlog.jsonl" \
--cache-size 512G --link-threads "${{ inputs.link_threads }}" \
"${extra_params[@]}" |& tee $TMP_DIR/ya_make.log || (
"${extra_params[@]}" |& tee $TMP_DIR/ya_make.log && echo "status=true" >> $GITHUB_OUTPUT || (
RC=$?
echo "::debug::ya make RC=$RC"
echo "status=failed" >> $GITHUB_OUTPUT
Expand All @@ -118,10 +137,8 @@ runs:
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
shell: bash
run: |
log_url="$S3_URL_PREFIX/build_logs/ya_make.log"

if [ "${{ steps.build.outputs.status }}" == "failed" ]; then
echo "Build failed. see the [build logs]($log_url)." | .github/scripts/tests/comment-pr.py --fail
echo "Build failed. see the [build logs]($LOG_URL)." | .github/scripts/tests/comment-pr.py --fail
else
echo "Build successful." | .github/scripts/tests/comment-pr.py --ok
fi
Expand Down
18 changes: 18 additions & 0 deletions .github/actions/graph_compare/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: graph_compare
description: Compare graphs between current and previous commits (merge commit base in case of a merge commit), and list affected tests in ya.make
runs:
using: "composite"
steps:
- name: original_ref
id: oref
shell: bash
run: |
echo "value=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
- name: generate_ya_make
shell: bash
run: |
./.github/scripts/graph_compare.sh ${{ steps.oref.outputs.value }}~1 ${{ steps.oref.outputs.value }}
- name: restore_ref
shell: bash
run: |
git checkout ${{ steps.oref.outputs.value }}
3 changes: 2 additions & 1 deletion .github/actions/s3cmd/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ runs:
exit 1
;;
esac

echo "S3_BUCKET_PATH=s3://${{ inputs.s3_bucket }}/${{ github.repository }}/${{github.workflow}}/${{ github.run_id }}/${{ inputs.folder_prefix }}${folder}" >> $GITHUB_ENV
echo "S3_URL_PREFIX=${{ inputs.s3_endpoint }}/${{ inputs.s3_bucket }}/${{ github.repository }}/${{ github.workflow }}/${{ github.run_id }}/${{ inputs.folder_prefix }}${folder}" >> $GITHUB_ENV
echo "S3_TEST_ARTIFACTS_BUCKET_PATH=s3://${{ inputs.s3_bucket }}/testing_out_stuff/${{ github.repository }}/${{github.workflow}}/${{ github.run_id }}/${{ inputs.folder_prefix }}${folder}" >> $GITHUB_ENV
echo "S3_TEST_ARTIFACTS_URL_PREFIX=${{ inputs.s3_endpoint }}/${{ inputs.s3_bucket }}/testing_out_stuff/${{ github.repository }}/${{ github.workflow }}/${{ github.run_id }}/${{ inputs.folder_prefix }}${folder}" >> $GITHUB_ENV
env:
s3_key_id: ${{ inputs.s3_key_id }}
s3_secret_access_key: ${{ inputs.s3_key_secret }}
Loading