Allow DescribePartition request if UpdateRow permission is granted #4057

qyryq · 2024-04-23T20:35:21Z

No description provided.

Add Access field to TSchemeCacheNavigate::TEntry. Fix (?) parameter to SetErrorAndClear - should be inverted. Add DescribePartitionPermissions test to ydb_topic/ut/describe_topic_ut.cpp.

github-actions · 2024-04-23T20:38:49Z

⚪ 2024-04-23 20:38:49 UTC Pre-commit check for 203769f has started.
⚪ 2024-04-23 20:38:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-23 21:01:05 UTC Build successful.

github-actions · 2024-04-23T20:38:53Z

⚪ 2024-04-23 20:38:53 UTC Pre-commit check for 203769f has started.
⚪ 2024-04-23 20:38:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-23 21:02:02 UTC Build successful.
⚪ 2024-04-23 21:03:47 UTC Tests are running...
🔴 2024-04-23 22:18:49 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13611	11702	0	24	1860	25

github-actions · 2024-04-23T20:39:01Z

⚪ 2024-04-23 20:39:00 UTC Pre-commit check for 203769f has started.
⚪ 2024-04-23 20:39:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-23 21:02:24 UTC Build successful.
⚪ 2024-04-23 21:04:10 UTC Tests are running...
🔴 2024-04-23 22:50:53 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9510	9366	0	44	81	19

github-actions · 2024-04-24T06:53:41Z

⚪ 2024-04-24 06:53:41 UTC Pre-commit check for 3479e07 has started.
⚪ 2024-04-24 06:53:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-24 07:06:15 UTC Build successful.
⚪ 2024-04-24 07:07:59 UTC Tests are running...
🔴 2024-04-24 07:43:46 UTC Test run completed, no test results found for commit fdbc79b. Please check build logs.
⚫ 2024-04-24 07:43:49 UTC Check cancelled

github-actions · 2024-04-24T06:53:44Z

⚪ 2024-04-24 06:53:43 UTC Pre-commit check for 3479e07 has started.
⚪ 2024-04-24 06:53:46 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-24 07:07:12 UTC Build successful.
⚪ 2024-04-24 07:08:57 UTC Tests are running...
🔴 2024-04-24 07:43:47 UTC Test run completed, no test results found for commit fdbc79b. Please check build logs.
⚫ 2024-04-24 07:43:50 UTC Check cancelled

github-actions · 2024-04-24T06:53:48Z

⚪ 2024-04-24 06:53:48 UTC Pre-commit check for 3479e07 has started.
⚪ 2024-04-24 06:53:50 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-24 07:06:28 UTC Build successful.

github-actions · 2024-04-24T07:47:16Z

⚪ 2024-04-24 07:47:16 UTC Pre-commit check for 3d99ab3 has started.
⚪ 2024-04-24 07:47:18 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-24 07:51:42 UTC Build successful.

github-actions · 2024-04-24T07:48:04Z

⚪ 2024-04-24 07:48:03 UTC Pre-commit check for 3d99ab3 has started.
⚪ 2024-04-24 07:48:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-24 07:52:21 UTC Build successful.
⚪ 2024-04-24 07:54:29 UTC Tests are running...
🔴 2024-04-24 09:41:34 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9502	9356	0	40	93	13

github-actions · 2024-04-24T07:48:24Z

⚪ 2024-04-24 07:48:24 UTC Pre-commit check for 3d99ab3 has started.
⚪ 2024-04-24 07:48:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-24 07:52:01 UTC Build successful.
⚪ 2024-04-24 07:53:53 UTC Tests are running...
🔴 2024-04-24 09:13:17 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13607	11721	0	9	1860	17

github-actions · 2024-04-24T11:20:08Z

⚪ 2024-04-24 13:47:46 UTC Pre-commit check for 19b3c1b has started.
⚪ 2024-04-24 13:47:49 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-24 13:51:48 UTC Build successful.

github-actions · 2024-04-24T11:22:22Z

⚪ 2024-04-24 13:48:17 UTC Pre-commit check for 19b3c1b has started.
⚪ 2024-04-24 13:48:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-24 13:52:30 UTC Build successful.
⚪ 2024-04-24 13:54:18 UTC Tests are running...
🔴 2024-04-24 15:07:10 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13608	11725	0	6	1861	16

github-actions · 2024-04-24T11:22:35Z

⚪ 2024-04-24 13:47:55 UTC Pre-commit check for 19b3c1b has started.
⚪ 2024-04-24 13:47:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-24 13:52:19 UTC Build successful.
⚪ 2024-04-24 13:54:02 UTC Tests are running...
🔴 2024-04-24 15:33:48 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9507	9377	0	30	88	12

github-actions · 2024-04-25T07:18:39Z

⚪ 2024-04-25 10:00:09 UTC Pre-commit check for 618c7b0 has started.
⚪ 2024-04-25 10:00:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-25 10:01:19 UTC Build successful.
⚪ 2024-04-25 10:03:06 UTC Tests are running...
🔴 2024-04-25 11:13:04 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13621	11716	0	8	1869	28

github-actions · 2024-04-25T07:18:42Z

⚪ 2024-04-25 09:57:21 UTC Pre-commit check for 618c7b0 has started.
⚪ 2024-04-25 09:57:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-25 09:58:21 UTC Build successful.
⚪ 2024-04-25 09:59:57 UTC Tests are running...
🔴 2024-04-25 11:40:45 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9528	9352	0	36	109	31

github-actions · 2024-04-25T07:20:13Z

⚪ 2024-04-25 07:20:13 UTC Pre-commit check for 618c7b0 has started.
⚪ 2024-04-25 07:20:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-25 07:22:26 UTC Build successful.

alexnick88 · 2024-04-24T08:02:26Z

ydb/core/tx/scheme_board/cache.cpp

                        continue;
                    }

-                    const ui32 access = GetAccess(entry);


Why did you remove this function?

…db-platform#4057)

qyryq added 3 commits April 22, 2024 08:21

WIP Add broken test

04eb67c

Check access two times: 1 w/ UpdateRow, 2 w/ DescribeSchema perm

84d45a9

Add Access field to TSchemeCacheNavigate::TEntry. Fix (?) parameter to SetErrorAndClear - should be inverted. Add DescribePartitionPermissions test to ydb_topic/ut/describe_topic_ut.cpp.

Update DirectWriteWithoutDescribeResourcesPermission

6cc824f

Unfix a fix that breaks some tests

fdbc79b

qyryq added 2 commits April 24, 2024 07:43

Update tests

065d480

Undo a change

77b83fb

Minor changes

c53e299

qyryq mentioned this pull request Apr 24, 2024

Allow DescribePartition request if UpdateRow permission is granted; 2 states #4077

Closed

qyryq marked this pull request as ready for review April 25, 2024 07:15

mv CheckAccessWith{UpdateRow,WriteTopic}Permission; use GetAccess

7ca2632

qyryq force-pushed the persqueue-permit-describe-partition-if-has-write-permission branch from 51ac84a to 7ca2632 Compare April 25, 2024 07:17

alexnick88 approved these changes Apr 25, 2024

View reviewed changes

ydb/core/tx/scheme_board/cache.cpp

continue;

}

const ui32 access = GetAccess(entry);

Copy link

Collaborator

alexnick88 Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this function?

qyryq merged commit f78e8f8 into ydb-platform:main Apr 25, 2024

qyryq added a commit to qyryq/ydb that referenced this pull request Apr 25, 2024

Allow DescribePartition request if UpdateRow permission is granted (y…

65f7d70

…db-platform#4057)

qyryq mentioned this pull request Apr 26, 2024

Allow DescribePartition request if UpdateRow permission is granted #4146

Merged

qyryq added a commit to qyryq/ydb that referenced this pull request Apr 26, 2024

Allow DescribePartition request if UpdateRow permission is granted (y…

a234b7e

…db-platform#4057)

niksaveliev mentioned this pull request Apr 30, 2024

Fix ss test and temporary disable kafka balance ut #4202

Merged

GrigoriyPA mentioned this pull request May 8, 2024

YQ-3184 support create table as select in kqprun #4412

Merged

GrigoriyPA mentioned this pull request May 16, 2024

YQ-3225 add retries for tli in forget operation #4580

Closed

Allow DescribePartition request if UpdateRow permission is granted #4057

Allow DescribePartition request if UpdateRow permission is granted #4057

Uh oh!

Conversation

qyryq commented Apr 23, 2024

Uh oh!

github-actions bot commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexnick88 Apr 24, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading