Skip to content

portions normalizer #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2024
Merged

portions normalizer #4028

merged 3 commits into from
Apr 24, 2024

Conversation

nsofya
Copy link
Collaborator

@nsofya nsofya commented Apr 23, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 10:56:02 UTC Pre-commit check for 90e127d has started.
⚪ 2024-04-23 10:56:05 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-04-23 11:00:26 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 10:56:07 UTC Pre-commit check for 90e127d has started.
⚪ 2024-04-23 10:56:10 UTC Build linux-x86_64-release-asan is running...
🔴 2024-04-23 11:01:24 UTC Build failed. see the build logs.
🔴 2024-04-23 11:02:59 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 10:56:13 UTC Pre-commit check for 90e127d has started.
⚪ 2024-04-23 10:56:16 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-04-23 11:00:48 UTC Build failed. see the build logs.
🔴 2024-04-23 11:02:18 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 13:03:06 UTC Pre-commit check for a6e1e44 has started.
⚪ 2024-04-23 13:03:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-23 13:42:46 UTC Build successful.
⚪ 2024-04-23 13:44:31 UTC Tests are running...
🔴 2024-04-23 15:25:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8880 8751 0 32 84 13

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 13:03:42 UTC Pre-commit check for a6e1e44 has started.
⚪ 2024-04-23 13:03:44 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-23 13:43:09 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 13:06:45 UTC Pre-commit check for a6e1e44 has started.
⚪ 2024-04-23 13:06:46 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-23 13:45:56 UTC Build successful.
⚪ 2024-04-23 13:47:45 UTC Tests are running...
🔴 2024-04-23 15:00:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12818 10934 0 13 1860 11

ivanmorozov333
ivanmorozov333 reviewed Apr 23, 2024
View reviewed changes
ydb/core/tx/columnshard/normalizer/portion/portion.cpp Outdated
TDbWrapper db(txc.DB, nullptr);

for (auto&& portionInfo : Portions) {
auto schema = Schemas->at(portionInfo->GetPortionId());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:!

ydb/core/tx/columnshard/normalizer/portion/portion.cpp Outdated
}
};

class TPortionsNormalizerTask1 : public INormalizerTask {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task1

ydb/core/tx/columnshard/ut_rw/ut_normalizer.cpp
Y_UNIT_TEST(MinMaxNormalizer) {
TestNormalizerImpl<TMinMaxCleaner>();
Y_UNIT_TEST(PortionsNormalizer) {
TestNormalizerImpl<TPortinosCleaner>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPortinosCleaner

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 16:05:55 UTC Pre-commit check for 15dce1a has started.
⚪ 2024-04-23 16:05:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-23 16:10:18 UTC Build successful.
⚪ 2024-04-23 16:11:55 UTC Tests are running...
🔴 2024-04-23 17:21:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12826 10928 0 17 1861 20

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 16:06:20 UTC Pre-commit check for 15dce1a has started.
⚪ 2024-04-23 16:06:24 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-23 16:10:47 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 16:06:25 UTC Pre-commit check for 15dce1a has started.
⚪ 2024-04-23 16:06:27 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-23 16:11:09 UTC Build successful.
⚪ 2024-04-23 16:12:53 UTC Tests are running...
🔴 2024-04-23 17:53:12 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8880 8748 0 37 85 10

@nsofya nsofya merged commit ce6328c into ydb-platform:main Apr 24, 2024
3 of 5 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Apr 27, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Apr 30, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 8, 2024
Merged
nsofya added a commit to nsofya/ydb that referenced this pull request May 14, 2024
@nsofya
portions normalizer (ydb-platform#4028)
d3cab11 
Co-authored-by: nsofya <nsofya@yandex.ru>
@GrigoriyPA GrigoriyPA mentioned this pull request May 16, 2024
Closed
@nsofya nsofya deleted the portion_normalizer branch May 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsofya @ivanmorozov333