Skip to content

A pair of fixes #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024
Merged

A pair of fixes #3981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78ffa99
Initialize uninitialized (#3775)
Hor911 Apr 17, 2024
bafc4f3
Send UNVAILABLE if File lister is unavailable (#3859)
Hor911 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ydb/library/yql/providers/s3/actors/yql_s3_read_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ class TS3ReadActor : public TActorBootstrapped<TS3ReadActor>, public IDqComputeA
LOG_T("TS3ReadActor", "Handle undelivered FileQueue ");
if (!FileQueueEvents.HandleUndelivered(ev)) {
TIssues issues{TIssue{TStringBuilder() << "FileQueue was lost"}};
Send(ComputeActorId, new TEvAsyncInputError(InputIndex, issues, NYql::NDqProto::StatusIds::INTERNAL_ERROR));
Send(ComputeActorId, new TEvAsyncInputError(InputIndex, issues, NYql::NDqProto::StatusIds::UNAVAILABLE));
}
}

Expand Down Expand Up @@ -3399,12 +3399,12 @@ std::pair<NYql::NDq::IDqComputeActorAsyncInput*, IActor*> CreateS3ReadActor(
fileQueueActor = ActorIdFromProto(protoId);
}

ui64 fileQueueBatchSizeLimit;
ui64 fileQueueBatchSizeLimit = 0;
if (auto it = settings.find("fileQueueBatchSizeLimit"); it != settings.cend()) {
fileQueueBatchSizeLimit = FromString<ui64>(it->second);
}

ui64 fileQueueBatchObjectCountLimit;
ui64 fileQueueBatchObjectCountLimit = 0;
if (auto it = settings.find("fileQueueBatchObjectCountLimit"); it != settings.cend()) {
fileQueueBatchObjectCountLimit = FromString<ui64>(it->second);
}
Expand Down