Skip to content

YQ-3116 Add restoring issues to query status #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 17, 2024
Merged

YQ-3116 Add restoring issues to query status #3977

merged 6 commits into from
May 17, 2024

Conversation

@kardymonds
Copy link
Collaborator

@kardymonds kardymonds commented Apr 22, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@kardymonds kardymonds requested review from a team as code owners April 22, 2024 09:30
@github-actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

⚪ 2024-04-22 09:32:21 UTC Pre-commit check for afcaca2 has started.
⚪ 2024-04-22 09:32:23 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-04-22 09:34:55 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

⚪ 2024-04-22 09:34:16 UTC Pre-commit check for afcaca2 has started.
⚪ 2024-04-22 09:34:18 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-04-22 09:34:55 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

⚪ 2024-04-22 09:34:18 UTC Pre-commit check for afcaca2 has started.
⚪ 2024-04-22 09:34:20 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-04-22 09:34:55 UTC Check cancelled

@kardymonds kardymonds requested a review from a team as a code owner April 22, 2024 09:34
@github-actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

⚪ 2024-04-22 11:23:14 UTC Pre-commit check for 7899c57 has started.
⚪ 2024-04-22 11:23:17 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-22 12:03:29 UTC Build successful.
⚪ 2024-04-22 12:05:37 UTC Tests are running...
🔴 2024-04-22 14:01:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71452 58308 0 15 13110 19

@github-actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

⚪ 2024-04-22 11:25:31 UTC Pre-commit check for 7899c57 has started.
⚪ 2024-04-22 11:25:32 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-22 12:05:22 UTC Build successful.
⚪ 2024-04-22 12:07:02 UTC Tests are running...
🔴 2024-04-22 13:54:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12938 12734 0 58 125 21

@github-actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

⚪ 2024-04-22 11:27:15 UTC Pre-commit check for 7899c57 has started.
⚪ 2024-04-22 11:27:17 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-22 12:01:17 UTC Build successful.

dorooleg
dorooleg previously approved these changes Apr 23, 2024
View reviewed changes
UgnineSirdis
UgnineSirdis requested changes Apr 26, 2024
View reviewed changes
ydb/core/fq/libs/checkpointing/checkpoint_coordinator.cpp Outdated
<< ", checkpoint: " << checkpoint
<< ", status: " << statusName);
<< ", status: " << statusName
<< ", issues: " << record.GetIssues());
Copy link
Collaborator

@UgnineSirdis UgnineSirdis Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not good in common to have multiline string with issues in log. There is special logging method in TIssues, that is better to use here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/public/issue/yql_issue.h#L320

ydb/core/fq/libs/checkpointing/checkpoint_coordinator.cpp Outdated

if (status != NYql::NDqProto::TEvRestoreFromCheckpointResult_ERestoreStatus_OK) {
CC_LOG_E("[" << checkpoint << "] Can't restore: " << statusName);
auto msg = TStringBuilder() << "Can't restore: " << statusName << ", " << record.GetIssues();
Copy link
Collaborator

@UgnineSirdis UgnineSirdis Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not good in common to have multiline string with issues in log. There is special logging method in TIssues, that is better to use here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/public/issue/yql_issue.h#L320

But these issues should be subissues in checkpoint coordinator error message and TEvDqFailure

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 06:28:59 UTC Pre-commit check for 49074cc has started.
⚪ 2024-04-27 06:29:01 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-27 07:05:14 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 06:28:59 UTC Pre-commit check for 49074cc has started.
⚪ 2024-04-27 06:29:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-27 07:06:10 UTC Build successful.
⚪ 2024-04-27 07:08:00 UTC Tests are running...
🔴 2024-04-27 08:00:33 UTC Test run completed, no test results found for commit ced5a91. Please check build logs.
⚫ 2024-04-27 08:00:36 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 06:28:59 UTC Pre-commit check for 49074cc has started.
⚪ 2024-04-27 06:29:02 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-27 07:07:45 UTC Build successful.
⚪ 2024-04-27 07:09:35 UTC Tests are running...
🔴 2024-04-27 08:00:34 UTC Test run completed, no test results found for commit ced5a91. Please check build logs.
⚫ 2024-04-27 08:00:37 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 08:01:56 UTC Pre-commit check for f770d04 has started.
⚪ 2024-04-27 08:01:57 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-27 08:04:35 UTC Build successful.
⚪ 2024-04-27 08:06:15 UTC Tests are running...
🔴 2024-04-27 10:02:02 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71728 58590 0 8 13122 8

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 08:04:00 UTC Pre-commit check for f770d04 has started.
⚪ 2024-04-27 08:04:02 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-27 08:05:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 08:04:02 UTC Pre-commit check for f770d04 has started.
⚪ 2024-04-27 08:04:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-27 08:05:49 UTC Build successful.
⚪ 2024-04-27 08:07:37 UTC Tests are running...
🔴 2024-04-27 09:54:56 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13154 12970 0 53 118 13

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 10:18:56 UTC Pre-commit check for dcda354 has started.
⚪ 2024-04-27 10:18:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-27 10:21:58 UTC Build successful.
⚪ 2024-04-27 10:23:51 UTC Tests are running...
🔴 2024-04-27 12:18:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13161 12926 0 62 163 10

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 10:20:45 UTC Pre-commit check for dcda354 has started.
⚪ 2024-04-27 10:20:47 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-27 10:24:10 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

⚪ 2024-04-27 10:20:49 UTC Pre-commit check for dcda354 has started.
⚪ 2024-04-27 10:20:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-27 10:24:08 UTC Build successful.
⚪ 2024-04-27 10:25:58 UTC Tests are running...
🔴 2024-04-27 12:25:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71731 58591 0 8 13124 8

@kardymonds kardymonds merged commit 9f25ade into ydb-platform:main May 17, 2024
kardymonds added a commit to kardymonds/ydb that referenced this pull request May 17, 2024
@kardymonds
YQ-3116 Add restoring issues to query status (ydb-platform#3977)
d58f69e
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@kardymonds @MrLolthe1st
YQ-3116 Add restoring issues to query status (ydb-platform#3977)
ae99d20
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
This was referenced May 30, 2024
Merged
Closed
Closed
Merged
This was referenced Jun 7, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UgnineSirdis UgnineSirdis UgnineSirdis approved these changes

@dorooleg dorooleg dorooleg left review comments

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kardymonds @dorooleg @UgnineSirdis