Skip to content

YQ-3013: add retry for CURLE_GOT_NOTHING for FQ #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2024
Merged

YQ-3013: add retry for CURLE_GOT_NOTHING for FQ #3565

merged 5 commits into from
Apr 18, 2024

Conversation

@EgorkaZ
Copy link
Contributor

@EgorkaZ EgorkaZ commented Apr 8, 2024

Changelog entry

...

Changelog category

  • Improvement

Additional information

...

@EgorkaZ EgorkaZ requested review from a team as code owners April 8, 2024 14:38
@EgorkaZ EgorkaZ changed the title YQ-3013: add retry for code 52 for FQ YQ-3013: add retry for CURLE_GOT_NOTHING for FQ Apr 8, 2024
@github-actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

⚪ 2024-04-08 14:40:07 UTC Pre-commit check for d034c71 has started.
⚪ 2024-04-08 14:40:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-08 14:41:41 UTC Build successful.
⚪ 2024-04-08 14:43:10 UTC Tests are running...
🔴 2024-04-08 16:03:06 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32666 29316 0 13 3323 14

@github-actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

⚪ 2024-04-08 14:42:07 UTC Pre-commit check for d034c71 has started.
⚪ 2024-04-08 14:42:10 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-08 14:44:01 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

⚪ 2024-04-08 14:42:11 UTC Pre-commit check for d034c71 has started.
⚪ 2024-04-08 14:42:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-08 14:44:11 UTC Build successful.
⚪ 2024-04-08 14:45:55 UTC Tests are running...
🔴 2024-04-08 16:13:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8893 8655 0 39 184 15

uzhastik
uzhastik reviewed Apr 8, 2024
View reviewed changes
ydb/library/yql/providers/common/http_gateway/yql_http_default_retry_policy.h Outdated
std::unordered_set<CURLcode> ExtendedRetriedCodes;
};

IHTTPGateway::TRetryPolicy::TPtr GetHTTPDefaultRetryPolicy(THttpRetryPolicyOptions&& options);
Copy link
Collaborator

@uzhastik uzhastik Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

смысла в && не вижу. давай передадим по const&

Copy link
Contributor Author

@EgorkaZ EgorkaZ Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мы там меняем options.MaxTime, так что const не вариант (можно вытащить в локальные переменные, тогда станет уместным move(options) в лямбду, и снова const не подходит). Просто &, если это не output параметр — странно. Остаются && и передача по значению. Мне не принципиально, но вряд ли кому-то нужно копировать этот аргумент, так что &&

Copy link
Collaborator

@uzhastik uzhastik Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а ты не меняй аргумент. семантика функции не предполагает этого

@github-actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

⚪ 2024-04-10 12:05:06 UTC Pre-commit check for c860fd8 has started.
⚪ 2024-04-10 12:05:09 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-10 12:07:02 UTC Build successful.
⚪ 2024-04-10 12:08:43 UTC Tests are running...
🔴 2024-04-10 12:19:29 UTC Test run completed, no test results found for commit 8b04c1e. Please check build logs.
⚫ 2024-04-10 12:19:33 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

⚪ 2024-04-10 12:05:11 UTC Pre-commit check for c860fd8 has started.
⚪ 2024-04-10 12:05:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-10 12:07:11 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

⚪ 2024-04-10 12:05:27 UTC Pre-commit check for c860fd8 has started.
⚪ 2024-04-10 12:05:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-10 12:07:28 UTC Build successful.
⚪ 2024-04-10 12:09:11 UTC Tests are running...
⚫ 2024-04-10 12:19:54 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

⚪ 2024-04-10 12:23:42 UTC Pre-commit check for 11fc008 has started.
⚪ 2024-04-10 12:23:46 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-10 12:25:08 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

⚪ 2024-04-10 12:24:01 UTC Pre-commit check for 11fc008 has started.
⚪ 2024-04-10 12:24:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-10 12:25:27 UTC Build successful.
⚪ 2024-04-10 12:27:10 UTC Tests are running...
🔴 2024-04-10 13:54:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32724 29383 0 5 3324 12

@github-actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

⚪ 2024-04-10 12:24:04 UTC Pre-commit check for 11fc008 has started.
⚪ 2024-04-10 12:24:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-10 12:25:32 UTC Build successful.
⚪ 2024-04-10 12:27:20 UTC Tests are running...
🔴 2024-04-10 13:56:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8915 8671 0 39 189 16

@EgorkaZ EgorkaZ requested a review from uzhastik April 11, 2024 14:49
@github-actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited
Loading

⚪ 2024-04-15 11:15:14 UTC Pre-commit check for c28567c has started.
⚪ 2024-04-15 11:15:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-15 11:17:05 UTC Build successful.
⚪ 2024-04-15 11:18:48 UTC Tests are running...
🔴 2024-04-15 12:44:16 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32789 29417 0 3 3343 26

@github-actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited
Loading

⚪ 2024-04-15 11:15:18 UTC Pre-commit check for c28567c has started.
⚪ 2024-04-15 11:15:20 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-15 11:17:14 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited
Loading

⚪ 2024-04-15 11:16:32 UTC Pre-commit check for c28567c has started.
⚪ 2024-04-15 11:16:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-15 11:18:36 UTC Build successful.
⚪ 2024-04-15 11:20:19 UTC Tests are running...
🔴 2024-04-15 12:50:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8962 8754 0 30 148 30

@github-actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

⚪ 2024-04-17 13:04:50 UTC Pre-commit check for 22f5780 has started.
⚪ 2024-04-17 13:04:51 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-17 13:06:32 UTC Build successful.
⚪ 2024-04-17 13:08:11 UTC Tests are running...
🔴 2024-04-17 14:38:37 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8932 8715 0 37 154 26

@github-actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

⚪ 2024-04-17 13:08:58 UTC Pre-commit check for 22f5780 has started.
⚪ 2024-04-17 13:09:00 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-17 13:10:59 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

⚪ 2024-04-17 13:10:06 UTC Pre-commit check for 22f5780 has started.
⚪ 2024-04-17 13:10:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-17 13:11:44 UTC Build successful.
⚪ 2024-04-17 13:13:18 UTC Tests are running...
🔴 2024-04-17 14:36:07 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32963 29572 0 3 3360 28

@EgorkaZ EgorkaZ merged commit 75936dd into ydb-platform:main Apr 18, 2024
EgorkaZ added a commit to EgorkaZ/ydb that referenced this pull request Apr 19, 2024
@EgorkaZ
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (ydb-platform#3565)
531c0fc
EgorkaZ added a commit to EgorkaZ/ydb that referenced this pull request Apr 19, 2024
@EgorkaZ
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (ydb-platform#3565)
60eb068
EgorkaZ added a commit that referenced this pull request Apr 19, 2024
@EgorkaZ
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (#3565) (#3912)
a55d48b
EgorkaZ added a commit to EgorkaZ/ydb that referenced this pull request Apr 19, 2024
@EgorkaZ
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (ydb-platform#3565) (y…
d777ea9 
…db-platform#3912)
@GrigoriyPA GrigoriyPA mentioned this pull request Apr 19, 2024
Merged
EgorkaZ added a commit that referenced this pull request Apr 19, 2024
@EgorkaZ
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (#3565) (#3914)
c8094d4
skywalker-jpg pushed a commit to skywalker-jpg/ydb that referenced this pull request Apr 22, 2024
@EgorkaZ @skywalker-jpg
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (ydb-platform#3565)
78bace9
@GrigoriyPA GrigoriyPA mentioned this pull request Apr 24, 2024
Closed
@serbel324 serbel324 mentioned this pull request Apr 25, 2024
Merged
kardymonds pushed a commit to kardymonds/ydb that referenced this pull request Jun 10, 2024
@EgorkaZ @kardymonds
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (ydb-platform#3565) (y…
424339c 
…db-platform#3914)
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Jun 20, 2024
@EgorkaZ @uzhastik
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (ydb-platform#3565) (y…
b9ddc14 
…db-platform#3914)
uzhastik pushed a commit that referenced this pull request Jun 20, 2024
@EgorkaZ @uzhastik
YQ-3013: add retry for CURLE_GOT_NOTHING for FQ (#3565) (#3914)
b9c527d
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 15, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hor911 Hor911 Hor911 approved these changes

@rvu1024 rvu1024 rvu1024 approved these changes

@uzhastik uzhastik Awaiting requested review from uzhastik

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EgorkaZ @Hor911 @uzhastik @rvu1024