Skip to content

Support skipping blob header in TDiskBlob #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2024
Merged

Support skipping blob header in TDiskBlob #3145

merged 1 commit into from
Mar 26, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Mar 25, 2024

Changelog entry

Support skipping blob header in TDiskBlob

Changelog category

  • Improvement

Additional information

A support for headerless TDiskBlob has been added, allowing to remove 5-byte header and fix blob alignment.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 18:37:27 UTC Pre-commit check for 9095649 has started.
⚪ 2024-03-25 18:37:31 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-03-25 18:46:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 18:37:35 UTC Pre-commit check for 9095649 has started.
⚪ 2024-03-25 18:37:38 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-03-25 18:46:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 18:37:38 UTC Pre-commit check for 9095649 has started.
⚪ 2024-03-25 18:37:43 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-25 18:46:39 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/support-skipping-header-into-blobs branch from ac07f4a to 9477545 Compare March 25, 2024 18:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 18:47:51 UTC Pre-commit check for 31d7db5 has started.
⚪ 2024-03-25 18:47:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-25 18:56:45 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 18:47:51 UTC Pre-commit check for 31d7db5 has started.
⚪ 2024-03-25 18:47:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-25 18:55:26 UTC Build successful.
⚪ 2024-03-25 18:55:45 UTC Tests are running...
🔴 2024-03-25 19:03:11 UTC Test run completed, no test results found for commit 9477545. Please check build logs.
⚫ 2024-03-25 19:03:16 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 18:50:20 UTC Pre-commit check for 31d7db5 has started.
⚪ 2024-03-25 18:50:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-25 18:57:41 UTC Build successful.
⚪ 2024-03-25 18:57:57 UTC Tests are running...
🔴 2024-03-25 19:03:04 UTC Test run completed, no test results found for commit 9477545. Please check build logs.
⚫ 2024-03-25 19:03:08 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/support-skipping-header-into-blobs branch from 9477545 to e03898f Compare March 25, 2024 19:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 19:04:47 UTC Pre-commit check for 23f4724 has started.
⚪ 2024-03-25 19:04:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-25 19:06:20 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 19:06:54 UTC Pre-commit check for 23f4724 has started.
⚪ 2024-03-25 19:06:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-25 19:08:05 UTC Build successful.
⚪ 2024-03-25 19:08:27 UTC Tests are running...
🔴 2024-03-25 20:39:14 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14408 14157 0 43 183 25

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

⚪ 2024-03-25 19:06:58 UTC Pre-commit check for 23f4724 has started.
⚪ 2024-03-25 19:07:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-25 19:08:13 UTC Build successful.
⚪ 2024-03-25 19:08:27 UTC Tests are running...
🔴 2024-03-25 20:53:40 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69039 57933 0 6 11031 69

kruall
kruall previously approved these changes Mar 25, 2024
View reviewed changes
@alexvru alexvru force-pushed the vdisk/support-skipping-header-into-blobs branch from e03898f to 2ca114d Compare March 26, 2024 07:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

⚪ 2024-03-26 07:16:18 UTC Pre-commit check for e96252c has started.
⚪ 2024-03-26 07:16:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-26 07:31:58 UTC Build successful.
⚪ 2024-03-26 07:32:16 UTC Tests are running...
🔴 2024-03-26 09:06:05 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14410 14173 0 40 167 30

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

⚪ 2024-03-26 07:16:23 UTC Pre-commit check for e96252c has started.
⚪ 2024-03-26 07:16:25 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-26 07:29:43 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

⚪ 2024-03-26 07:17:29 UTC Pre-commit check for e96252c has started.
⚪ 2024-03-26 07:17:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-26 07:31:43 UTC Build successful.
⚪ 2024-03-26 07:31:53 UTC Tests are running...
🔴 2024-03-26 08:40:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69046 57919 0 13 11044 70

@alexvru alexvru merged commit b2f7f35 into ydb-platform:main Mar 26, 2024
@alexvru alexvru deleted the vdisk/support-skipping-header-into-blobs branch March 26, 2024 09:02
This was referenced Mar 29, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 2, 2024
Merged
@serbel324 serbel324 mentioned this pull request Apr 2, 2024
Merged
This was referenced Apr 4, 2024
Merged
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 4, 2024
Open
This was referenced Apr 6, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 10, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 11, 2024
Merged
This was referenced Apr 16, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruall kruall kruall approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexvru @kruall