-
Notifications
You must be signed in to change notification settings - Fork 727
YQ-4854 fixed streaming query not changed after create or replace #28171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
YQ-4854 fixed streaming query not changed after create or replace #28171
Conversation
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements query text revision tracking for streaming queries when using CREATE OR REPLACE, ensuring proper versioning and checkpoint recovery when queries are replaced.
- Increments
QueryTextRevisioncounter when replacing existing streaming queries instead of resetting to 1 - Adds comprehensive test coverage for
CREATE OR REPLACEscenarios including success cases, failures, and offset recovery
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/core/kqp/gateway/behaviour/streaming_query/queries.cpp | Modified ValidateProperties to increment QueryTextRevision when replacing an existing query |
| ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp | Added three new test cases validating CREATE OR REPLACE behavior for streaming queries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Fixed streaming query not changed after create or replace
Changelog category
Description for reviewers
Bugfix ticket: https://st.yandex-team.ru/YQ-4854