Skip to content

Conversation

@GrigoriyPA
Copy link
Collaborator

Changelog entry

Fixed streaming query not changed after create or replace

Changelog category

  • Bugfix

Description for reviewers

Bugfix ticket: https://st.yandex-team.ru/YQ-4854

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🟢 2025-11-03 09:09:38 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements query text revision tracking for streaming queries when using CREATE OR REPLACE, ensuring proper versioning and checkpoint recovery when queries are replaced.

  • Increments QueryTextRevision counter when replacing existing streaming queries instead of resetting to 1
  • Adds comprehensive test coverage for CREATE OR REPLACE scenarios including success cases, failures, and offset recovery

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ydb/core/kqp/gateway/behaviour/streaming_query/queries.cpp Modified ValidateProperties to increment QueryTextRevision when replacing an existing query
ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp Added three new test cases validating CREATE OR REPLACE behavior for streaming queries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 09:11:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for d202fd8 has started.
2025-11-03 09:11:42 UTC Artifacts will be uploaded here
2025-11-03 09:13:07 UTC ya make is running...
🟡 2025-11-03 10:36:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31445 30025 0 8 1388 24

2025-11-03 10:36:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-03 10:44:15 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 48 0 0 0 12

🟢 2025-11-03 10:44:17 UTC Build successful.
🟢 2025-11-03 10:44:34 UTC ydbd size 2.3 GiB changed* by +1.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1787dd7 merge: d202fd8 diff diff %
ydbd size 2 429 281 976 Bytes 2 429 283 640 Bytes +1.6 KiB +0.000%
ydbd stripped size 516 134 920 Bytes 516 135 240 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 09:11:35 UTC Pre-commit check linux-x86_64-release-asan for d202fd8 has started.
2025-11-03 09:11:52 UTC Artifacts will be uploaded here
2025-11-03 09:13:15 UTC ya make is running...
🟡 2025-11-03 11:12:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15316 14794 0 252 244 26

🟢 2025-11-03 11:12:41 UTC Build successful.
🟢 2025-11-03 11:13:05 UTC ydbd size 3.8 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1787dd7 merge: d202fd8 diff diff %
ydbd size 4 068 669 832 Bytes 4 068 672 184 Bytes +2.3 KiB +0.000%
ydbd stripped size 1 510 374 440 Bytes 1 510 375 144 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant