Skip to content

Conversation

@GrigoriyPA
Copy link
Collaborator

Changelog entry

Fixed checkpoints event undelivery logging in sync compute actor

Changelog category

  • Bugfix

Description for reviewers

Bugfix ticket: https://st.yandex-team.ru/YQ-4853

@GrigoriyPA GrigoriyPA requested review from Hor911 and Copilot November 3, 2025 08:29
@GrigoriyPA GrigoriyPA requested review from a team as code owners November 3, 2025 08:29
@GrigoriyPA GrigoriyPA requested a review from yumkam November 3, 2025 08:29
@github-actions github-actions bot added the bugfix label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🟢 2025-11-03 08:30:32 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 08:31:34 UTC Pre-commit check linux-x86_64-release-asan for d13ca21 has started.
2025-11-03 08:31:52 UTC Artifacts will be uploaded here
2025-11-03 08:33:13 UTC ya make is running...
🟡 2025-11-03 10:29:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15656 15272 0 153 204 27

🟢 2025-11-03 10:29:43 UTC Build successful.
🟢 2025-11-03 10:30:06 UTC ydbd size 3.8 GiB changed* by -15.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2d49061 merge: d13ca21 diff diff %
ydbd size 4 068 691 344 Bytes 4 068 675 288 Bytes -15.7 KiB -0.000%
ydbd stripped size 1 510 396 872 Bytes 1 510 376 424 Bytes -20.0 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds checkpoint handling support for undelivered events in the DQ compute actor. Previously, when an unexpected event undelivery occurred and checkpoints were enabled, the actor would only log the undelivered event. Now, if checkpoints are available, undelivered events are forwarded to the checkpoint handler for proper management.

  • Forward undelivered events to the Checkpoints actor when checkpointing is enabled
  • Only log unexpected undelivered events when checkpoints are not available

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 08:33:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for d13ca21 has started.
2025-11-03 08:33:31 UTC Artifacts will be uploaded here
2025-11-03 08:35:00 UTC ya make is running...
🟡 2025-11-03 10:07:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39249 36427 0 2 2791 29

2025-11-03 10:08:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-03 10:19:28 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 43 0 0 0 16

🟢 2025-11-03 10:19:31 UTC Build successful.
🟢 2025-11-03 10:19:47 UTC ydbd size 2.3 GiB changed* by +3.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2d49061 merge: d13ca21 diff diff %
ydbd size 2 429 281 768 Bytes 2 429 285 784 Bytes +3.9 KiB +0.000%
ydbd stripped size 516 141 960 Bytes 516 135 880 Bytes -5.9 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant