- 
                Notifications
    
You must be signed in to change notification settings  - Fork 727
 
YQ-4853 fixed checkpoints event undelivery logging #28170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
YQ-4853 fixed checkpoints event undelivery logging #28170
Conversation
| 
          
 🟢   | 
    
| 
          
 ⚪  
 🟢  
 *please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds checkpoint handling support for undelivered events in the DQ compute actor. Previously, when an unexpected event undelivery occurred and checkpoints were enabled, the actor would only log the undelivered event. Now, if checkpoints are available, undelivered events are forwarded to the checkpoint handler for proper management.
- Forward undelivered events to the Checkpoints actor when checkpointing is enabled
 - Only log unexpected undelivered events when checkpoints are not available
 
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 
          
 ⚪  ⚪  Ya make output | Test bloat | Test bloat 
 🟢  
 *please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation  | 
    
Changelog entry
Fixed checkpoints event undelivery logging in sync compute actor
Changelog category
Description for reviewers
Bugfix ticket: https://st.yandex-team.ru/YQ-4853