UI-QUERY-EXCLUDE for metadata queries #28155
Conversation
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds /*UI-QUERY-EXCLUDE*/ comments to SQL queries to mark them as internal queries that should be excluded from UI query logging or monitoring.
- Adds UI exclusion marker to metadata manager's SELECT query builder
- Adds UI exclusion marker to data source table accessor's snapshot fetching query
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/services/metadata/manager/table_record.cpp | Adds /*UI-QUERY-EXCLUDE*/ comment to the BuildSelectQuery method |
| ydb/services/metadata/ds_table/accessor_snapshot_base.cpp | Adds /*UI-QUERY-EXCLUDE*/ comment to the snapshot fetching query builder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sb << "--!syntax_v1\n"; | ||
| sb << "/*UI-QUERY-EXCLUDE*/" << Endl; | ||
| sb << "DECLARE $ids AS List<" << BuildColumnsSchemaTuple() << ">;" << Endl; | ||
| sb << "SELECT * FROM `" + tablePath + "`" << Endl; |
There was a problem hiding this comment.
The /*UI-QUERY-EXCLUDE*/ comment is only added to BuildSelectQuery, but similar query-building methods in the same file (BuildUpsertQuery, BuildInsertQuery, BuildDeleteQuery, BuildUpdateQuery) don't have this marker. Consider whether these other internal metadata queries should also be excluded from UI visibility for consistency.
1 participant
Changelog entry
The goal is to remove spam like
SELECT * FROM .metadata/initialization/migrationsfrom UI Top QueriesChangelog category
Description for reviewers
...